Avoid quadratic trackSymbol explosion from new trackedSymbols #56404

jakebailey · 2023-11-15T00:39:26Z

#51721 added a new trackedSymbols prop to serialized types, which when seen is used to pull tracked symbols from one context into another. But, if you look up a symbol in the same context, you'll keep pushing symbols onto yourself over and over when they're already tracked. So, if we see that the list is exactly the same, don't actually iterate over it.

Fixes #56371

jakebailey · 2023-11-15T00:39:37Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-11-15T00:39:39Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 7aeb7d8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-15T00:39:39Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 7aeb7d8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-15T00:39:39Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 7aeb7d8. You can monitor the build here.

typescript-bot · 2023-11-15T00:39:39Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 7aeb7d8. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-11-15T00:39:39Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 7aeb7d8. You can monitor the build here.

Update: The results are in!

jakebailey · 2023-11-15T00:41:26Z

@JoshuaKGoldberg there should be a tarball for you to test out in a bit.

typescript-bot · 2023-11-15T00:41:36Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/158596/artifacts?artifactName=tgz&fileId=BF7A4365719710A8AF87A468275F0B7CD2285D8A00DBF5463A8ACB7D5897723D02&fileName=/typescript-5.4.0-insiders.20231115.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

sheetalkamat

This seems correct but do we have a test case to add..

typescript-bot · 2023-11-15T00:58:36Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,166k (± 0.02%)}	_{295,175k (± 0.01%)}	_~	_295,110k	_295,224k	_{p=0.810 n=6}
_{Parse Time}	_{2.63s (± 0.21%)}	_{2.64s (± 0.39%)}	_~	_2.63s	_2.66s	_{p=0.138 n=6}
_{Bind Time}	_{0.82s (± 0.99%)}	_{0.83s (± 0.91%)}	_~	_0.82s	_0.84s	_{p=0.206 n=6}
_{Check Time}	_{8.04s (± 0.32%)}	_{8.03s (± 0.51%)}	_~	_7.97s	_8.07s	_{p=0.809 n=6}
_{Emit Time}	_{7.10s (± 0.35%)}	_{7.08s (± 0.33%)}	_~	_7.05s	_7.11s	_{p=0.090 n=6}
_{Total Time}	_{18.59s (± 0.14%)}	_{18.57s (± 0.25%)}	_~	_18.50s	_18.63s	_{p=0.687 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,648k (± 1.23%)}	_{194,023k (± 1.48%)}	_~	_190,666k	_196,521k	_{p=0.173 n=6}
_{Parse Time}	_{1.35s (± 1.01%)}	_{1.34s (± 0.77%)}	_~	_1.33s	_1.35s	_{p=0.293 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.14s (± 0.53%)}	_{9.14s (± 0.36%)}	_~	_9.10s	_9.19s	_{p=1.000 n=6}
_{Emit Time}	_{2.62s (± 0.86%)}	_{2.63s (± 0.56%)}	_~	_2.61s	_2.65s	_{p=0.515 n=6}
_{Total Time}	_{13.84s (± 0.39%)}	_{13.83s (± 0.27%)}	_~	_13.78s	_13.88s	_{p=0.748 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,331k (± 0.00%)}	_{347,345k (± 0.01%)}	_~	_347,315k	_347,378k	_{p=0.378 n=6}
_{Parse Time}	_{2.46s (± 0.26%)}	_{2.45s (± 0.52%)}	_~	_2.43s	_2.46s	_{p=0.152 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.92s (± 0.59%)}	_~	_0.92s	_0.93s	_{p=0.282 n=6}
_{Check Time}	_{6.92s (± 0.72%)}	_{6.93s (± 0.30%)}	_~	_6.90s	_6.96s	_{p=0.936 n=6}
_{Emit Time}	_{4.05s (± 0.41%)}	_{4.04s (± 0.33%)}	_~	_4.02s	_4.06s	_{p=0.249 n=6}
_{Total Time}	_{14.36s (± 0.36%)}	_{14.34s (± 0.20%)}	_~	_14.31s	_14.38s	_{p=0.573 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,626k (± 0.00%)}	_{302,623k (± 0.01%)}	_~	_302,605k	_302,642k	_{p=0.748 n=6}
_{Parse Time}	_{2.00s (± 1.07%)}	_{2.00s (± 0.86%)}	_~	_1.98s	_2.02s	_{p=1.000 n=6}
_{Bind Time}	_{1.00s (± 0.82%)}	_{1.01s (± 1.22%)}	_~	_0.99s	_1.02s	_{p=0.235 n=6}
_{Check Time}	_{6.26s (± 0.46%)}	_{6.26s (± 0.20%)}	_~	_6.25s	_6.28s	_{p=0.935 n=6}
_{Emit Time}	_{3.57s (± 0.34%)}	_{3.58s (± 0.70%)}	_~	_3.56s	_3.63s	_{p=0.623 n=6}
_{Total Time}	_{12.83s (± 0.19%)}	_{12.85s (± 0.20%)}	_~	_12.82s	_12.89s	_{p=0.167 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,586k (± 0.00%)}	_{470,561k (± 0.01%)}	_~	_470,510k	_470,603k	_{p=0.336 n=6}
_{Parse Time}	_{2.57s (± 0.43%)}	_{2.57s (± 0.60%)}	_~	_2.55s	_2.59s	_{p=1.000 n=6}
_{Bind Time}	_{0.99s (± 0.90%)}	_{0.99s (± 1.43%)}	_~	_0.97s	_1.01s	_{p=1.000 n=6}
_{Check Time}	_{16.63s (± 0.48%)}	_{16.62s (± 0.29%)}	_~	_16.57s	_16.71s	_{p=0.810 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.19s (± 0.48%)}	_{20.18s (± 0.30%)}	_~	_20.11s	_20.29s	_{p=0.810 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,831k (± 0.01%)}	_{512,884k (± 0.01%)}	_~	_512,817k	_512,947k	_{p=0.092 n=6}
_{Parse Time}	_{3.27s (± 0.19%)}	_{3.28s (± 0.32%)}	_~	_3.26s	_3.29s	_{p=0.388 n=6}
_{Bind Time}	_{1.54s (± 0.64%)}	_{1.54s (± 0.89%)}	_~	_1.51s	_1.55s	_{p=0.924 n=6}
_{Check Time}	_{2.86s (± 0.57%)}	_{2.87s (± 0.51%)}	_~	_2.85s	_2.89s	_{p=0.368 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.19%)}	_{7.77s (± 0.32%)}	_~	_7.72s	_7.79s	_{p=0.119 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,351ms (± 1.06%)}	_{2,361ms (± 0.67%)}	_~	_2,340ms	_2,382ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{5,393ms (± 1.39%)}	_{5,412ms (± 1.39%)}	_~	_5,306ms	_5,469ms	_{p=0.873 n=6}
_{Req 3 - references}	_{326ms (± 0.96%)}	_{325ms (± 0.77%)}	_~	_321ms	_328ms	_{p=0.806 n=6}
_{Req 4 - navto}	_{277ms (± 1.06%)}	_{275ms (± 1.22%)}	_~	_273ms	_280ms	_{p=0.185 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 6.22%)}	_{85ms (± 7.09%)}	_~	_75ms	_90ms	_{p=0.805 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,503ms (± 0.90%)}	_{2,476ms (± 0.94%)}	_~	_2,442ms	_2,511ms	_{p=0.066 n=6}
_{Req 2 - geterr}	_{4,105ms (± 1.92%)}	_{4,078ms (± 1.90%)}	_~	_4,016ms	_4,190ms	_{p=0.521 n=6}
_{Req 3 - references}	_{337ms (± 1.62%)}	_{340ms (± 1.98%)}	_~	_331ms	_346ms	_{p=0.418 n=6}
_{Req 4 - navto}	_{283ms (± 0.72%)}	_{283ms (± 0.65%)}	_~	_280ms	_285ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 7.74%)}	_{84ms (± 7.41%)}	_~	_78ms	_90ms	_{p=0.446 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,595ms (± 0.63%)}	_{2,599ms (± 0.59%)}	_~	_2,573ms	_2,614ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{1,702ms (± 2.16%)}	_{1,685ms (± 2.49%)}	_~	_1,663ms	_1,770ms	_{p=0.298 n=6}
_{Req 3 - references}	_{106ms (± 8.12%)}	_{116ms (± 8.68%)}	_{🔻+10ms (+ 9.48%)}	_103ms	_125ms	_{p=0.030 n=6}
_{Req 4 - navto}	_{367ms (± 0.40%)}	_{368ms (± 0.56%)}	_~	_364ms	_370ms	_{p=0.405 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,073 (± 0.00%)}	_~	_2,073	_2,073	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{307ms (± 2.15%)}	_{306ms (± 2.06%)}	_~	_300ms	_317ms	_{p=0.747 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{152.67ms (± 0.16%)}	_{152.54ms (± 0.17%)}	_{-0.13ms (- 0.08%)}	_151.60ms	_155.19ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.37ms (± 0.15%)}	_{227.29ms (± 0.18%)}	_{-0.07ms (- 0.03%)}	_226.14ms	_236.63ms	_{p=0.002 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.23ms (± 0.17%)}	_{229.25ms (± 0.18%)}	_~	_227.50ms	_237.39ms	_{p=0.854 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.05ms (± 0.15%)}	_{229.05ms (± 0.15%)}	_~	_227.64ms	_232.43ms	_{p=0.786 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-11-15T00:59:47Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/56404/merge:

There were infrastructure failures potentially unrelated to your change:

2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L23 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2023-11-15T01:30:37Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

JoshuaKGoldberg · 2023-11-15T02:36:48Z

Confirmed this fixes it for us, thanks so much @jakebailey!

Btw as a heads up for anybody else trying on typescript-eslint / typescript-eslint/typescript-eslint#7923, switching to "resolutions" > "typescript": "npm:@typescript-deploys/[email protected]" gives the following error in Yarn unless you rm -rf node_modules:

joshgoldberg ~/repos/typescript-eslint $ yarn
➤ YN0000: ┌ Project validation
➤ YN0057: │ website: Resolutions field will be ignored
➤ YN0000: └ Completed
➤ YN0000: ┌ Resolution step
➤ YN0001: │ RequestError: Socket connection timeout
    at ClientRequest.<anonymous> (/Users/josh/repos/typescript-eslint/.yarn/releases/yarn-3.6.4.cjs:195:14340)
    at Object.onceWrapper (node:events:626:26)
    at ClientRequest.emit (node:events:523:35)
    at o.emit (/Users/josh/repos/typescript-eslint/.yarn/releases/yarn-3.6.4.cjs:190:90286)
    at TLSSocket.socketErrorListener (node:_http_client:495:9)
    at TLSSocket.emit (node:events:511:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
    at new NodeError (node:internal/errors:399:5)
    at internalConnectMultiple (node:net:1099:20)
    at Timeout.internalConnectMultipleTimeout (node:net:1638:3)
    at listOnTimeout (node:internal/timers:575:11)
    at process.processTimers (node:internal/timers:514:7)
➤ YN0000: └ Completed in 3s 169ms
➤ YN0000: Failed with errors in 3s 173ms

typescript-bot · 2023-11-15T02:59:38Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/56404/merge:

Everything looks good!

jakebailey · 2023-11-15T03:10:26Z

Thanks for confirming. I'll need to try and figure out some sort of minimal repro for this... Which I don't expect to be easy.

Avoid quadratic trackSymbol explosion from new trackedSymbols

7aeb7d8

jakebailey requested a review from sheetalkamat November 15, 2023 00:39

typescript-bot assigned jakebailey Nov 15, 2023

typescript-bot added Author: Team labels Nov 15, 2023

typescript-bot assigned sheetalkamat Nov 15, 2023

typescript-bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 15, 2023

sheetalkamat reviewed Nov 15, 2023

View reviewed changes

jakebailey added 3 commits November 15, 2023 10:55

Add Map change just to note it

c3f0d2c

Add bad temporary test

3399edc

Make test self contained

06df470

jakebailey closed this Nov 17, 2023

jakebailey deleted the fix-51721 branch November 17, 2023 12:18

Avoid quadratic trackSymbol explosion from new trackedSymbols #56404

Avoid quadratic trackSymbol explosion from new trackedSymbols #56404

Uh oh!

Conversation

jakebailey commented Nov 15, 2023

Uh oh!

jakebailey commented Nov 15, 2023

Uh oh!

typescript-bot commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Nov 15, 2023

Uh oh!

typescript-bot commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheetalkamat left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Nov 15, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Nov 15, 2023

puppeteer

packages/browsers/test/src/tsconfig.json

Uh oh!

typescript-bot commented Nov 15, 2023

Uh oh!

JoshuaKGoldberg commented Nov 15, 2023

Uh oh!

typescript-bot commented Nov 15, 2023

Uh oh!

jakebailey commented Nov 15, 2023

Uh oh!

Uh oh!

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading

typescript-bot commented Nov 15, 2023 •

edited

Loading