Preserve partially typed tuple names in more places #55789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
weswigham
approved these changes
Oct 4, 2023
| @@ -265,8 +265,8 @@ f3((a, b, c) => {}) | |||
| f3((...x) => {}) | |||
| >f3((...x) => {}) : void | |||
| >f3 : (cb: (x: number, args_0: boolean, ...args_1: string[]) => void) => void | |||
| >(...x) => {} : (x_0: number, x_1: boolean, ...x_2: string[]) => void | |||
| >x : [number, boolean, ...string[]] | |||
| >(...x) => {} : (x: number, x_1: boolean, ...x_2: string[]) => void | |||
There was a problem hiding this comment.
This change is a little funky - x isn;t consistent with x_1, but not a dealbreaker.
There was a problem hiding this comment.
x is just the name given in the original type, the rest are generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53356 introduced the ability to have partially named tuples, but while working on another bug, I noticed that there were a few places that the PR missed that should also be preserving names. This fixes those cases, with tests.
There are still other calls to
createTupleTypewhich are missing names, but they all appear to be unable to generate them (anywhere that generates a tuple from a binding, or are "noramlizing" a tuple which can create more than one element for the same name).