Correctly resolve declared type for late bound property symbols of function expressions #55357

Andarist · 2023-08-14T08:46:19Z

noticed this while rechecking #29821 (I'm not marking this PR as closing that issue since what was reported there was fixed already fixed by #54726)

…nction expressions

typescript-bot · 2023-08-14T08:46:28Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

…s-declared-type

weswigham · 2023-09-13T18:59:10Z

@typescript-bot test this
@typescript-bot run dt
@typescript-bot test top100
@typescript-bot perf test this

typescript-bot · 2023-09-13T18:59:12Z

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 0a83e9e. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-13T18:59:12Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 0a83e9e. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-13T18:59:13Z

Heya @weswigham, I've started to run the regular perf test suite on this PR at 0a83e9e. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-13T19:56:10Z

@weswigham
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,269k (± 0.00%)}	_{300,282k (± 0.01%)}	_~	_300,265k	_300,314k	_{p=0.149 n=6}
_{Parse Time}	_{3.01s (± 0.17%)}	_{3.01s (± 0.14%)}	_~	_3.00s	_3.01s	_{p=0.595 n=6}
_{Bind Time}	_{0.93s (± 0.55%)}	_{0.93s (± 0.44%)}	_~	_0.93s	_0.94s	_{p=0.595 n=6}
_{Check Time}	_{9.31s (± 0.36%)}	_{9.34s (± 0.28%)}	_~	_9.30s	_9.38s	_{p=0.147 n=6}
_{Emit Time}	_{7.64s (± 0.23%)}	_{7.64s (± 0.30%)}	_~	_7.62s	_7.68s	_{p=1.000 n=6}
_{Total Time}	_{20.90s (± 0.23%)}	_{20.92s (± 0.18%)}	_~	_20.86s	_20.97s	_{p=0.421 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,912k (± 0.03%)}	_{193,974k (± 0.01%)}	_~	_193,938k	_193,992k	_{p=0.092 n=6}
_{Parse Time}	_{1.58s (± 0.26%)}	_{1.58s (± 0.52%)}	_~	_1.58s	_1.60s	_{p=0.218 n=6}
_{Bind Time}	_{0.80s (± 0.65%)}	_{0.80s (± 0.51%)}	_~	_0.79s	_0.80s	_{p=0.595 n=6}
_{Check Time}	_{9.95s (± 0.37%)}	_{9.93s (± 0.45%)}	_~	_9.87s	_10.00s	_{p=0.517 n=6}
_{Emit Time}	_{2.74s (± 0.30%)}	_{2.73s (± 0.30%)}	_{-0.01s (- 0.36%)}	_2.73s	_2.75s	_{p=0.031 n=6}
_{Total Time}	_{15.06s (± 0.24%)}	_{15.04s (± 0.28%)}	_~	_14.98s	_15.10s	_{p=0.517 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,195k (± 0.00%)}	_{347,196k (± 0.01%)}	_~	_347,157k	_347,222k	_{p=0.375 n=6}
_{Parse Time}	_{2.68s (± 0.19%)}	_{2.69s (± 0.43%)}	_~	_2.68s	_2.71s	_{p=0.191 n=6}
_{Bind Time}	_{0.99s (± 0.64%)}	_{0.99s (± 0.00%)}	_~	_0.99s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{7.92s (± 0.30%)}	_{7.93s (± 0.22%)}	_~	_7.90s	_7.95s	_{p=0.686 n=6}
_{Emit Time}	_{4.26s (± 0.35%)}	_{4.27s (± 0.36%)}	_~	_4.24s	_4.28s	_{p=0.216 n=6}
_{Total Time}	_{15.85s (± 0.14%)}	_{15.88s (± 0.12%)}	_~	_15.86s	_15.91s	_{p=0.107 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,177k (± 0.00%)}	_{301,180k (± 0.00%)}	_~	_301,160k	_301,190k	_{p=0.335 n=6}
_{Parse Time}	_{2.17s (± 0.56%)}	_{2.17s (± 0.56%)}	_~	_2.16s	_2.19s	_{p=1.000 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=1.000 n=6}
_{Check Time}	_{7.22s (± 0.27%)}	_{7.24s (± 0.20%)}	_~	_7.22s	_7.26s	_{p=0.168 n=6}
_{Emit Time}	_{3.98s (± 0.37%)}	_{3.98s (± 0.38%)}	_~	_3.97s	_4.01s	_{p=0.511 n=6}
_{Total Time}	_{14.49s (± 0.15%)}	_{14.51s (± 0.13%)}	_~	_14.49s	_14.53s	_{p=0.088 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,544k (± 0.00%)}	_{479,545k (± 0.00%)}	_~	_479,529k	_479,573k	_{p=0.810 n=6}
_{Parse Time}	_{3.15s (± 0.13%)}	_{3.15s (± 0.35%)}	_~	_3.14s	_3.17s	_{p=1.000 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.00%)}	_~	_0.91s	_0.91s	_{p=1.000 n=6}
_{Check Time}	_{17.92s (± 0.40%)}	_{17.86s (± 0.39%)}	_~	_17.77s	_17.95s	_{p=0.173 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.98s (± 0.32%)}	_{21.92s (± 0.36%)}	_~	_21.82s	_22.01s	_{p=0.230 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,925k (± 0.02%)}	_{542,855k (± 0.01%)}	_~	_542,793k	_542,961k	_{p=0.228 n=6}
_{Parse Time}	_{3.70s (± 0.14%)}	_{3.68s (± 0.33%)}	_~	_3.67s	_3.70s	_{p=0.051 n=6}
_{Bind Time}	_{1.43s (± 3.26%)}	_{1.40s (± 4.31%)}	_~	_1.34s	_1.45s	_{p=0.137 n=6}
_{Check Time}	_{3.21s (± 2.20%)}	_{3.26s (± 2.71%)}	_~	_3.17s	_3.35s	_{p=0.416 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.08s (± 9.79%)}	_~	_0.08s	_0.10s	_{p=0.752 n=6}
_{Total Time}	_{8.42s (± 0.26%)}	_{8.43s (± 0.48%)}	_~	_8.37s	_8.48s	_{p=0.871 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,489ms (± 0.06%)}	_{2,489ms (± 0.08%)}	_~	_2,487ms	_2,492ms	_{p=0.805 n=6}
_{Req 2 - geterr}	_{5,959ms (± 0.29%)}	_{5,953ms (± 0.33%)}	_~	_5,926ms	_5,979ms	_{p=0.575 n=6}
_{Req 3 - references}	_{343ms (± 0.43%)}	_{343ms (± 0.24%)}	_~	_341ms	_343ms	_{p=0.867 n=6}
_{Req 4 - navto}	_{275ms (± 0.15%)}	_{276ms (± 0.77%)}	_~	_274ms	_280ms	_{p=0.924 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 8.15%)}	_{85ms (± 8.41%)}	_~	_76ms	_94ms	_{p=0.517 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,623ms (± 0.45%)}	_{2,623ms (± 0.61%)}	_~	_2,604ms	_2,643ms	_{p=0.809 n=6}
_{Req 2 - geterr}	_{4,778ms (± 0.14%)}	_{4,770ms (± 0.28%)}	_~	_4,749ms	_4,785ms	_{p=0.199 n=6}
_{Req 3 - references}	_{350ms (± 0.15%)}	_{351ms (± 0.28%)}	_~	_350ms	_352ms	_{p=0.417 n=6}
_{Req 4 - navto}	_{269ms (± 0.28%)}	_{269ms (± 0.19%)}	_~	_268ms	_269ms	_{p=0.784 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 0.66%)}	_{79ms (± 0.00%)}	_~	_79ms	_79ms	_{p=0.174 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,708ms (± 0.21%)}	_{2,706ms (± 0.23%)}	_~	_2,697ms	_2,713ms	_{p=0.468 n=6}
_{Req 2 - geterr}	_{1,963ms (± 1.60%)}	_{1,983ms (± 0.66%)}	_~	_1,967ms	_2,007ms	_{p=0.109 n=6}
_{Req 3 - references}	_{140ms (± 0.98%)}	_{136ms (± 6.81%)}	_~	_118ms	_142ms	_{p=0.802 n=6}
_{Req 4 - navto}	_{362ms (± 0.94%)}	_{359ms (± 0.70%)}	_~	_357ms	_364ms	_{p=0.288 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{328ms (± 1.29%)}	_{327ms (± 1.51%)}	_~	_317ms	_330ms	_{p=0.511 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

CompilerTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
xstateTSServer - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{156.55ms (± 0.22%)}	_{156.60ms (± 0.17%)}	_~	_154.47ms	_159.21ms	_{p=0.378 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{231.00ms (± 0.14%)}	_{231.64ms (± 0.14%)}	_{+0.64ms (+ 0.28%)}	_230.18ms	_238.21ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.56ms (± 0.14%)}	_{235.96ms (± 0.13%)}	_{+0.40ms (+ 0.17%)}	_234.60ms	_239.78ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.73ms (± 0.13%)}	_{235.54ms (± 0.15%)}	_{-0.19ms (- 0.08%)}	_234.31ms	_241.68ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2023-09-13T20:02:12Z

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/55357/merge:

Everything looks good!

typescript-bot · 2023-09-13T20:37:36Z

Hey @weswigham, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

Correctly resolve declared type for late bound property symbols of fu…

d44c349

…nction expressions

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 14, 2023

This was referenced Aug 14, 2023

TS doesn't see when we add symbol properties to functions. #29821

Open

Fixed declaration emit for expando properties on function declarations declared using element access expressions #55183

Merged

Merge remote-tracking branch 'origin/main' into fix/late-bound-symbol…

0a83e9e

…s-declared-type

sandersn requested review from weswigham and andrewbranch August 23, 2023 23:03

sandersn assigned weswigham Aug 23, 2023

weswigham approved these changes Sep 13, 2023

View reviewed changes

Merge branch 'main' into fix/late-bound-symbols-declared-type

86bb81d

sandersn merged commit f834133 into microsoft:main Nov 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Correctly resolve declared type for late bound property symbols of function expressions #55357

Correctly resolve declared type for late bound property symbols of function expressions #55357

Uh oh!

Andarist commented Aug 14, 2023

Uh oh!

typescript-bot commented Aug 14, 2023

Uh oh!

weswigham commented Sep 13, 2023

Uh oh!

typescript-bot commented Sep 13, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Sep 13, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Sep 13, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Sep 13, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Sep 13, 2023

Uh oh!

typescript-bot commented Sep 13, 2023

Uh oh!

Uh oh!

Correctly resolve declared type for late bound property symbols of function expressions #55357

Correctly resolve declared type for late bound property symbols of function expressions #55357

Uh oh!

Conversation

Andarist commented Aug 14, 2023

Uh oh!

typescript-bot commented Aug 14, 2023

Uh oh!

weswigham commented Sep 13, 2023

Uh oh!

typescript-bot commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 13, 2023

Compiler

tsserver

Startup

Uh oh!

typescript-bot commented Sep 13, 2023

Uh oh!

typescript-bot commented Sep 13, 2023

Uh oh!

Uh oh!

typescript-bot commented Sep 13, 2023 •

edited

Loading

typescript-bot commented Sep 13, 2023 •

edited

Loading

typescript-bot commented Sep 13, 2023 •

edited

Loading