Fixed a redundant used before defined error #55283

Andarist · 2023-08-06T09:18:37Z

Andarist · 2023-08-06T09:19:35Z

tests/cases/compiler/noUsedBeforeDefinedErrorInTypeContext.ts

+let bar = {
+    three: {} as IThing<typeof bar>,
+}


this isn't actually super useful as the result of this is an implicit any but that's a separate error category and the reported "no used before defined" was still redundant

can you set @strict: true to show that the no implicit any errors are there?

jakebailey · 2023-08-07T18:47:29Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2023-08-07T18:47:33Z

Heya @jakebailey, I've started to run the extended test suite on this PR at ef9b771. You can monitor the build here.

typescript-bot · 2023-08-07T18:47:33Z

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at ef9b771. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-07T18:47:33Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at ef9b771. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-07T18:47:33Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at ef9b771. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-07T18:47:33Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at ef9b771. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-07T19:15:57Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/55283/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55283/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-08-07T19:16:06Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..55283

_Metric	_main	₅₅₂₈₃	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{368,247k (± 0.00%)}	_{368,270k (± 0.01%)}	_~	_368,247k	_368,294k	_{p=0.128 n=6}
_{Parse Time}	_{3.58s (± 0.42%)}	_{3.58s (± 0.33%)}	_~	_3.56s	_3.59s	_{p=0.621 n=6}
_{Bind Time}	_{1.19s (± 0.63%)}	_{1.19s (± 0.53%)}	_~	_1.18s	_1.20s	_{p=0.718 n=6}
_{Check Time}	_{9.85s (± 0.75%)}	_{9.85s (± 0.54%)}	_~	_9.76s	_9.91s	_{p=0.808 n=6}
_{Emit Time}	_{8.05s (± 1.10%)}	_{7.99s (± 0.56%)}	_~	_7.92s	_8.04s	_{p=0.199 n=6}
_{Total Time}	_{22.67s (± 0.59%)}	_{22.61s (± 0.40%)}	_~	_22.47s	_22.75s	_{p=0.336 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,839k (± 0.02%)}	_{193,807k (± 0.02%)}	_~	_193,769k	_193,860k	_{p=0.128 n=6}
_{Parse Time}	_{1.60s (± 1.02%)}	_{1.59s (± 0.47%)}	_~	_1.58s	_1.60s	_{p=0.454 n=6}
_{Bind Time}	_{0.82s (± 0.63%)}	_{0.82s (± 0.92%)}	_~	_0.81s	_0.83s	_{p=0.784 n=6}
_{Check Time}	_{10.25s (± 0.25%)}	_{10.20s (± 0.53%)}	_~	_10.14s	_10.28s	_{p=0.121 n=6}
_{Emit Time}	_{3.02s (± 0.91%)}	_{3.00s (± 0.83%)}	_~	_2.96s	_3.03s	_{p=0.413 n=6}
_{Total Time}	_{15.69s (± 0.37%)}	_{15.61s (± 0.35%)}	_{-0.08s (- 0.52%)}	_15.54s	_15.67s	_{p=0.035 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,099k (± 0.00%)}	_{347,096k (± 0.01%)}	_~	_347,066k	_347,131k	_{p=0.810 n=6}
_{Parse Time}	_{2.78s (± 0.72%)}	_{2.77s (± 0.63%)}	_~	_2.75s	_2.80s	_{p=0.627 n=6}
_{Bind Time}	_{1.08s (± 0.76%)}	_{1.08s (± 0.59%)}	_~	_1.07s	_1.09s	_{p=0.432 n=6}
_{Check Time}	_{8.10s (± 0.45%)}	_{8.07s (± 0.64%)}	_~	_8.00s	_8.13s	_{p=0.261 n=6}
_{Emit Time}	_{4.46s (± 0.12%)}	_{4.46s (± 0.76%)}	_~	_4.40s	_4.49s	_{p=0.933 n=6}
_{Total Time}	_{16.42s (± 0.35%)}	_{16.38s (± 0.49%)}	_~	_16.26s	_16.47s	_{p=0.378 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,122k (± 0.01%)}	_{301,143k (± 0.00%)}	_~	_301,128k	_301,167k	_{p=0.128 n=6}
_{Parse Time}	_{2.21s (± 1.17%)}	_{2.20s (± 0.47%)}	_~	_2.18s	_2.21s	_{p=0.220 n=6}
_{Bind Time}	_{1.22s (± 2.04%)}	_{1.20s (± 1.22%)}	_~	_1.19s	_1.23s	_{p=0.169 n=6}
_{Check Time}	_{7.36s (± 0.48%)}	_{7.35s (± 0.36%)}	_~	_7.32s	_7.39s	_{p=0.519 n=6}
_{Emit Time}	_{4.33s (± 1.05%)}	_{4.31s (± 0.68%)}	_~	_4.27s	_4.35s	_{p=0.335 n=6}
_{Total Time}	_{15.13s (± 0.62%)}	_{15.06s (± 0.36%)}	_~	_15.01s	_15.16s	_{p=0.173 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,893k (± 0.02%)}	_{481,904k (± 0.02%)}	_~	_481,843k	_482,050k	_{p=0.521 n=6}
_{Parse Time}	_{3.25s (± 0.49%)}	_{3.26s (± 0.53%)}	_~	_3.24s	_3.29s	_{p=0.623 n=6}
_{Bind Time}	_{0.96s (± 0.85%)}	_{0.96s (± 0.54%)}	_~	_0.95s	_0.96s	_{p=0.929 n=6}
_{Check Time}	_{18.49s (± 0.58%)}	_{18.46s (± 0.37%)}	_~	_18.36s	_18.52s	_{p=0.809 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.70s (± 0.50%)}	_{22.68s (± 0.27%)}	_~	_22.57s	_22.73s	_{p=0.520 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,396k (± 0.01%)}	_{561,432k (± 0.03%)}	_~	_561,311k	_561,675k	_{p=0.810 n=6}
_{Parse Time}	_{4.02s (± 0.26%)}	_{4.03s (± 0.33%)}	_~	_4.01s	_4.05s	_{p=0.506 n=6}
_{Bind Time}	_{1.79s (± 1.19%)}	_{1.77s (± 2.14%)}	_~	_1.73s	_1.81s	_{p=0.462 n=6}
_{Check Time}	_{3.06s (± 0.54%)}	_{3.06s (± 0.52%)}	_~	_3.04s	_3.08s	_{p=0.568 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.96s (± 0.34%)}	_{8.95s (± 0.51%)}	_~	_8.90s	_9.01s	_{p=0.748 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₅₂₈₃	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-08-07T20:20:50Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/55283/merge:

Everything looks good!

typescript-bot · 2023-08-07T20:50:44Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

…fore-define-error

Fixed a redundant used before defined error

ef9b771

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 6, 2023

Andarist commented Aug 6, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into fix/redundant-used-be…

f335466

…fore-define-error

sandersn requested a review from iisaduan August 24, 2023 15:30

sandersn assigned iisaduan Aug 24, 2023

sandersn approved these changes Aug 24, 2023

View reviewed changes

sandersn merged commit f07077c into microsoft:main Aug 24, 2023

Andarist deleted the fix/redundant-used-before-define-error branch August 24, 2023 15:36

snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023

Fixed a redundant used before defined error (microsoft#55283)

4fdd92b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed a redundant used before defined error #55283

Fixed a redundant used before defined error #55283

Andarist commented Aug 6, 2023

Andarist Aug 6, 2023

sandersn Aug 24, 2023

jakebailey commented Aug 7, 2023

typescript-bot commented Aug 7, 2023 •

edited

Loading

typescript-bot commented Aug 7, 2023 •

edited

Loading

typescript-bot commented Aug 7, 2023 •

edited

Loading

typescript-bot commented Aug 7, 2023 •

edited

Loading

typescript-bot commented Aug 7, 2023 •

edited

Loading

typescript-bot commented Aug 7, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Aug 7, 2023

typescript-bot commented Aug 7, 2023

typescript-bot commented Aug 7, 2023

Fixed a redundant used before defined error #55283

Fixed a redundant used before defined error #55283

Conversation

Andarist commented Aug 6, 2023

Andarist Aug 6, 2023

Choose a reason for hiding this comment

sandersn Aug 24, 2023

Choose a reason for hiding this comment

jakebailey commented Aug 7, 2023

typescript-bot commented Aug 7, 2023 • edited Loading

typescript-bot commented Aug 7, 2023 • edited Loading

typescript-bot commented Aug 7, 2023 • edited Loading

typescript-bot commented Aug 7, 2023 • edited Loading

typescript-bot commented Aug 7, 2023 • edited Loading

typescript-bot commented Aug 7, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Aug 7, 2023

typescript-bot commented Aug 7, 2023

typescript-bot commented Aug 7, 2023

typescript-bot commented Aug 7, 2023 •

edited

Loading

typescript-bot commented Aug 7, 2023 •

edited

Loading

typescript-bot commented Aug 7, 2023 •

edited

Loading

typescript-bot commented Aug 7, 2023 •

edited

Loading

typescript-bot commented Aug 7, 2023 •

edited

Loading