Skip to content

Add extra Date.UTC signature to reflect ES2017 changes #54125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2023

Conversation

joaonunomota
Copy link
Contributor

@joaonunomota joaonunomota commented May 4, 2023

Fixes #54084

Adds extra Date.UTC signature for ES2017. This is to reflect the monthIndex parameter being made optional for ES2017+ while keeping it required in versions prior to that.

Adds two tests to show a 1 argument Date.UTC working in ES2017 and failing in ES5.

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label May 4, 2023
@joaonunomota
Copy link
Contributor Author

@microsoft-github-policy-service agree

@sandersn
Copy link
Member

Thanks!

@sandersn sandersn merged commit 0d26261 into microsoft:main May 22, 2023
@joaonunomota joaonunomota deleted the es2017-utc branch May 23, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect definition for Date.UTC
3 participants