Instead of clearing out all resolutions and closing all the directory watchers, mark everything as invalidated when changes affect module resolution #53882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sheetalkamat
commented
Apr 17, 2023
sheetalkamat
commented
- This avoids unnecessary watch closing and adding depending on resolution setting.
- Also changed how we toggle js setting for inferred project when inferred project becomes orphan. Before this change in inferred project with only js file, we would toggle it to non js when that js file is closed and then when another js file is opened reusing the inferred project we would retoggle it back to js project
…d so all watches are not cleared up
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
commented
Apr 18, 2023
Comment on lines
-120
to
-126
| /user/username/projects/myproject/data.json: | ||
| {"pollingInterval":500} *new* | ||
| /user/username/projects/myproject/node_modules/@types: | ||
| {"pollingInterval":500} *new* | ||
| /user/username/projects/node_modules/@types: | ||
| {"pollingInterval":500} *new* | ||
|
|
There was a problem hiding this comment.
These use to be deleted and created again when module resolution settings changed
sheetalkamat
commented
Apr 18, 2023
| @@ -515,7 +515,7 @@ Loading module as file / folder, candidate module location '/user/username/proje | |||
| File '/user/username/projects/transitiveReferences/b.ts' does not exist. | |||
| File '/user/username/projects/transitiveReferences/b.tsx' does not exist. | |||
| File '/user/username/projects/transitiveReferences/b.d.ts' does not exist. | |||
| File '/user/username/projects/transitiveReferences/b/package.json' does not exist. | |||
| File '/user/username/projects/transitiveReferences/b/package.json' does not exist according to earlier cached lookups. | |||
There was a problem hiding this comment.
We also dont need to re-read package json because of this.
sheetalkamat
commented
Apr 18, 2023
| @@ -90,10 +90,6 @@ Info seq [hh:mm:ss:mss] Config: /user/username/projects/myproject/jsconfig.json | |||
| } | |||
| Info seq [hh:mm:ss:mss] DirectoryWatcher:: Added:: WatchInfo: /user/username/projects/myproject 1 undefined Config: /user/username/projects/myproject/jsconfig.json WatchType: Wild card directory | |||
| Info seq [hh:mm:ss:mss] Elapsed:: *ms DirectoryWatcher:: Added:: WatchInfo: /user/username/projects/myproject 1 undefined Config: /user/username/projects/myproject/jsconfig.json WatchType: Wild card directory | |||
| Info seq [hh:mm:ss:mss] DirectoryWatcher:: Close:: WatchInfo: /user/username/projects/myproject/node_modules/@types 1 undefined Project: /dev/null/inferredProject1* WatchType: Type roots | |||
There was a problem hiding this comment.
This was because inferred project was marked to be non js and it would mean change in options that affect module so earlier we were closing all the watchers, but now we keep them alive (just like if it would have been ts only inferred project to start with)
sheetalkamat
commented
Apr 18, 2023
| Info seq [hh:mm:ss:mss] Elapsed:: *ms DirectoryWatcher:: Added:: WatchInfo: /user/username/projects/myproject/node_modules/@types 1 undefined Project: /user/username/projects/myproject/c/tsconfig.json WatchType: Type roots | ||
| Info seq [hh:mm:ss:mss] DirectoryWatcher:: Added:: WatchInfo: /user/username/projects/node_modules/@types 1 undefined Project: /user/username/projects/myproject/c/tsconfig.json WatchType: Type roots | ||
| Info seq [hh:mm:ss:mss] Elapsed:: *ms DirectoryWatcher:: Added:: WatchInfo: /user/username/projects/node_modules/@types 1 undefined Project: /user/username/projects/myproject/c/tsconfig.json WatchType: Type roots | ||
| Info seq [hh:mm:ss:mss] DirectoryWatcher:: Close:: WatchInfo: /user/username/projects/myproject/refs 1 undefined Project: /user/username/projects/myproject/c/tsconfig.json WatchType: Failed Lookup Locations |
There was a problem hiding this comment.
This shows how we only close -not needed directory watcher only instead of deleting all and adding them back
jakebailey
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.