Skip to content

Fix 53482 : Preserve newline/space behavior #53732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 18, 2023
Merged

Fix 53482 : Preserve newline/space behavior #53732

merged 6 commits into from
Apr 18, 2023

Conversation

iinicole
Copy link
Contributor

Fixes #53482

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Apr 11, 2023
@iinicole
Copy link
Contributor Author

@iinicole please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

iinicole
iinicole commented Apr 11, 2023
View reviewed changes
@iinicole
Copy link
Contributor Author

@andrewbranch Hi! Could you please help review my pull request? I might also need some help in determining whether my changes provide the current behavior and modifying the old test cases to fit such behaviors. Thanks!

@iinicole
Copy link
Contributor Author

iinicole commented Apr 12, 2023 •
edited
Loading

@andrewbranch Thanks for your advice! I have changed my code accordingly and added the test case in fourslash. Let me know if I got the idea correct this time.

@andrewbranch
Copy link
Member

@iinicole this looks great! Let’s just run the perf and language server tests:

@typescript-bot perf test this
@typescript-bot test tsserver top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 12, 2023 •
edited
Loading

Heya @andrewbranch, I've started to run the perf test suite on this PR at 4d6ad11. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 12, 2023 •
edited
Loading

Heya @andrewbranch, I've started to run the diff-based top-repos suite (tsserver) on this PR at 4d6ad11. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53732
Metric main 53732 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 365,323k (± 0.01%) 365,339k (± 0.01%) ~ 365,273k 365,415k p=0.521 n=6
Parse Time 3.40s (± 0.64%) 3.40s (± 0.24%) ~ 3.39s 3.41s p=0.357 n=6
Bind Time 1.12s (± 0.00%) 1.12s (± 0.36%) ~ 1.12s 1.13s p=0.405 n=6
Check Time 8.77s (± 0.25%) 8.74s (± 0.57%) ~ 8.67s 8.80s p=0.418 n=6
Emit Time 7.49s (± 0.80%) 7.48s (± 0.39%) ~ 7.45s 7.53s p=0.872 n=6
Total Time 20.79s (± 0.23%) 20.75s (± 0.36%) ~ 20.65s 20.84s p=0.335 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,763k (± 1.18%) 191,776k (± 1.17%) ~ 190,826k 196,350k p=0.689 n=6
Parse Time 1.50s (± 0.42%) 1.50s (± 0.70%) ~ 1.49s 1.52s p=0.388 n=6
Bind Time 0.77s (± 0.00%) 0.77s (± 0.98%) ~ 0.76s 0.78s p=0.598 n=6
Check Time 9.58s (± 0.71%) 9.62s (± 0.59%) ~ 9.56s 9.72s p=0.422 n=6
Emit Time 2.72s (± 1.24%) 2.75s (± 0.70%) ~ 2.72s 2.77s p=0.168 n=6
Total Time 14.57s (± 0.54%) 14.64s (± 0.53%) ~ 14.54s 14.77s p=0.148 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,508k (± 0.01%) 346,514k (± 0.01%) ~ 346,473k 346,566k p=0.810 n=6
Parse Time 2.60s (± 0.97%) 2.60s (± 1.01%) ~ 2.58s 2.65s p=0.686 n=6
Bind Time 1.00s (± 0.81%) 1.01s (± 0.81%) ~ 1.00s 1.02s p=0.389 n=6
Check Time 7.13s (± 0.64%) 7.12s (± 0.64%) ~ 7.08s 7.19s p=0.872 n=6
Emit Time 4.28s (± 1.71%) 4.26s (± 0.89%) ~ 4.22s 4.32s p=0.936 n=6
Total Time 15.01s (± 0.65%) 14.99s (± 0.36%) ~ 14.93s 15.08s p=0.936 n=6
TFS - node (v18.10.0, x64)
Memory used 300,724k (± 0.01%) 300,709k (± 0.01%) ~ 300,688k 300,742k p=0.471 n=6
Parse Time 2.07s (± 1.01%) 2.06s (± 0.66%) ~ 2.04s 2.08s p=0.934 n=6
Bind Time 1.14s (± 0.45%) 1.14s (± 1.20%) ~ 1.12s 1.16s p=0.198 n=6
Check Time 6.58s (± 0.60%) 6.57s (± 0.40%) ~ 6.55s 6.62s p=0.746 n=6
Emit Time 3.85s (± 1.03%) 3.85s (± 0.51%) ~ 3.82s 3.88s p=0.331 n=6
Total Time 13.65s (± 0.50%) 13.62s (± 0.43%) ~ 13.56s 13.73s p=0.468 n=6
material-ui - node (v18.10.0, x64)
Memory used 480,178k (± 0.01%) 480,175k (± 0.01%) ~ 480,062k 480,236k p=0.810 n=6
Parse Time 3.04s (± 0.45%) 3.04s (± 0.87%) ~ 3.02s 3.09s p=0.934 n=6
Bind Time 0.92s (± 2.10%) 0.92s (± 2.53%) ~ 0.91s 0.97s p=1.000 n=6
Check Time 16.92s (± 0.33%) 16.96s (± 0.20%) ~ 16.90s 17.00s p=0.091 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.88s (± 0.29%) 20.93s (± 0.26%) ~ 20.84s 21.00s p=0.260 n=6
xstate - node (v18.10.0, x64)
Memory used 562,182k (± 0.02%) 562,187k (± 0.02%) ~ 562,065k 562,349k p=0.810 n=6
Parse Time 3.82s (± 0.42%) 3.83s (± 0.77%) ~ 3.80s 3.86s p=0.868 n=6
Bind Time 1.65s (± 0.31%) 1.64s (± 0.46%) ~ 1.63s 1.65s p=0.107 n=6
Check Time 2.86s (± 0.62%) 2.83s (± 0.47%) -0.03s (- 0.99%) 2.82s 2.85s p=0.023 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.41s (± 0.30%) 8.38s (± 0.29%) ~ 8.34s 8.41s p=0.053 n=6
Angular - node (v16.17.1, x64)
Memory used 364,717k (± 0.01%) 364,721k (± 0.01%) ~ 364,676k 364,778k p=0.936 n=6
Parse Time 3.55s (± 1.00%) 3.55s (± 0.78%) ~ 3.51s 3.58s p=0.871 n=6
Bind Time 1.18s (± 1.13%) 1.18s (± 1.07%) ~ 1.16s 1.19s p=0.931 n=6
Check Time 9.53s (± 0.67%) 9.54s (± 0.25%) ~ 9.50s 9.57s p=0.574 n=6
Emit Time 7.99s (± 0.64%) 7.97s (± 0.69%) ~ 7.90s 8.04s p=0.506 n=6
Total Time 22.25s (± 0.51%) 22.24s (± 0.30%) ~ 22.16s 22.35s p=0.936 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,527k (± 0.03%) 192,532k (± 0.03%) ~ 192,484k 192,614k p=1.000 n=6
Parse Time 1.59s (± 0.95%) 1.60s (± 1.30%) ~ 1.56s 1.62s p=0.871 n=6
Bind Time 0.83s (± 0.99%) 0.83s (± 0.66%) ~ 0.82s 0.83s p=0.859 n=6
Check Time 10.36s (± 0.72%) 10.30s (± 0.15%) ~ 10.28s 10.32s p=0.195 n=6
Emit Time 3.02s (± 1.18%) 2.98s (± 0.72%) ~ 2.95s 3.00s p=0.102 n=6
Total Time 15.80s (± 0.69%) 15.70s (± 0.32%) ~ 15.65s 15.77s p=0.089 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,788k (± 0.00%) 345,771k (± 0.00%) -17k (- 0.00%) 345,760k 345,790k p=0.031 n=6
Parse Time 2.72s (± 0.60%) 2.73s (± 0.51%) ~ 2.71s 2.75s p=1.000 n=6
Bind Time 1.08s (± 0.48%) 1.08s (± 0.50%) ~ 1.08s 1.09s p=0.640 n=6
Check Time 7.82s (± 0.54%) 7.80s (± 0.31%) ~ 7.76s 7.83s p=0.169 n=6
Emit Time 4.50s (± 0.76%) 4.47s (± 0.52%) ~ 4.44s 4.50s p=0.142 n=6
Total Time 16.13s (± 0.44%) 16.08s (± 0.15%) ~ 16.04s 16.11s p=0.090 n=6
TFS - node (v16.17.1, x64)
Memory used 300,053k (± 0.01%) 300,063k (± 0.01%) ~ 300,043k 300,093k p=0.810 n=6
Parse Time 2.16s (± 0.35%) 2.16s (± 0.63%) ~ 2.15s 2.18s p=0.672 n=6
Bind Time 1.24s (± 0.88%) 1.23s (± 1.11%) ~ 1.22s 1.25s p=0.456 n=6
Check Time 7.22s (± 0.62%) 7.22s (± 0.39%) ~ 7.18s 7.25s p=1.000 n=6
Emit Time 4.33s (± 0.66%) 4.35s (± 0.69%) ~ 4.32s 4.41s p=0.145 n=6
Total Time 14.96s (± 0.37%) 14.97s (± 0.36%) ~ 14.90s 15.03s p=0.517 n=6
material-ui - node (v16.17.1, x64)
Memory used 479,490k (± 0.01%) 479,502k (± 0.01%) ~ 479,427k 479,561k p=0.936 n=6
Parse Time 3.24s (± 0.23%) 3.24s (± 0.39%) ~ 3.22s 3.25s p=0.676 n=6
Bind Time 0.96s (± 0.57%) 0.95s (± 1.23%) ~ 0.93s 0.96s p=0.859 n=6
Check Time 18.03s (± 0.86%) 17.97s (± 0.53%) ~ 17.85s 18.10s p=0.748 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.22s (± 0.73%) 22.16s (± 0.48%) ~ 22.03s 22.30s p=0.688 n=6
xstate - node (v16.17.1, x64)
Memory used 559,769k (± 0.02%) 559,692k (± 0.02%) ~ 559,589k 559,844k p=0.378 n=6
Parse Time 3.98s (± 0.30%) 3.99s (± 0.44%) ~ 3.97s 4.02s p=0.217 n=6
Bind Time 1.75s (± 0.56%) 1.74s (± 0.47%) ~ 1.73s 1.75s p=0.062 n=6
Check Time 3.06s (± 0.40%) 3.06s (± 0.45%) ~ 3.05s 3.08s p=0.177 n=6
Emit Time 0.09s (± 5.53%) 0.09s (± 4.45%) ~ 0.09s 0.10s p=0.595 n=6
Total Time 8.88s (± 0.09%) 8.89s (± 0.19%) ~ 8.87s 8.92s p=0.452 n=6
Angular - node (v14.15.1, x64)
Memory used 358,504k (± 0.00%) 358,502k (± 0.00%) ~ 358,489k 358,525k p=0.689 n=6
Parse Time 3.64s (± 0.36%) 3.64s (± 0.51%) ~ 3.62s 3.67s p=0.560 n=6
Bind Time 1.21s (± 0.43%) 1.22s (± 0.62%) ~ 1.21s 1.23s p=0.069 n=6
Check Time 9.94s (± 0.66%) 9.93s (± 0.49%) ~ 9.86s 9.99s p=0.575 n=6
Emit Time 8.36s (± 1.47%) 8.29s (± 0.29%) ~ 8.27s 8.34s p=0.468 n=6
Total Time 23.16s (± 0.75%) 23.09s (± 0.37%) ~ 23.00s 23.20s p=0.688 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,818k (± 0.01%) 187,821k (± 0.01%) ~ 187,792k 187,841k p=0.575 n=6
Parse Time 1.60s (± 0.47%) 1.60s (± 0.92%) ~ 1.58s 1.62s p=0.620 n=6
Bind Time 0.86s (± 1.55%) 0.85s (± 1.05%) ~ 0.84s 0.86s p=0.345 n=6
Check Time 10.43s (± 0.20%) 10.44s (± 0.83%) ~ 10.28s 10.54s p=0.172 n=6
Emit Time 3.17s (± 1.31%) 3.13s (± 0.62%) ~ 3.10s 3.15s p=0.145 n=6
Total Time 16.06s (± 0.36%) 16.02s (± 0.63%) ~ 15.84s 16.14s p=0.747 n=6
Monaco - node (v14.15.1, x64)
Memory used 340,670k (± 0.00%) 340,668k (± 0.01%) ~ 340,638k 340,695k p=0.873 n=6
Parse Time 2.83s (± 0.62%) 2.83s (± 1.14%) ~ 2.79s 2.87s p=0.935 n=6
Bind Time 1.11s (± 0.95%) 1.10s (± 0.68%) ~ 1.09s 1.11s p=0.273 n=6
Check Time 8.14s (± 0.32%) 8.13s (± 0.65%) ~ 8.05s 8.19s p=0.747 n=6
Emit Time 4.71s (± 0.95%) 4.69s (± 0.69%) ~ 4.65s 4.72s p=0.418 n=6
Total Time 16.79s (± 0.36%) 16.75s (± 0.43%) ~ 16.66s 16.87s p=0.466 n=6
TFS - node (v14.15.1, x64)
Memory used 295,145k (± 0.01%) 295,142k (± 0.00%) ~ 295,130k 295,149k p=0.810 n=6
Parse Time 2.41s (± 0.90%) 2.39s (± 0.31%) ~ 2.38s 2.40s p=0.217 n=6
Bind Time 1.07s (± 0.48%) 1.06s (± 0.49%) ~ 1.06s 1.07s p=0.311 n=6
Check Time 7.57s (± 0.39%) 7.56s (± 0.30%) ~ 7.53s 7.58s p=0.333 n=6
Emit Time 4.30s (± 1.22%) 4.28s (± 0.83%) ~ 4.23s 4.33s p=1.000 n=6
Total Time 15.34s (± 0.35%) 15.30s (± 0.30%) ~ 15.22s 15.35s p=0.295 n=6
material-ui - node (v14.15.1, x64)
Memory used 474,886k (± 0.01%) 474,908k (± 0.00%) ~ 474,888k 474,922k p=0.149 n=6
Parse Time 3.37s (± 0.66%) 3.36s (± 0.72%) ~ 3.35s 3.41s p=0.558 n=6
Bind Time 1.00s (± 0.75%) 1.00s (± 0.98%) ~ 0.99s 1.01s p=1.000 n=6
Check Time 18.97s (± 0.91%) 18.86s (± 0.50%) ~ 18.74s 18.97s p=0.261 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.35s (± 0.80%) 23.23s (± 0.39%) ~ 23.09s 23.33s p=0.335 n=6
xstate - node (v14.15.1, x64)
Memory used 548,273k (± 0.00%) 548,282k (± 0.00%) ~ 548,267k 548,304k p=0.521 n=6
Parse Time 4.33s (± 1.79%) 4.35s (± 1.69%) ~ 4.25s 4.41s p=0.807 n=6
Bind Time 1.60s (± 4.57%) 1.57s (± 4.69%) ~ 1.52s 1.67s p=0.190 n=6
Check Time 3.19s (± 0.90%) 3.21s (± 0.68%) ~ 3.18s 3.24s p=0.573 n=6
Emit Time 0.09s (± 5.53%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=1.000 n=6
Total Time 9.22s (± 0.28%) 9.22s (± 0.20%) ~ 9.21s 9.26s p=0.744 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53732 6
Baseline main 6

TSServer

Comparison Report - main..53732
Metric main 53732 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,402ms (± 0.67%) 2,411ms (± 0.64%) ~ 2,385ms 2,431ms p=0.376 n=6
Req 2 - geterr 5,704ms (± 0.83%) 5,715ms (± 1.05%) ~ 5,628ms 5,812ms p=0.810 n=6
Req 3 - references 337ms (± 1.21%) 335ms (± 0.81%) ~ 333ms 340ms p=0.571 n=6
Req 4 - navto 281ms (± 0.99%) 281ms (± 0.85%) ~ 278ms 285ms p=0.935 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 83ms (± 3.04%) 85ms (± 1.24%) ~ 83ms 86ms p=0.241 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,499ms (± 1.90%) 2,509ms (± 1.25%) ~ 2,474ms 2,561ms p=0.748 n=6
Req 2 - geterr 4,262ms (± 0.54%) 4,259ms (± 0.40%) ~ 4,230ms 4,280ms p=0.810 n=6
Req 3 - references 343ms (± 0.75%) 347ms (± 0.34%) +4ms (+ 1.07%) 346ms 349ms p=0.042 n=6
Req 4 - navto 292ms (± 0.71%) 291ms (± 0.60%) ~ 289ms 294ms p=0.683 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 64ms (± 4.73%) 68ms (± 5.73%) ~ 63ms 71ms p=0.084 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,023ms (± 0.50%) 3,010ms (± 0.36%) ~ 2,996ms 3,023ms p=0.127 n=6
Req 2 - geterr 1,618ms (± 0.87%) 1,614ms (± 0.56%) ~ 1,601ms 1,629ms p=0.630 n=6
Req 3 - references 106ms (± 1.44%) 106ms (± 1.39%) ~ 104ms 108ms p=0.462 n=6
Req 4 - navto 363ms (± 0.88%) 364ms (± 0.32%) ~ 363ms 366ms p=0.627 n=6
Req 5 - completionInfo count 2,862 (± 0.00%) 2,862 (± 0.00%) ~ 2,862 2,862 p=1.000 n=6
Req 5 - completionInfo 369ms (± 1.63%) 367ms (± 1.89%) ~ 357ms 375ms p=0.810 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,519ms (± 0.64%) 2,525ms (± 0.84%) ~ 2,505ms 2,554ms p=0.575 n=6
Req 2 - geterr 6,101ms (± 1.15%) 6,141ms (± 0.93%) ~ 6,066ms 6,218ms p=0.423 n=6
Req 3 - references 346ms (± 0.70%) 345ms (± 0.41%) ~ 343ms 347ms p=0.808 n=6
Req 4 - navto 280ms (± 1.07%) 279ms (± 0.27%) ~ 278ms 280ms p=0.454 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 86ms (± 5.57%) 80ms (± 0.79%) 🟩-6ms (- 6.43%) 79ms 81ms p=0.006 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,658ms (± 1.05%) 2,668ms (± 0.75%) ~ 2,649ms 2,699ms p=0.748 n=6
Req 2 - geterr 4,634ms (± 0.43%) 4,634ms (± 0.33%) ~ 4,616ms 4,654ms p=1.000 n=6
Req 3 - references 358ms (± 0.35%) 358ms (± 0.41%) ~ 356ms 360ms p=0.867 n=6
Req 4 - navto 285ms (± 0.98%) 288ms (± 0.99%) ~ 283ms 291ms p=0.126 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 68ms (± 0.81%) 68ms (± 1.79%) ~ 67ms 70ms p=0.855 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,178ms (± 0.45%) 3,182ms (± 0.22%) ~ 3,172ms 3,191ms p=0.630 n=6
Req 2 - geterr 1,761ms (± 0.90%) 1,758ms (± 0.33%) ~ 1,751ms 1,764ms p=0.470 n=6
Req 3 - references 115ms (± 2.49%) 117ms (± 3.38%) ~ 112ms 121ms p=0.520 n=6
Req 4 - navto 348ms (± 1.22%) 345ms (± 1.86%) ~ 338ms 353ms p=0.630 n=6
Req 5 - completionInfo count 2,862 (± 0.00%) 2,862 (± 0.00%) ~ 2,862 2,862 p=1.000 n=6
Req 5 - completionInfo 387ms (± 1.08%) 391ms (± 0.74%) ~ 387ms 395ms p=0.226 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,608ms (± 0.41%) 2,602ms (± 0.60%) ~ 2,580ms 2,616ms p=0.572 n=6
Req 2 - geterr 6,441ms (± 1.12%) 6,410ms (± 0.96%) ~ 6,349ms 6,505ms p=0.471 n=6
Req 3 - references 360ms (± 0.98%) 361ms (± 0.65%) ~ 358ms 364ms p=0.292 n=6
Req 4 - navto 285ms (± 0.72%) 285ms (± 0.70%) ~ 282ms 287ms p=0.681 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 91ms (± 5.30%) 93ms (± 6.79%) ~ 89ms 102ms p=0.530 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,832ms (± 0.18%) 2,825ms (± 0.52%) ~ 2,802ms 2,842ms p=0.377 n=6
Req 2 - geterr 4,730ms (± 0.45%) 4,733ms (± 0.53%) ~ 4,701ms 4,763ms p=1.000 n=6
Req 3 - references 375ms (± 0.82%) 375ms (± 0.82%) ~ 371ms 379ms p=0.936 n=6
Req 4 - navto 291ms (± 0.35%) 292ms (± 0.75%) ~ 289ms 295ms p=0.568 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 76ms (± 5.95%) 79ms (± 5.12%) ~ 73ms 82ms p=0.562 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,396ms (± 0.61%) 3,420ms (± 0.08%) ~ 3,417ms 3,424ms p=0.065 n=6
Req 2 - geterr 1,866ms (± 0.99%) 1,851ms (± 0.79%) ~ 1,829ms 1,871ms p=0.173 n=6
Req 3 - references 125ms (± 0.93%) 125ms (± 1.09%) ~ 123ms 127ms p=0.506 n=6
Req 4 - navto 378ms (± 1.15%) 378ms (± 1.03%) ~ 371ms 381ms p=0.739 n=6
Req 5 - completionInfo count 2,862 (± 0.00%) 2,862 (± 0.00%) ~ 2,862 2,862 p=1.000 n=6
Req 5 - completionInfo 411ms (± 1.45%) 409ms (± 0.98%) ~ 404ms 415ms p=0.936 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53732 6
Baseline main 6

Startup

Comparison Report - main..53732
Metric main 53732 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.67ms (± 0.17%) 142.54ms (± 0.23%) +0.87ms (+ 0.61%) 141.55ms 150.42ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 220.31ms (± 0.22%) 223.98ms (± 0.54%) +3.67ms (+ 1.66%) 219.96ms 233.85ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 222.39ms (± 0.33%) 226.21ms (± 0.21%) +3.82ms (+ 1.72%) 221.88ms 232.28ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 204.10ms (± 0.31%) 206.85ms (± 0.37%) +2.75ms (+ 1.35%) 203.61ms 215.94ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53732 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/53732/merge:

Everything looks good!

@andrewbranch andrewbranch requested a review from rbuckton April 12, 2023 18:48
@andrewbranch andrewbranch merged commit 178198b into microsoft:main Apr 18, 2023
@andrewbranch
Copy link
Member

Thanks @iinicole!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@andrewbranch andrewbranch andrewbranch approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract refactors break single-line if statements into two lines
4 participants
@iinicole @andrewbranch @typescript-bot @DanielRosenwasser