-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Fix incorrect setting of nonRecursive watch field #53675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say I know what's going on here but there's clearly a comment right above there that says it should be non-recursive 😄
| //vda1cs4850/dir/somefile.d.ts | | | | ||
| //vda1cs4850/dir/subdir/somefile.d.ts | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean when Recursive
is blank?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If second column (path to watch) is blank recursive is blank meaning these kind of paths will be ignored for setting directory watchers
So there's a comment above like
How does that interact with stuff like |
https://github.com/microsoft/TypeScript/pull/53675/files#diff-cb9561c40fa7f1bbefdfa8fa029b8e3d8e07908806ddcb1518f2b69be43e45ceL884 is shows how we pass |
say |
It was meant to be nonRecursive and we treat as same but set was set incorrectly from start when added in #25811