Fix recursive type inference #53396

ahejlsberg · 2023-03-20T20:00:07Z

This PR reverts #49226 and instead fixes the problem as described here.

ahejlsberg · 2023-03-20T20:01:32Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-03-20T20:01:36Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at cd7165c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-20T20:01:36Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at cd7165c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-20T20:01:36Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at cd7165c. You can monitor the build here.

typescript-bot · 2023-03-20T20:01:36Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at cd7165c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-03-20T20:01:36Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at cd7165c. You can monitor the build here.

Update: The results are in!

jakebailey · 2023-03-20T20:03:12Z

tests/baselines/reference/recursiveConditionalTypes.types

@@ -249,7 +249,7 @@ declare let z: Box2<Box2<string>>;
 >z : Box2<Box2<string>>

 foo(z);  // unknown, but ideally would be string (requires unique recursion ID for each type reference)


Comment can probably be removed here now that this is saying string?

Yeah. Neat that we already had a test to show the issue.

typescript-bot · 2023-03-20T20:12:10Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53396/merge:

Everything looks good!

typescript-bot · 2023-03-20T21:41:42Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53396/merge:

Everything looks good!

MariaSolOs · 2023-03-20T21:56:58Z

Oh, could this also fix what I was working on in #53327?

typescript-bot · 2023-03-20T22:03:58Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

ahejlsberg · 2023-03-20T22:32:59Z

@MariaSolOs I doubt it, unfortunately.

ahejlsberg · 2023-03-21T01:11:20Z

Waiting on the performance suite, everything else looks good.

ahejlsberg · 2023-03-21T14:57:02Z

@typescript-bot perf test faster

typescript-bot · 2023-03-21T14:57:06Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 4ce18e0. You can monitor the build here.

Update: The results are in!

jakebailey · 2023-03-21T15:22:53Z

The original run is still queued; we just have a huge perf backlog and that's why it hasn't shown up yet.

typescript-bot · 2023-03-21T15:39:44Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53396

_Metric	_main	₅₃₃₉₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,038k (± 0.01%)}	_{361,427k (± 0.01%)}	_{+389k (+ 0.11%)}	_361,368k	_361,468k	_{p=0.005 n=6}
_{Parse Time}	_{3.52s (± 0.21%)}	_{3.55s (± 0.74%)}	_~	_3.51s	_3.58s	_{p=0.050 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.44%)}	_~	_1.18s	_1.19s	_{p=1.000 n=6}
_{Check Time}	_{9.50s (± 0.57%)}	_{9.54s (± 0.55%)}	_~	_9.49s	_9.62s	_{p=0.258 n=6}
_{Emit Time}	_{7.94s (± 0.62%)}	_{8.00s (± 0.85%)}	_~	_7.89s	_8.09s	_{p=0.227 n=6}
_{Total Time}	_{22.14s (± 0.30%)}	_{22.27s (± 0.27%)}	_{+0.13s (+ 0.56%)}	_22.19s	_22.34s	_{p=0.020 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,705k (± 0.89%)}	_{193,081k (± 0.68%)}	_~	_192,478k	_195,757k	_{p=0.230 n=6}
_{Parse Time}	_{1.58s (± 1.01%)}	_{1.60s (± 0.39%)}	_{+0.02s (+ 1.16%)}	_1.59s	_1.61s	_{p=0.009 n=6}
_{Bind Time}	_{0.82s (± 1.27%)}	_{0.83s (± 0.66%)}	_~	_0.82s	_0.83s	_{p=1.000 n=6}
_{Check Time}	_{10.11s (± 0.57%)}	_{10.16s (± 0.59%)}	_~	_10.11s	_10.28s	_{p=0.090 n=6}
_{Emit Time}	_{2.98s (± 0.55%)}	_{2.99s (± 0.74%)}	_~	_2.96s	_3.01s	_{p=0.255 n=6}
_{Total Time}	_{15.49s (± 0.35%)}	_{15.58s (± 0.47%)}	_~	_15.53s	_15.72s	_{p=0.050 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,561k (± 0.00%)}	_{345,564k (± 0.00%)}	_~	_345,539k	_345,580k	_{p=0.630 n=6}
_{Parse Time}	_{2.73s (± 0.55%)}	_{2.73s (± 0.68%)}	_~	_2.71s	_2.76s	_{p=0.459 n=6}
_{Bind Time}	_{1.09s (± 0.96%)}	_{1.09s (± 0.00%)}	_~	_1.09s	_1.09s	_{p=0.293 n=6}
_{Check Time}	_{7.73s (± 0.54%)}	_{7.70s (± 0.49%)}	_~	_7.66s	_7.76s	_{p=0.334 n=6}
_{Emit Time}	_{4.47s (± 0.28%)}	_{4.46s (± 0.59%)}	_~	_4.42s	_4.49s	_{p=0.743 n=6}
_{Total Time}	_{16.02s (± 0.36%)}	_{15.99s (± 0.16%)}	_~	_15.96s	_16.03s	_{p=0.686 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,817k (± 0.01%)}	_{299,808k (± 0.01%)}	_~	_299,752k	_299,861k	_{p=0.520 n=6}
_{Parse Time}	_{2.18s (± 0.95%)}	_{2.17s (± 0.54%)}	_~	_2.15s	_2.18s	_{p=0.286 n=6}
_{Bind Time}	_{1.24s (± 1.10%)}	_{1.24s (± 0.88%)}	_~	_1.22s	_1.25s	_{p=0.611 n=6}
_{Check Time}	_{7.18s (± 0.38%)}	_{7.21s (± 0.47%)}	_~	_7.15s	_7.25s	_{p=0.124 n=6}
_{Emit Time}	_{4.34s (± 0.86%)}	_{4.33s (± 0.86%)}	_~	_4.29s	_4.38s	_{p=0.520 n=6}
_{Total Time}	_{14.95s (± 0.51%)}	_{14.94s (± 0.35%)}	_~	_14.89s	_15.04s	_{p=1.000 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,401k (± 0.00%)}	_{476,437k (± 0.00%)}	_{+36k (+ 0.01%)}	_476,417k	_476,451k	_{p=0.020 n=6}
_{Parse Time}	_{3.21s (± 0.42%)}	_{3.22s (± 0.23%)}	_~	_3.21s	_3.23s	_{p=0.111 n=6}
_{Bind Time}	_{0.96s (± 0.54%)}	_{0.96s (± 0.54%)}	_~	_0.95s	_0.96s	_{p=1.000 n=6}
_{Check Time}	_{18.01s (± 0.70%)}	_{18.15s (± 0.38%)}	_{+0.14s (+ 0.80%)}	_18.07s	_18.28s	_{p=0.045 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.18s (± 0.65%)}	_{22.34s (± 0.31%)}	_{+0.16s (+ 0.70%)}	_22.25s	_22.46s	_{p=0.045 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,557k (± 0.02%)}	_{550,546k (± 0.01%)}	_~	_550,507k	_550,671k	_{p=0.810 n=6}
_{Parse Time}	_{3.95s (± 0.46%)}	_{3.95s (± 0.36%)}	_~	_3.93s	_3.97s	_{p=0.743 n=6}
_{Bind Time}	_{1.80s (± 0.45%)}	_{1.80s (± 0.35%)}	_~	_1.79s	_1.81s	_{p=0.432 n=6}
_{Check Time}	_{2.99s (± 0.82%)}	_{3.03s (± 0.87%)}	_~	_3.00s	_3.07s	_{p=0.053 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.83s (± 0.35%)}	_{8.87s (± 0.39%)}	_~	_8.84s	_8.92s	_{p=0.089 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₉₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-03-21T17:47:09Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53396

_Metric	_main	₅₃₃₉₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{361,392k (± 0.01%)}	_{361,054k (± 0.01%)}	_{-338k (- 0.09%)}	_361,003k	_361,093k	_{p=0.005 n=6}
_{Parse Time}	_{3.54s (± 0.60%)}	_{3.53s (± 0.95%)}	_~	_3.48s	_3.58s	_{p=0.624 n=6}
_{Bind Time}	_{1.18s (± 0.71%)}	_{1.18s (± 0.83%)}	_~	_1.17s	_1.19s	_{p=0.734 n=6}
_{Check Time}	_{9.49s (± 0.44%)}	_{9.46s (± 0.24%)}	_~	_9.42s	_9.49s	_{p=0.462 n=6}
_{Emit Time}	_{7.92s (± 0.37%)}	_{7.92s (± 0.59%)}	_~	_7.85s	_7.99s	_{p=0.872 n=6}
_{Total Time}	_{22.13s (± 0.22%)}	_{22.10s (± 0.23%)}	_~	_22.00s	_22.15s	_{p=0.333 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,532k (± 0.03%)}	_{192,621k (± 0.02%)}	_{+90k (+ 0.05%)}	_192,537k	_192,677k	_{p=0.045 n=6}
_{Parse Time}	_{1.60s (± 0.85%)}	_{1.59s (± 1.82%)}	_~	_1.54s	_1.61s	_{p=0.676 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.82s (± 0.50%)}	_{-0.01s (- 1.01%)}	_0.81s	_0.82s	_{p=0.022 n=6}
_{Check Time}	_{10.18s (± 0.45%)}	_{10.13s (± 0.41%)}	_~	_10.09s	_10.18s	_{p=0.145 n=6}
_{Emit Time}	_{2.99s (± 1.21%)}	_{2.98s (± 0.72%)}	_~	_2.96s	_3.02s	_{p=0.629 n=6}
_{Total Time}	_{15.60s (± 0.30%)}	_{15.51s (± 0.44%)}	_~	_15.45s	_15.62s	_{p=0.053 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,562k (± 0.01%)}	_{345,536k (± 0.01%)}	_~	_345,495k	_345,557k	_{p=0.066 n=6}
_{Parse Time}	_{2.73s (± 0.50%)}	_{2.73s (± 0.60%)}	_~	_2.71s	_2.76s	_{p=0.325 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.90%)}	_~	_1.08s	_1.11s	_{p=0.386 n=6}
_{Check Time}	_{7.76s (± 0.52%)}	_{7.70s (± 0.20%)}	_{-0.06s (- 0.73%)}	_7.68s	_7.72s	_{p=0.024 n=6}
_{Emit Time}	_{4.48s (± 0.58%)}	_{4.45s (± 0.65%)}	_~	_4.41s	_4.48s	_{p=0.076 n=6}
_{Total Time}	_{16.06s (± 0.35%)}	_{15.97s (± 0.21%)}	_{-0.08s (- 0.52%)}	_15.93s	_16.01s	_{p=0.013 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,778k (± 0.01%)}	_{299,810k (± 0.01%)}	_{+33k (+ 0.01%)}	_299,779k	_299,839k	_{p=0.045 n=6}
_{Parse Time}	_{2.17s (± 0.86%)}	_{2.17s (± 0.41%)}	_~	_2.16s	_2.18s	_{p=0.683 n=6}
_{Bind Time}	_{1.23s (± 1.03%)}	_{1.24s (± 0.94%)}	_~	_1.22s	_1.25s	_{p=0.155 n=6}
_{Check Time}	_{7.20s (± 0.39%)}	_{7.21s (± 1.49%)}	_~	_7.14s	_7.43s	_{p=0.518 n=6}
_{Emit Time}	_{4.34s (± 0.50%)}	_{4.38s (± 3.32%)}	_~	_4.29s	_4.67s	_{p=0.466 n=6}
_{Total Time}	_{14.93s (± 0.32%)}	_{15.01s (± 1.77%)}	_~	_14.84s	_15.54s	_{p=0.687 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,489k (± 0.02%)}	_{476,427k (± 0.00%)}	_~	_476,402k	_476,464k	_{p=0.575 n=6}
_{Parse Time}	_{3.22s (± 1.21%)}	_{3.21s (± 0.33%)}	_~	_3.20s	_3.23s	_{p=0.324 n=6}
_{Bind Time}	_{0.98s (± 3.78%)}	_{0.95s (± 0.43%)}	_{🟩-0.03s (- 3.06%)}	_0.95s	_0.96s	_{p=0.007 n=6}
_{Check Time}	_{18.00s (± 1.06%)}	_{18.13s (± 0.32%)}	_~	_18.04s	_18.20s	_{p=0.378 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.20s (± 1.03%)}	_{22.30s (± 0.26%)}	_~	_22.22s	_22.36s	_{p=0.575 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{550,558k (± 0.01%)}	_{550,611k (± 0.02%)}	_~	_550,474k	_550,752k	_{p=0.378 n=6}
_{Parse Time}	_{3.95s (± 0.34%)}	_{3.95s (± 0.21%)}	_~	_3.94s	_3.96s	_{p=0.805 n=6}
_{Bind Time}	_{1.79s (± 0.47%)}	_{1.80s (± 0.30%)}	_~	_1.79s	_1.80s	_{p=0.855 n=6}
_{Check Time}	_{2.99s (± 0.47%)}	_{3.01s (± 0.53%)}	_{+0.02s (+ 0.72%)}	_3.00s	_3.04s	_{p=0.041 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.83s (± 0.34%)}	_{8.85s (± 0.20%)}	_~	_8.83s	_8.88s	_{p=0.195 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₉₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

ahejlsberg added 5 commits March 20, 2023 12:42

Use isDeeplyNestedType in type inference logic

42d2158

Merge branch 'main' into fixRecursiveTypeInference

512eb96

Revert #49226

e5d35af

Accept new baselines

a923424

Add repro from comment in #49226

cd7165c

typescript-bot assigned ahejlsberg Mar 20, 2023

typescript-bot added Author: Team For Backlog Bug PRs that fix a backlog bug labels Mar 20, 2023

ahejlsberg requested review from DanielRosenwasser, RyanCavanaugh and weswigham March 20, 2023 20:01

jakebailey reviewed Mar 20, 2023

View reviewed changes

weswigham approved these changes Mar 20, 2023

View reviewed changes

Update test

4ce18e0

ahejlsberg merged commit 3d2c344 into main Mar 21, 2023

ahejlsberg deleted the fixRecursiveTypeInference branch March 21, 2023 19:53

RyanCavanaugh mentioned this pull request Oct 13, 2023

Unrelated interface causes assignability to change #56099

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix recursive type inference #53396

Fix recursive type inference #53396

ahejlsberg commented Mar 20, 2023 •

edited

Loading

ahejlsberg commented Mar 20, 2023

typescript-bot commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 20, 2023 •

edited

Loading

jakebailey Mar 20, 2023

ahejlsberg Mar 20, 2023

typescript-bot commented Mar 20, 2023

typescript-bot commented Mar 20, 2023

MariaSolOs commented Mar 20, 2023

typescript-bot commented Mar 20, 2023

ahejlsberg commented Mar 20, 2023

ahejlsberg commented Mar 21, 2023

ahejlsberg commented Mar 21, 2023

typescript-bot commented Mar 21, 2023 •

edited

Loading

jakebailey commented Mar 21, 2023

typescript-bot commented Mar 21, 2023

typescript-bot commented Mar 21, 2023

		@@ -249,7 +249,7 @@ declare let z: Box2<Box2<string>>;
		>z : Box2<Box2<string>>

		foo(z); // unknown, but ideally would be string (requires unique recursion ID for each type reference)

Fix recursive type inference #53396

Fix recursive type inference #53396

Conversation

ahejlsberg commented Mar 20, 2023 • edited Loading

ahejlsberg commented Mar 20, 2023

typescript-bot commented Mar 20, 2023 • edited Loading

typescript-bot commented Mar 20, 2023 • edited Loading

typescript-bot commented Mar 20, 2023 • edited Loading

typescript-bot commented Mar 20, 2023 • edited Loading

typescript-bot commented Mar 20, 2023 • edited Loading

jakebailey Mar 20, 2023

Choose a reason for hiding this comment

ahejlsberg Mar 20, 2023

Choose a reason for hiding this comment

typescript-bot commented Mar 20, 2023

typescript-bot commented Mar 20, 2023

MariaSolOs commented Mar 20, 2023

typescript-bot commented Mar 20, 2023

ahejlsberg commented Mar 20, 2023

ahejlsberg commented Mar 21, 2023

ahejlsberg commented Mar 21, 2023

typescript-bot commented Mar 21, 2023 • edited Loading

jakebailey commented Mar 21, 2023

typescript-bot commented Mar 21, 2023

typescript-bot commented Mar 21, 2023

ahejlsberg commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 20, 2023 •

edited

Loading

typescript-bot commented Mar 21, 2023 •

edited

Loading