Fix RWC tests with errors in tsconfig #52824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot test this |
|
Heya @jakebailey, I've started to run the extended test suite on this PR at e7b72db. You can monitor the build here. |
|
The above passes, but now exposes the fact that RWC (unlike our other tests) doesn't reply with "everything looks good" or something. The only reason it's been replying with "here's a diff" is because it fails due to this assert and then sends an empty baseline change as a PR. |
sheetalkamat
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RWC tests currently fail because one of the tests includes tsconfig in the input file set, so the harness double-reports errors. This is brand new after our new deprecations, but we didn't seem to notice as the RWC tests were still reporting baseline differences.
This sort of thing appears to already be worked around for
lib.d.tsfiles, so, do something similar to tsconfig to get RWC passing again.