Exclude literal completions after closing quote and JSX attribute location

[zardoy]

Fixes #51667
Fixes #52675

contextualType is derived from previous token

[zardoy]

didn't use exact: [a], because b gets included in position 3

[zardoy]

Basically it always disallow literal completions in string and identifier locations. I wonder wether it can break any edge cases I don't know about?

[DanielRosenwasser]

You could instead use isInStringOrRegularExpressionOrTemplateLiteral which will tell you if you're inside of the node (even if that node is unterminated).

TypeScript/src/services/completions.ts

Line 3694 in 1c822c4

function isInStringOrRegularExpressionOrTemplateLiteral(contextToken: Node): boolean {

[zardoy]

@DanielRosenwasser so as I understand your proposal is to replace isStringLiteralLike with isInStringOrRegularExpressionOrTemplateLiteral, but whats the difference? Am I missing something?

[DanielRosenwasser]

If I understand correctly, the second one checks if the position is inside of the string, whereas the original just checks if the previous token is a string or template string. You might still want to keep isStringLiteralLike, but you want to check if the cursor is actually inside of the string.

[zardoy]

but you want to check if the cursor is actually inside of the string

But do I need this check? What issue it covers? I'm pretty sure there is already check if I'm inside of the string

TypeScript/src/services/stringCompletions.ts

Lines 198 to 200 in d0938c8

	if (isInString(sourceFile, position, contextToken)) {
	if (!contextToken || !isStringLiteralLike(contextToken)) return undefined;
	const entries = getStringLiteralCompletionEntries(sourceFile, contextToken, position, program.getTypeChecker(), options, host, preferences);

If I understand correctly, the second one checks if the position is inside of the string, whereas the original just checks if the previous token is a string or template string

I have two checks for two issues correspondly, first one checks if the previous token is a string and second checks if jsx attribute identifier expected (see added tests). In the second check token is not necessarily is string: playground.

[DanielRosenwasser]

I think I see - it sounds like the idea that the previous token the the one immediately to the left of the original context token, so we could not have been inside of the string. Is that right?

[andrewbranch]

previousToken is either the token you’re currently typing or one behind, if you closed out a token but haven’t started typing a new one yet:

"hello|  // previousToken = String Literal
"hello"| // previousToken = String Literal

but, when the cursor is inside the string, a different code path would have already handled that and returned results from stringCompletions.ts. So in this case, we know we’re not inside the string. (Confusingly, stringCompletions.ts doesn’t handle completions of entire string literals including the quotes; it only handles completions inside existing string literals.)

[zardoy]

Wow this is really great explanation of first check. Thank you so much, I wish I could write same explanations in first place 😄

[sandersn]

@andrewbranch is this ready to merge now that 5.1 development has started?