Ensure we treat "type assertions" as JSX within a unary expression #52667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
|
I seem to recall a change was made a year or so ago to deliberately not parse legacy type assertions in JS in order to resolve ambiguity with expressions like |
|
Unfortunately, I can’t seem to find the issue/PR for that now. I did find several comments— including one from Ryan—suggesting JSX is always parsed in |
|
My impression was that we conditionalized a lot of the parser on the file extension, including JSX stuff. But that's still a good point, and I need to go figure out if this production should even be parsed. |
|
So yep, you're right; we do generally treat JS as JSX. Going though this, though, here's what's happening; given: const foo = <number> barHere, we see that there's a But, if we instead stick a unary operator at the front, like: const foo = +<number> barWe see that it's not an update expression, so we parse a "simple" unary expression, but as the parser currently operates, a simple unary expression only ever parses more simple unary expressions afterwards, i.e. I'm pretty sure that we need to be parsing JSX here as you've said, so, thanks for the catch. That's what esbuild does too (try changing the extension around between ts/js/tsx/jsx, and I think that's correct. |
jakebailey
changed the title
|
@typescript-bot test this |
|
Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at f027812. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at f027812. You can monitor the build here. |
|
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at f027812. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the extended test suite on this PR at f027812. You can monitor the build here. |
|
Heya @jakebailey, I've started to run the tarball bundle task on this PR at f027812. You can monitor the build here. |
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at f027812. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the perf test suite on this PR at f027812. You can monitor the build here. Update: The results are in! |
|
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
|
@jakebailey Here are the results of running the user test suite comparing Something interesting changed - please have a look. Detailsnpm
|
|
Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
|
@jakebailey Here they are:
CompilerComparison Report - main..52667
System
Hosts
Scenarios
TSServerComparison Report - main..52667
System
Hosts
Scenarios
StartupComparison Report - main..52667
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
|
@jakebailey Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailsakveo/ngx-admin
|
|
@jakebailey Here are some more interesting changes from running the top-repos suite Detailsbackstage/backstage
|
|
@jakebailey Here are some more interesting changes from running the top-repos suite Detailsfelixrieseberg/windows95
|
|
@jakebailey Here are some more interesting changes from running the top-repos suite Detailsmicrosoft/vscode
|
|
@jakebailey Here are some more interesting changes from running the top-repos suite Detailspalantir/blueprint
|
|
@jakebailey Here are some more interesting changes from running the top-repos suite DetailsReactiveX/rxjs
|
|
@jakebailey Here are some more interesting changes from running the top-repos suite Detailstypeorm/typeorm
|
DanielRosenwasser
approved these changes
Feb 9, 2023
jakebailey
commented
Feb 9, 2023
andrewbranch
approved these changes
Feb 9, 2023
This was referenced Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50675
The comment claims we won't parse these in JS files, but that's not true; we can pretty easily parse them just like we doasand should error on them just like we doas.See: #52667 (comment)