Skip to content

Don't consult JSDoc outside of JS in expando function assignment declarations #52640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2023
Merged

Don't consult JSDoc outside of JS in expando function assignment declarations #52640

merged 3 commits into from
Feb 6, 2023

Conversation

jakebailey
Copy link
Member

After #52610 I was curious to look for more cases like these; I added an assert to getJSDocTagsWorker that failed whenever it was used on a non-JS file, which had loads of false positives (@deprecated, @param mismatch suggestions, services, etc).

But it did find one bug where we were using JSDoc info when outside of a JS file.

@jakebailey jakebailey requested a review from sandersn February 6, 2023 20:58
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 6, 2023
@jakebailey
Copy link
Member Author

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 26c71ad. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 26c71ad. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 26c71ad. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 26c71ad. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 26c71ad. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 26c71ad. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at 26c71ad. You can monitor the build here.

@jakebailey jakebailey mentioned this pull request Feb 6, 2023
Closed
@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52640/merge:

Everything looks good!

1 similar comment
@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52640/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52640/merge:

Something interesting changed - please have a look.

Details

backstage/backstage

⚠️ Note that built also had errors ⚠️ 
Exited unexpectedly with signal SIGABRT


Server exited prematurely with code unknown and signal SIGABRT

That is a filtered view of the text. To see the raw error text, go to RepoResults4/backstage.backstage.rawError.txt in the artifact folder

Last few requests

 
{"seq":4837,"type":"request","command":"organizeImports","arguments":{"scope":{"type":"file","args":{"file":"@PROJECT_ROOT@/plugins/bitrise/src/components/BitriseBuildsTableComponent/index.ts"}},"skipDestructiveCodeActions":true}}
{"seq":4838,"type":"request","command":"getOutliningSpans","arguments":{"file":"@PROJECT_ROOT@/plugins/bitrise/src/components/BitriseBuildsTableComponent/index.ts"}}
{"seq":4839,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/plugins/bitbucket-cloud-common/scripts/prepare-schema.js"],"openFiles":[]}}
{"seq":4840,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/plugins/catalog-backend-module-aws/config.d.ts","projectRootPath":"@PROJECT_ROOT@"}]}}

Repro Steps
  1. git clone https://github.com/backstage/backstage --recurse-submodules
  2. In dir backstage, run git reset --hard 145a788ffbe092944b306cf8394caa8e45527efe
  3. Install packages (exact steps are below, but it might be easier to follow the repo readme)
    1. In dir backstage/cypress, run yarn install --no-immutable --mode=skip-build
    2. In dir backstage/microsite-next, run yarn install --no-immutable --mode=skip-build
    3. In dir backstage/microsite, run yarn install --no-immutable --mode=skip-build
    4. In dir backstage, run yarn install --no-immutable --mode=skip-build
    5. In dir backstage/storybook, run yarn install --no-immutable --mode=skip-build
  4. Back in the initial folder, download RepoResults4/backstage.backstage.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./backstage ./backstage.backstage.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

palantir/blueprint

⚠️ Note that built also had errors ⚠️ 
Req #18582 - references
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72250:41)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-main/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-main/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-main/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-main/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-main/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-main/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-main/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-main/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-main/built/local/tsserver.js:72172:29)

Req #18582 - references
    at checkPropertyAccessExpression (/typescript-52640/built/local/tsserver.js:72250:41)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-52640/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-52640/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-52640/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-52640/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-52640/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-52640/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-52640/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-52640/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-52640/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-52640/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-52640/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-52640/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-52640/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-52640/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-52640/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-52640/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-52640/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-52640/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-52640/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-52640/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-52640/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-52640/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-52640/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-52640/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-52640/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-52640/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-52640/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-52640/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-52640/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-52640/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-52640/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-52640/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-52640/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-52640/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-52640/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-52640/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-52640/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-52640/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-52640/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-52640/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-52640/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-52640/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at getEffectsSignature (/typescript-52640/built/local/tsserver.js:68253:22)
    at getTypeAtFlowCall (/typescript-52640/built/local/tsserver.js:68592:25)
    at getTypeAtFlowNode (/typescript-52640/built/local/tsserver.js:68478:18)
    at getFlowTypeOfReference (/typescript-52640/built/local/tsserver.js:68435:45)
    at checkIdentifier (/typescript-52640/built/local/tsserver.js:69679:22)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77740:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)
    at checkPropertyAccessExpression (/typescript-52640/built/local/tsserver.js:72251:162)
    at checkExpressionWorker (/typescript-52640/built/local/tsserver.js:77774:16)
    at checkExpression (/typescript-52640/built/local/tsserver.js:77694:32)
    at checkNonNullExpression (/typescript-52640/built/local/tsserver.js:72172:29)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in the artifact folder

Last few requests

 
{"seq":18579,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":32841,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":18580,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":32841,"entryNames":["_"]}}
{"seq":18581,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":34643}}
{"seq":18582,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/2/docs-app.js","line":1,"offset":36259}}

Repro Steps
  1. git clone https://github.com/palantir/blueprint --recurse-submodules
  2. In dir blueprint, run git reset --hard 3554e8a5fc8acdf1e43e2e91942350309f02dee8
  3. Back in the initial folder, download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
  4. npm install --no-save @typescript/server-replay
  5. npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
  6. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52640/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52640
Metric main 52640 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,853k (± 0.03%) 359,858k (± 0.02%) ~ 359,780k 359,926k p=1.000 n=6
Parse Time 3.95s (± 0.57%) 3.99s (± 0.56%) +0.04s (+ 1.01%) 3.97s 4.03s p=0.008 n=6
Bind Time 1.18s (± 0.83%) 1.18s (± 0.64%) ~ 1.17s 1.19s p=0.858 n=6
Check Time 8.69s (± 0.49%) 8.73s (± 0.45%) ~ 8.68s 8.78s p=0.199 n=6
Emit Time 7.59s (± 0.41%) 7.63s (± 0.67%) ~ 7.57s 7.70s p=0.296 n=6
Total Time 21.42s (± 0.20%) 21.53s (± 0.42%) +0.11s (+ 0.51%) 21.45s 21.70s p=0.020 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 195,081k (± 1.65%) 194,127k (± 1.55%) ~ 191,865k 198,152k p=0.810 n=6
Parse Time 1.63s (± 1.45%) 1.65s (± 1.57%) ~ 1.60s 1.67s p=0.214 n=6
Bind Time 0.80s (± 0.51%) 0.79s (± 0.52%) -0.01s (- 0.84%) 0.79s 0.80s p=0.034 n=6
Check Time 9.79s (± 0.71%) 9.75s (± 0.92%) ~ 9.69s 9.93s p=0.198 n=6
Emit Time 2.85s (± 4.06%) 2.86s (± 3.56%) ~ 2.79s 3.06s p=0.808 n=6
Total Time 15.06s (± 0.82%) 15.05s (± 0.80%) ~ 14.96s 15.25s p=0.627 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,984k (± 0.01%) 344,036k (± 0.01%) +52k (+ 0.01%) 344,003k 344,055k p=0.020 n=6
Parse Time 2.96s (± 0.90%) 2.94s (± 0.41%) ~ 2.92s 2.95s p=0.146 n=6
Bind Time 1.04s (± 1.17%) 1.04s (± 1.32%) ~ 1.02s 1.05s p=1.000 n=6
Check Time 7.05s (± 0.44%) 7.07s (± 0.50%) ~ 7.03s 7.12s p=0.570 n=6
Emit Time 4.33s (± 0.92%) 4.33s (± 0.92%) ~ 4.28s 4.38s p=1.000 n=6
Total Time 15.37s (± 0.57%) 15.38s (± 0.44%) ~ 15.28s 15.45s p=1.000 n=6
TFS - node (v18.10.0, x64)
Memory used 300,398k (± 0.01%) 300,414k (± 0.01%) ~ 300,390k 300,432k p=0.261 n=6
Parse Time 2.26s (± 1.18%) 2.27s (± 1.78%) ~ 2.22s 2.33s p=1.000 n=6
Bind Time 1.17s (± 0.64%) 1.18s (± 0.71%) ~ 1.17s 1.19s p=0.652 n=6
Check Time 6.56s (± 0.43%) 6.55s (± 0.42%) ~ 6.52s 6.59s p=0.871 n=6
Emit Time 3.92s (± 0.78%) 3.94s (± 1.41%) ~ 3.87s 4.04s p=0.518 n=6
Total Time 13.91s (± 0.25%) 13.94s (± 0.50%) ~ 13.82s 14.02s p=0.170 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,851k (± 0.01%) 476,870k (± 0.00%) ~ 476,848k 476,885k p=0.229 n=6
Parse Time 3.55s (± 0.61%) 3.55s (± 0.69%) ~ 3.51s 3.58s p=0.871 n=6
Bind Time 0.97s (± 0.42%) 0.97s (± 0.56%) ~ 0.97s 0.98s p=0.282 n=6
Check Time 17.19s (± 0.35%) 17.21s (± 0.99%) ~ 17.03s 17.54s p=0.628 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.72s (± 0.30%) 21.74s (± 0.72%) ~ 21.55s 22.03s p=1.000 n=6
xstate - node (v18.10.0, x64)
Memory used 549,040k (± 0.02%) 549,024k (± 0.01%) ~ 548,983k 549,125k p=0.689 n=6
Parse Time 4.54s (± 0.43%) 4.58s (± 0.79%) ~ 4.52s 4.62s p=0.167 n=6
Bind Time 1.73s (± 0.79%) 1.71s (± 0.61%) ~ 1.70s 1.73s p=0.160 n=6
Check Time 2.81s (± 0.54%) 2.83s (± 0.69%) ~ 2.82s 2.87s p=0.096 n=6
Emit Time 0.08s (± 4.99%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=0.405 n=6
Total Time 9.18s (± 0.09%) 9.21s (± 0.28%) +0.04s (+ 0.40%) 9.17s 9.24s p=0.033 n=6
Angular - node (v16.17.1, x64)
Memory used 359,200k (± 0.00%) 359,223k (± 0.01%) ~ 359,195k 359,264k p=0.066 n=6
Parse Time 4.19s (± 0.23%) 4.18s (± 0.35%) ~ 4.16s 4.20s p=0.117 n=6
Bind Time 1.22s (± 0.68%) 1.22s (± 0.68%) ~ 1.22s 1.24s p=1.000 n=6
Check Time 9.46s (± 0.29%) 9.47s (± 0.45%) ~ 9.42s 9.54s p=0.686 n=6
Emit Time 8.06s (± 0.26%) 8.07s (± 0.79%) ~ 8.00s 8.17s p=0.573 n=6
Total Time 22.93s (± 0.15%) 22.94s (± 0.27%) ~ 22.85s 23.01s p=0.468 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,982k (± 0.84%) 193,923k (± 0.03%) ~ 193,849k 194,015k p=0.298 n=6
Parse Time 1.80s (± 0.74%) 1.81s (± 0.35%) ~ 1.80s 1.82s p=0.128 n=6
Bind Time 0.85s (± 0.61%) 0.85s (± 0.48%) ~ 0.84s 0.85s p=0.595 n=6
Check Time 10.47s (± 0.54%) 10.43s (± 0.42%) ~ 10.37s 10.48s p=0.126 n=6
Emit Time 3.09s (± 1.42%) 3.07s (± 0.66%) ~ 3.06s 3.11s p=0.677 n=6
Total Time 16.20s (± 0.44%) 16.16s (± 0.18%) ~ 16.11s 16.19s p=0.517 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,278k (± 0.01%) 343,275k (± 0.01%) ~ 343,233k 343,319k p=0.810 n=6
Parse Time 3.18s (± 1.63%) 3.18s (± 1.17%) ~ 3.13s 3.23s p=1.000 n=6
Bind Time 1.11s (± 1.33%) 1.11s (± 0.46%) ~ 1.11s 1.12s p=0.784 n=6
Check Time 7.71s (± 0.25%) 7.71s (± 0.21%) ~ 7.69s 7.73s p=0.868 n=6
Emit Time 4.50s (± 0.54%) 4.55s (± 0.47%) +0.04s (+ 0.92%) 4.52s 4.58s p=0.020 n=6
Total Time 16.50s (± 0.54%) 16.55s (± 0.39%) ~ 16.45s 16.64s p=0.333 n=6
TFS - node (v16.17.1, x64)
Memory used 299,761k (± 0.01%) 299,765k (± 0.00%) ~ 299,761k 299,770k p=0.810 n=6
Parse Time 2.45s (± 0.92%) 2.46s (± 0.76%) ~ 2.44s 2.48s p=0.681 n=6
Bind Time 1.26s (± 0.50%) 1.25s (± 0.60%) ~ 1.24s 1.26s p=0.081 n=6
Check Time 7.20s (± 0.30%) 7.22s (± 0.45%) ~ 7.17s 7.26s p=0.171 n=6
Emit Time 4.22s (± 0.55%) 4.23s (± 0.81%) ~ 4.19s 4.29s p=0.686 n=6
Total Time 15.13s (± 0.20%) 15.17s (± 0.21%) ~ 15.12s 15.21s p=0.065 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,101k (± 0.00%) 476,105k (± 0.00%) ~ 476,075k 476,133k p=0.748 n=6
Parse Time 3.72s (± 0.29%) 3.72s (± 0.20%) ~ 3.71s 3.73s p=0.604 n=6
Bind Time 1.02s (± 0.40%) 1.02s (± 0.62%) ~ 1.01s 1.03s p=0.673 n=6
Check Time 18.10s (± 0.27%) 18.16s (± 0.25%) ~ 18.10s 18.22s p=0.078 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.85s (± 0.22%) 22.90s (± 0.18%) ~ 22.85s 22.96s p=0.076 n=6
xstate - node (v16.17.1, x64)
Memory used 546,787k (± 0.03%) 546,725k (± 0.02%) ~ 546,588k 546,888k p=0.471 n=6
Parse Time 4.79s (± 0.84%) 4.77s (± 0.60%) ~ 4.74s 4.81s p=0.226 n=6
Bind Time 1.79s (± 4.66%) 1.84s (± 0.34%) ~ 1.83s 1.85s p=0.209 n=6
Check Time 3.13s (± 3.54%) 3.06s (± 0.60%) ~ 3.04s 3.09s p=0.376 n=6
Emit Time 0.09s (± 4.45%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=0.405 n=6
Total Time 9.80s (± 0.70%) 9.76s (± 0.38%) ~ 9.72s 9.81s p=0.520 n=6
Angular - node (v14.15.1, x64)
Memory used 352,848k (± 0.00%) 352,867k (± 0.00%) ~ 352,840k 352,886k p=0.109 n=6
Parse Time 4.24s (± 0.49%) 4.25s (± 0.36%) ~ 4.22s 4.26s p=0.682 n=6
Bind Time 1.28s (± 0.00%) 1.29s (± 0.63%) ~ 1.28s 1.30s p=0.073 n=6
Check Time 9.74s (± 0.67%) 9.75s (± 0.40%) ~ 9.70s 9.80s p=0.936 n=6
Emit Time 8.37s (± 0.37%) 8.36s (± 0.31%) ~ 8.34s 8.41s p=0.808 n=6
Total Time 23.63s (± 0.39%) 23.65s (± 0.10%) ~ 23.62s 23.68s p=0.936 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 188,811k (± 0.02%) 188,847k (± 0.04%) ~ 188,769k 189,002k p=0.575 n=6
Parse Time 1.85s (± 0.95%) 1.84s (± 0.63%) ~ 1.83s 1.86s p=0.737 n=6
Bind Time 0.86s (± 0.94%) 0.86s (± 0.60%) ~ 0.86s 0.87s p=0.752 n=6
Check Time 10.54s (± 0.30%) 10.56s (± 0.28%) ~ 10.50s 10.58s p=0.369 n=6
Emit Time 3.49s (± 0.91%) 3.44s (± 4.83%) ~ 3.11s 3.58s p=0.936 n=6
Total Time 16.74s (± 0.30%) 16.71s (± 0.96%) ~ 16.38s 16.81s p=0.810 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,019k (± 0.00%) 338,032k (± 0.00%) ~ 338,006k 338,055k p=0.261 n=6
Parse Time 3.22s (± 0.65%) 3.25s (± 1.59%) ~ 3.20s 3.32s p=0.331 n=6
Bind Time 1.11s (± 0.73%) 1.11s (± 0.00%) ~ 1.11s 1.11s p=0.290 n=6
Check Time 8.03s (± 0.37%) 8.10s (± 0.67%) ~ 8.02s 8.17s p=0.061 n=6
Emit Time 4.77s (± 0.45%) 4.78s (± 0.68%) ~ 4.73s 4.82s p=0.747 n=6
Total Time 17.14s (± 0.15%) 17.24s (± 0.23%) +0.11s (+ 0.62%) 17.18s 17.29s p=0.005 n=6
TFS - node (v14.15.1, x64)
Memory used 294,570k (± 0.00%) 294,586k (± 0.01%) ~ 294,567k 294,617k p=0.149 n=6
Parse Time 2.74s (± 1.12%) 2.74s (± 0.30%) ~ 2.73s 2.75s p=0.513 n=6
Bind Time 1.11s (± 0.99%) 1.11s (± 0.68%) ~ 1.10s 1.12s p=0.604 n=6
Check Time 7.49s (± 0.62%) 7.53s (± 0.34%) ~ 7.49s 7.56s p=0.092 n=6
Emit Time 4.64s (± 0.46%) 4.61s (± 0.56%) ~ 4.59s 4.65s p=0.091 n=6
Total Time 15.99s (± 0.37%) 16.00s (± 0.34%) ~ 15.93s 16.07s p=1.000 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,642k (± 0.01%) 471,637k (± 0.01%) ~ 471,615k 471,686k p=1.000 n=6
Parse Time 3.95s (± 0.47%) 3.93s (± 0.68%) ~ 3.89s 3.97s p=0.169 n=6
Bind Time 1.04s (± 0.50%) 1.03s (± 0.50%) ~ 1.03s 1.04s p=0.311 n=6
Check Time 19.08s (± 0.24%) 19.11s (± 0.35%) ~ 19.02s 19.20s p=0.519 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 24.06s (± 0.21%) 24.07s (± 0.32%) ~ 23.98s 24.16s p=0.936 n=6
xstate - node (v14.15.1, x64)
Memory used 534,867k (± 0.01%) 534,872k (± 0.01%) ~ 534,788k 534,934k p=0.575 n=6
Parse Time 5.15s (± 0.67%) 5.16s (± 0.83%) ~ 5.11s 5.21s p=0.574 n=6
Bind Time 1.72s (± 0.60%) 1.72s (± 0.80%) ~ 1.70s 1.74s p=0.867 n=6
Check Time 3.14s (± 0.44%) 3.15s (± 0.44%) +0.02s (+ 0.58%) 3.13s 3.17s p=0.048 n=6
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) ~ 0.10s 0.10s p=1.000 n=6
Total Time 10.10s (± 0.47%) 10.13s (± 0.51%) ~ 10.07s 10.18s p=0.418 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52640 6
Baseline main 6

TSServer

Comparison Report - main..52640
Metric main 52640 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,535ms (± 1.08%) 2,501ms (± 1.50%) ~ 2,468ms 2,565ms p=0.065 n=6
Req 2 - geterr 5,528ms (± 0.68%) 5,530ms (± 0.64%) ~ 5,500ms 5,599ms p=0.936 n=6
Req 3 - references 370ms (± 1.12%) 368ms (± 1.04%) ~ 361ms 371ms p=0.420 n=6
Req 4 - navto 285ms (± 0.90%) 283ms (± 0.43%) ~ 282ms 285ms p=0.121 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 72ms (± 1.96%) 71ms (± 1.70%) ~ 70ms 73ms p=0.458 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,734ms (± 1.45%) 2,739ms (± 2.14%) ~ 2,697ms 2,850ms p=0.936 n=6
Req 2 - geterr 4,058ms (± 0.45%) 4,054ms (± 0.49%) ~ 4,037ms 4,091ms p=0.810 n=6
Req 3 - references 369ms (± 0.68%) 366ms (± 0.95%) ~ 362ms 369ms p=0.141 n=6
Req 4 - navto 294ms (± 0.98%) 294ms (± 0.41%) ~ 292ms 295ms p=0.568 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 67ms (± 1.33%) 67ms (± 0.61%) ~ 66ms 67ms p=0.787 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,497ms (± 0.37%) 3,480ms (± 0.67%) ~ 3,439ms 3,501ms p=0.423 n=6
Req 2 - geterr 1,655ms (± 0.72%) 1,655ms (± 1.17%) ~ 1,630ms 1,684ms p=0.936 n=6
Req 3 - references 104ms (± 2.33%) 104ms (± 2.17%) ~ 101ms 106ms p=0.934 n=6
Req 4 - navto 359ms (± 1.23%) 357ms (± 1.27%) ~ 353ms 365ms p=0.630 n=6
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) ~ 3,175 3,175 p=1.000 n=6
Req 5 - completionInfo 451ms (± 0.76%) 451ms (± 0.51%) ~ 449ms 454ms p=1.000 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,773ms (± 1.22%) 2,783ms (± 0.52%) ~ 2,766ms 2,804ms p=1.000 n=6
Req 2 - geterr 5,919ms (± 0.37%) 5,928ms (± 0.33%) ~ 5,907ms 5,950ms p=0.470 n=6
Req 3 - references 382ms (± 0.77%) 384ms (± 1.15%) ~ 378ms 388ms p=0.470 n=6
Req 4 - navto 279ms (± 0.77%) 279ms (± 0.96%) ~ 275ms 282ms p=0.808 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 77ms (± 1.05%) 77ms (± 1.51%) ~ 76ms 79ms p=0.738 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,938ms (± 0.76%) 2,934ms (± 0.67%) ~ 2,918ms 2,972ms p=0.687 n=6
Req 2 - geterr 4,408ms (± 0.44%) 4,417ms (± 0.21%) ~ 4,405ms 4,432ms p=0.630 n=6
Req 3 - references 380ms (± 1.26%) 380ms (± 1.04%) ~ 376ms 386ms p=1.000 n=6
Req 4 - navto 289ms (± 0.36%) 289ms (± 1.10%) ~ 285ms 294ms p=0.416 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 72ms (± 1.04%) 72ms (± 1.04%) ~ 71ms 73ms p=1.000 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,643ms (± 0.40%) 3,631ms (± 0.47%) ~ 3,600ms 3,649ms p=0.230 n=6
Req 2 - geterr 1,813ms (± 1.79%) 1,814ms (± 1.52%) ~ 1,782ms 1,849ms p=0.936 n=6
Req 3 - references 113ms (± 2.92%) 114ms (± 2.14%) ~ 109ms 116ms p=1.000 n=6
Req 4 - navto 345ms (± 1.29%) 344ms (± 1.55%) ~ 338ms 349ms p=0.808 n=6
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) ~ 3,175 3,175 p=1.000 n=6
Req 5 - completionInfo 457ms (± 1.20%) 455ms (± 1.27%) ~ 448ms 463ms p=0.470 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,898ms (± 0.27%) 2,894ms (± 0.22%) ~ 2,889ms 2,906ms p=0.687 n=6
Req 2 - geterr 6,328ms (± 1.31%) 6,382ms (± 0.41%) ~ 6,354ms 6,416ms p=0.230 n=6
Req 3 - references 392ms (± 0.21%) 391ms (± 0.27%) ~ 389ms 392ms p=0.078 n=6
Req 4 - navto 281ms (± 1.48%) 284ms (± 1.08%) ~ 281ms 289ms p=0.198 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 97ms (± 8.03%) 92ms (± 9.67%) ~ 81ms 100ms p=0.118 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,083ms (± 0.64%) 3,078ms (± 0.68%) ~ 3,058ms 3,105ms p=0.688 n=6
Req 2 - geterr 4,716ms (± 0.56%) 4,719ms (± 0.25%) ~ 4,704ms 4,739ms p=0.689 n=6
Req 3 - references 411ms (± 0.86%) 410ms (± 0.65%) ~ 406ms 413ms p=0.514 n=6
Req 4 - navto 297ms (± 0.46%) 295ms (± 0.78%) ~ 291ms 298ms p=0.139 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 84ms (± 5.43%) 85ms (± 4.14%) ~ 80ms 88ms p=1.000 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,996ms (± 0.64%) 3,972ms (± 0.45%) ~ 3,948ms 3,994ms p=0.078 n=6
Req 2 - geterr 1,794ms (± 1.48%) 1,818ms (± 1.89%) ~ 1,774ms 1,853ms p=0.173 n=6
Req 3 - references 131ms (± 2.44%) 130ms (± 2.68%) ~ 126ms 136ms p=0.628 n=6
Req 4 - navto 375ms (± 1.26%) 376ms (± 0.47%) ~ 373ms 377ms p=0.683 n=6
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) ~ 3,175 3,175 p=1.000 n=6
Req 5 - completionInfo 475ms (± 2.23%) 475ms (± 1.61%) ~ 465ms 485ms p=1.000 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52640 6
Baseline main 6

Startup

Comparison Report - main..52640
Metric main 52640 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.25ms (± 0.16%) 142.44ms (± 0.20%) +0.19ms (+ 0.13%) 141.83ms 147.70ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 226.88ms (± 0.18%) 226.91ms (± 0.16%) +0.04ms (+ 0.02%) 225.96ms 232.77ms p=0.010 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.55ms (± 0.13%) 228.76ms (± 0.17%) +0.21ms (+ 0.09%) 227.84ms 235.96ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.44ms (± 0.14%) 209.57ms (± 0.14%) +0.13ms (+ 0.06%) 208.81ms 214.29ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52640 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey jakebailey merged commit 59844e7 into microsoft:main Feb 6, 2023
@jakebailey jakebailey deleted the fix-more-jsdoc-uses branch February 6, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakebailey @typescript-bot @sandersn