-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Don't consult JSDoc outside of JS in expando function assignment declarations #52640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot test this |
Heya @jakebailey, I've started to run the perf test suite on this PR at 26c71ad. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 26c71ad. You can monitor the build here. |
Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 26c71ad. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 26c71ad. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 26c71ad. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 26c71ad. You can monitor the build here. Update: The results are in! |
Heya @jakebailey, I've started to run the extended test suite on this PR at 26c71ad. You can monitor the build here. |
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
1 similar comment
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
@jakebailey Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailsbackstage/backstage
|
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
@jakebailey Here they are:
CompilerComparison Report - main..52640
System
Hosts
Scenarios
TSServerComparison Report - main..52640
System
Hosts
Scenarios
StartupComparison Report - main..52640
System
Hosts
Scenarios
Developer Information: |
After #52610 I was curious to look for more cases like these; I added an assert to
getJSDocTagsWorker
that failed whenever it was used on a non-JS file, which had loads of false positives (@deprecated
,@param
mismatch suggestions, services, etc).But it did find one bug where we were using JSDoc info when outside of a JS file.