Skip to content

Widen widening literal types through compound-like assignments #52493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 15, 2023
Merged

Widen widening literal types through compound-like assignments #52493

merged 9 commits into from
Aug 15, 2023

Conversation

Andarist
Copy link
Contributor

fixes #13865

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 30, 2023
@Andarist Andarist force-pushed the fix/widen-compound-like branch from d18dc2c to 9636938 Compare January 30, 2023 08:57
Andarist
Andarist commented Jan 30, 2023
View reviewed changes
Andarist
Andarist commented Jan 30, 2023
View reviewed changes
Andarist
Andarist commented Jan 30, 2023
View reviewed changes
@sandersn sandersn requested review from rbuckton and jakebailey March 7, 2023 19:20
rbuckton
rbuckton suggested changes Apr 12, 2023
View reviewed changes
@Andarist Andarist force-pushed the fix/widen-compound-like branch from fc11bcc to f5a1144 Compare June 26, 2023 22:11
@Andarist Andarist force-pushed the fix/widen-compound-like branch from f5a1144 to e09ec95 Compare June 26, 2023 22:40
@Andarist Andarist requested a review from rbuckton June 26, 2023 22:45
@Andarist
Copy link
Contributor Author

@rbuckton @jakebailey would you mind taking another look at this? CI is currently failing here for unrelated reasons (see #54791 )

@jakebailey
Copy link
Member

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at d110f3c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at d110f3c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at d110f3c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at d110f3c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at d110f3c. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 27, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the tarball bundle task on this PR at d110f3c. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 27, 2023 •
edited
Loading

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155678/artifacts?artifactName=tgz&fileId=644762AD852F5A029C01028F126943F8781935B521CE489313720C10FC374BD102&fileName=/typescript-5.2.0-insiders.20230627.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52493

Metric main 52493 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 366,030k (± 0.01%) 366,057k (± 0.01%) ~ 366,039k 366,092k p=0.093 n=6
Parse Time 3.59s (± 0.47%) 3.58s (± 0.33%) ~ 3.57s 3.60s p=0.410 n=6
Bind Time 1.18s (± 0.35%) 1.19s (± 0.43%) +0.01s (+ 0.71%) 1.18s 1.19s p=0.022 n=6
Check Time 9.70s (± 0.55%) 9.66s (± 0.63%) ~ 9.58s 9.76s p=0.171 n=6
Emit Time 8.02s (± 0.77%) 8.00s (± 0.63%) ~ 7.95s 8.08s p=0.687 n=6
Total Time 22.49s (± 0.46%) 22.43s (± 0.44%) ~ 22.30s 22.58s p=0.336 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,805k (± 0.04%) 193,287k (± 0.52%) +482k (+ 0.25%) 192,766k 195,338k p=0.045 n=6
Parse Time 1.59s (± 0.97%) 1.57s (± 1.77%) ~ 1.52s 1.60s p=0.188 n=6
Bind Time 0.82s (± 0.77%) 0.82s (± 0.92%) ~ 0.81s 0.83s p=0.718 n=6
Check Time 10.11s (± 0.63%) 10.13s (± 0.36%) ~ 10.08s 10.17s p=0.521 n=6
Emit Time 3.04s (± 1.26%) 3.01s (± 0.66%) ~ 2.98s 3.03s p=0.332 n=6
Total Time 15.55s (± 0.45%) 15.53s (± 0.31%) ~ 15.47s 15.59s p=0.423 n=6
Monaco - node (v16.17.1, x64)
Memory used 346,073k (± 0.01%) 346,082k (± 0.00%) ~ 346,067k 346,097k p=0.297 n=6
Parse Time 2.73s (± 0.49%) 2.73s (± 0.28%) ~ 2.72s 2.74s p=0.730 n=6
Bind Time 1.09s (± 0.37%) 1.09s (± 1.16%) ~ 1.08s 1.11s p=0.546 n=6
Check Time 7.87s (± 0.60%) 7.87s (± 0.27%) ~ 7.85s 7.91s p=0.872 n=6
Emit Time 4.49s (± 0.48%) 4.47s (± 0.65%) ~ 4.43s 4.50s p=0.290 n=6
Total Time 16.18s (± 0.34%) 16.16s (± 0.31%) ~ 16.09s 16.22s p=0.688 n=6
TFS - node (v16.17.1, x64)
Memory used 300,218k (± 0.01%) 300,235k (± 0.01%) ~ 300,205k 300,276k p=0.298 n=6
Parse Time 2.16s (± 0.59%) 2.16s (± 0.51%) ~ 2.15s 2.18s p=0.858 n=6
Bind Time 1.24s (± 0.44%) 1.23s (± 1.19%) ~ 1.22s 1.25s p=0.507 n=6
Check Time 7.34s (± 0.39%) 7.32s (± 0.49%) ~ 7.26s 7.35s p=0.260 n=6
Emit Time 4.35s (± 0.53%) 4.34s (± 0.76%) ~ 4.28s 4.37s p=1.000 n=6
Total Time 15.09s (± 0.28%) 15.05s (± 0.30%) ~ 14.98s 15.10s p=0.297 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,651k (± 0.01%) 481,600k (± 0.01%) ~ 481,539k 481,690k p=0.230 n=6
Parse Time 3.26s (± 0.39%) 3.25s (± 0.19%) ~ 3.24s 3.26s p=0.153 n=6
Bind Time 0.95s (± 0.57%) 0.95s (± 0.86%) ~ 0.94s 0.96s p=0.859 n=6
Check Time 17.96s (± 0.62%) 18.02s (± 0.35%) ~ 17.94s 18.09s p=0.335 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.18s (± 0.45%) 22.23s (± 0.30%) ~ 22.13s 22.29s p=0.521 n=6
xstate - node (v16.17.1, x64)
Memory used 561,153k (± 0.02%) 561,197k (± 0.01%) ~ 561,123k 561,329k p=0.336 n=6
Parse Time 4.00s (± 0.41%) 4.00s (± 0.29%) ~ 3.99s 4.02s p=0.681 n=6
Bind Time 1.74s (± 0.47%) 1.73s (± 0.43%) -0.01s (- 0.67%) 1.72s 1.74s p=0.024 n=6
Check Time 3.06s (± 0.56%) 3.08s (± 0.41%) ~ 3.06s 3.10s p=0.054 n=6
Emit Time 0.09s (± 5.53%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=1.000 n=6
Total Time 8.90s (± 0.29%) 8.90s (± 0.24%) ~ 8.88s 8.93s p=0.466 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52493 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52493/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52493/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

@jakebailey
Copy link
Member

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

@jakebailey
Copy link
Member

Well, I guess I'll just wait :(

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 15, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the tsc-only perf test suite on this PR at b19223c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 15, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at b19223c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 15, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at b19223c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 15, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at b19223c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 300,320k (± 0.01%) 300,361k (± 0.01%) +41k (+ 0.01%) 300,343k 300,386k p=0.030 n=6
Parse Time 3.02s (± 0.36%) 3.02s (± 0.13%) ~ 3.02s 3.03s p=1.000 n=6
Bind Time 0.93s (± 0.00%) 0.93s (± 0.00%) ~ 0.93s 0.93s p=1.000 n=6
Check Time 9.48s (± 0.25%) 9.48s (± 0.34%) ~ 9.43s 9.52s p=0.747 n=6
Emit Time 7.64s (± 0.33%) 7.63s (± 0.33%) ~ 7.61s 7.66s p=0.517 n=6
Total Time 21.07s (± 0.22%) 21.06s (± 0.13%) ~ 21.03s 21.09s p=0.871 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,820k (± 0.02%) 193,883k (± 0.01%) +63k (+ 0.03%) 193,858k 193,899k p=0.020 n=6
Parse Time 1.57s (± 1.36%) 1.58s (± 0.93%) ~ 1.55s 1.59s p=0.396 n=6
Bind Time 0.79s (± 0.52%) 0.79s (± 0.00%) ~ 0.79s 0.79s p=0.405 n=6
Check Time 9.87s (± 0.30%) 9.94s (± 0.30%) +0.07s (+ 0.73%) 9.90s 9.98s p=0.008 n=6
Emit Time 2.75s (± 0.15%) 2.74s (± 0.30%) ~ 2.73s 2.75s p=0.248 n=6
Total Time 14.98s (± 0.28%) 15.06s (± 0.29%) +0.08s (+ 0.55%) 14.99s 15.11s p=0.020 n=6
Monaco - node (v16.17.1, x64)
Memory used 347,112k (± 0.01%) 347,132k (± 0.00%) ~ 347,115k 347,158k p=0.078 n=6
Parse Time 2.69s (± 0.39%) 2.68s (± 0.15%) ~ 2.68s 2.69s p=0.528 n=6
Bind Time 0.99s (± 0.41%) 0.99s (± 0.00%) ~ 0.99s 0.99s p=0.405 n=6
Check Time 7.91s (± 0.20%) 7.91s (± 0.27%) ~ 7.88s 7.94s p=0.682 n=6
Emit Time 4.26s (± 0.35%) 4.25s (± 0.32%) ~ 4.24s 4.28s p=0.358 n=6
Total Time 15.85s (± 0.16%) 15.84s (± 0.22%) ~ 15.79s 15.88s p=1.000 n=6
TFS - node (v16.17.1, x64)
Memory used 301,122k (± 0.00%) 301,137k (± 0.01%) ~ 301,113k 301,157k p=0.229 n=6
Parse Time 2.17s (± 0.54%) 2.17s (± 0.71%) ~ 2.15s 2.19s p=0.869 n=6
Bind Time 1.11s (± 0.00%) 1.11s (± 0.74%) ~ 1.09s 1.11s p=0.405 n=6
Check Time 7.22s (± 0.33%) 7.24s (± 0.17%) ~ 7.23s 7.26s p=0.125 n=6
Emit Time 3.98s (± 0.20%) 3.99s (± 0.63%) ~ 3.96s 4.02s p=0.513 n=6
Total Time 14.49s (± 0.21%) 14.51s (± 0.16%) ~ 14.48s 14.54s p=0.198 n=6
material-ui - node (v16.17.1, x64)
Memory used 479,423k (± 0.01%) 479,429k (± 0.01%) ~ 479,380k 479,480k p=0.936 n=6
Parse Time 3.15s (± 0.13%) 3.15s (± 0.26%) ~ 3.15s 3.17s p=0.218 n=6
Bind Time 0.91s (± 0.00%) 0.91s (± 0.00%) ~ 0.91s 0.91s p=1.000 n=6
Check Time 17.92s (± 0.31%) 17.93s (± 0.28%) ~ 17.86s 17.99s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.98s (± 0.27%) 21.99s (± 0.23%) ~ 21.92s 22.05s p=1.000 n=6
xstate - node (v16.17.1, x64)
Memory used 542,813k (± 0.01%) 542,812k (± 0.01%) ~ 542,724k 542,944k p=0.873 n=6
Parse Time 3.70s (± 0.20%) 3.70s (± 0.32%) ~ 3.68s 3.71s p=0.796 n=6
Bind Time 1.36s (± 3.97%) 1.36s (± 3.38%) ~ 1.33s 1.45s p=1.000 n=6
Check Time 3.32s (± 2.17%) 3.31s (± 2.02%) ~ 3.18s 3.36s p=0.808 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 4.99%) ~ 0.08s 0.09s p=0.405 n=6
Total Time 8.46s (± 0.46%) 8.46s (± 0.44%) ~ 8.39s 8.49s p=0.936 n=6
System info unknown
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52493/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-52493/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52493/merge:

Everything looks good!

jakebailey
jakebailey approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me now; is there anything left here?

@Andarist
Copy link
Contributor Author

Nothing that I would be aware of :)

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

@jakebailey jakebailey merged commit cac899d into microsoft:main Aug 15, 2023
snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023
@Andarist @snovader
Widen widening literal types through compound-like assignments (micro…
dd80cf9 
…soft#52493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees

@jakebailey jakebailey

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent treatment of non-widening string literal types and +=
4 participants
@Andarist @jakebailey @typescript-bot @rbuckton