Improve quickinfo/signature/completions baselines #52308
Conversation
Add a copy with of the file at the top with annotations, like find-all-ref and rename baselines. I'm not 100% sure about the formatting, but I don't think it's too overbearing; for the few files with lots of tests, more decoration is helpful. I don't know whether sticking to jsonc syntax is worthwhile either. I think the '// ' prefix hurts readability but might be worthwhile in some future world where we need to query our baselines for information.
Lots of duplicated code; I'll improve that later.
Even more duplicated code.
And start refactoring all 3 baseline functions to a single one.
typescript-bot
added
Author: Team
For Uncommitted Bug
There was a problem hiding this comment.
This is a big improvement. I don’t have a problem with this format with the leading slashes, but one thing you can consider is using a real file extension (.baseline.jsonc for example) if you want to control the syntax highlighting. I've used Markdown for some, which has the advantage of embedding languages.
tests/baselines/reference/completionDetailsOfContextSensitiveParameterNoCrash.baseline
Show resolved
Hide resolved
| // property = "foo" | ||
| // | ||
| // | ||
| // ^ |
There was a problem hiding this comment.
Nit: lots, but not all, of these have 2 extra blank lines. Is that easy to fix?
There was a problem hiding this comment.
I think what you're seeing is from the source, not the new formatting:
export class C implements I {
property = "foo"
/*1*/It's easy to fix but hard to know whether I've fixed them all.
There was a problem hiding this comment.
Got it, I don’t have a problem if it was from the source. I just assumed it was a baseline issue that it made it look like the source was doing weird stuff.
sandersn
deleted the
improve-quickinfo/signature/completions-baselines
branch
Add a copy of the file at the top with tooltip-like annotations, a bit like find-all-ref and rename baselines.
I'm not 100% sure about the formatting, but I don't think it's too overbearing; for the few files with lots of tests, more decoration is helpful.
I don't know whether sticking to jsonc syntax is worthwhile either. I think the
//prefix hurts readability but might be worthwhile in some future world where we need to query our baselines for information.