fix(52212): No member completions, and irrelevant value completions, when class property initializer has no semicolon #52213

a-tarasyuk · 2023-01-12T20:39:38Z

Fixes #52212

…rty initializer doesn't have a semicolon

tests/cases/fourslash/completionsClassMembers.ts

src/services/completions.ts

DanielRosenwasser · 2023-01-12T22:52:17Z

Merge conflict 😞

…ix/52212

src/services/completions.ts

DanielRosenwasser · 2023-01-13T20:09:36Z

@typescript-bot pack this
@typescript-bot test tsserver top100

typescript-bot · 2023-01-13T20:09:40Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 98e179d. You can monitor the build here.

typescript-bot · 2023-01-13T20:09:40Z

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at 98e179d. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-13T20:11:22Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/142612/artifacts?artifactName=tgz&fileId=EFAC133DB377D1A9C61D5516D807193EB04F2422D6625C1EE5CD3B9349F68E9A02&fileName=/typescript-5.0.0-insiders.20230113.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2023-01-13T21:59:46Z

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/52213/merge:

Something interesting changed - please have a look.

Details

felixrieseberg/windows95

⚠️ Note that built also had errors ⚠️

Req #252 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:174242:21)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:175516:21)
    at IOSession.send (/typescript-main/built/local/tsserver.js:175513:10)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:175569:10)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:177347:14)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:178785:14)

Req #252 - references
    at formatMessage2 (/typescript-52213/built/local/tsserver.js:174242:21)
    at IOSession.writeMessage (/typescript-52213/built/local/tsserver.js:175516:21)
    at IOSession.send (/typescript-52213/built/local/tsserver.js:175513:10)
    at IOSession.doOutput (/typescript-52213/built/local/tsserver.js:175569:10)
    at IOSession.onMessage (/typescript-52213/built/local/tsserver.js:177347:14)
    at Interface.<anonymous> (/typescript-52213/built/local/tsserver.js:178785:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/felixrieseberg.windows95.rawError.txt in the artifact folder

Last few requests

{"seq":249,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":7419,"entryNames":["_"]}}
{"seq":250,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":8454,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":251,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":8454,"entryNames":["_"]}}
{"seq":252,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":8484}}

Repro Steps

git clone https://github.com/felixrieseberg/windows95 --recurse-submodules
In dir windows95, run git reset --hard 17a81393467e2668eb2eea291ab4b6a749756dad
In dir windows95, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/felixrieseberg.windows95.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./windows95 ./felixrieseberg.windows95.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

palantir/blueprint

⚠️ Note that built also had errors ⚠️

Req #17161 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:174242:21)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:175516:21)
    at IOSession.send (/typescript-main/built/local/tsserver.js:175513:10)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:175569:10)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:177347:14)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:178785:14)

Req #17161 - references
    at formatMessage2 (/typescript-52213/built/local/tsserver.js:174242:21)
    at IOSession.writeMessage (/typescript-52213/built/local/tsserver.js:175516:21)
    at IOSession.send (/typescript-52213/built/local/tsserver.js:175513:10)
    at IOSession.doOutput (/typescript-52213/built/local/tsserver.js:175569:10)
    at IOSession.onMessage (/typescript-52213/built/local/tsserver.js:177347:14)
    at Interface.<anonymous> (/typescript-52213/built/local/tsserver.js:178785:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in the artifact folder

Last few requests

{"seq":17158,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":2694659,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":17159,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":2694803,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":17160,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":2695323}}
{"seq":17161,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":2695490}}

Repro Steps

git clone https://github.com/palantir/blueprint --recurse-submodules
In dir blueprint, run git reset --hard febdf73d3a3e6f7e850c3cbdd271a3f28b645a87
In dir blueprint, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

fix(52212): show the completion of class members when the class prope…

bbf90d8

…rty initializer doesn't have a semicolon

typescript-bot assigned navya9singh Jan 12, 2023

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jan 12, 2023

DanielRosenwasser reviewed Jan 12, 2023

View reviewed changes

tests/cases/fourslash/completionsClassMembers.ts Outdated Show resolved Hide resolved

add tests

b400eb9

DanielRosenwasser reviewed Jan 12, 2023

View reviewed changes

src/services/completions.ts Outdated Show resolved Hide resolved

DanielRosenwasser requested review from gabritto and navya9singh January 12, 2023 21:49

add tests. combine duplicate conditions

1660f14

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

59ec564

…ix/52212

DanielRosenwasser approved these changes Jan 13, 2023

View reviewed changes

gabritto reviewed Jan 13, 2023

View reviewed changes

src/services/completions.ts Outdated Show resolved Hide resolved

a-tarasyuk requested review from gabritto and removed request for navya9singh January 13, 2023 17:37

remove useless check

98e179d

gabritto approved these changes Jan 13, 2023

View reviewed changes

gabritto merged commit 86ccd20 into microsoft:main Jan 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(52212): No member completions, and irrelevant value completions, when class property initializer has no semicolon #52213

fix(52212): No member completions, and irrelevant value completions, when class property initializer has no semicolon #52213

Uh oh!

a-tarasyuk commented Jan 12, 2023

Uh oh!

Uh oh!

Uh oh!

DanielRosenwasser commented Jan 12, 2023

Uh oh!

Uh oh!

DanielRosenwasser commented Jan 13, 2023

Uh oh!

typescript-bot commented Jan 13, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Jan 13, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Jan 13, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Jan 13, 2023

felixrieseberg/windows95

Last few requests

Repro Steps

palantir/blueprint

Last few requests

Repro Steps

Uh oh!

Uh oh!

fix(52212): No member completions, and irrelevant value completions, when class property initializer has no semicolon #52213

fix(52212): No member completions, and irrelevant value completions, when class property initializer has no semicolon #52213

Uh oh!

Conversation

a-tarasyuk commented Jan 12, 2023

Uh oh!

Uh oh!

Uh oh!

DanielRosenwasser commented Jan 12, 2023

Uh oh!

Uh oh!

DanielRosenwasser commented Jan 13, 2023

Uh oh!

typescript-bot commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 13, 2023

felixrieseberg/windows95

Last few requests

Repro Steps

palantir/blueprint

Last few requests

Repro Steps

Uh oh!

Uh oh!

typescript-bot commented Jan 13, 2023 •

edited

Loading

typescript-bot commented Jan 13, 2023 •

edited

Loading

typescript-bot commented Jan 13, 2023 •

edited

Loading