Skip to content

[experiment] Make Diagnostics be a huge literal #52202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[experiment] Make Diagnostics be a huge literal #52202

wants to merge 2 commits into from

Conversation

jakebailey
Copy link
Member

Includes #52201 for now because I'm impatient

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 12, 2023
@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at f86b34d. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52202
Metric main 52202 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 372,410k (± 0.01%) 372,883k (± 0.01%) +472k (+ 0.13%) 372,830k 372,928k
Parse Time 3.93s (± 0.92%) 3.94s (± 1.04%) +0.01s (+ 0.23%) 3.90s 4.02s
Bind Time 1.19s (± 0.87%) 1.20s (± 0.48%) +0.00s (+ 0.24%) 1.19s 1.20s
Check Time 8.61s (± 0.31%) 8.64s (± 0.33%) +0.04s (+ 0.41%) 8.61s 8.69s
Emit Time 7.52s (± 0.62%) 7.54s (± 0.55%) +0.02s (+ 0.32%) 7.48s 7.59s
Total Time 21.25s (± 0.41%) 21.33s (± 0.44%) +0.08s (+ 0.36%) 21.19s 21.46s
Compiler-Unions - node (v18.10.0, x64)
Memory used 199,284k (± 1.16%) 200,721k (± 1.45%) +1,437k (+ 0.72%) 198,807k 204,483k
Parse Time 1.65s (± 1.27%) 1.66s (± 0.55%) +0.01s (+ 0.47%) 1.65s 1.68s
Bind Time 0.79s (± 0.72%) 0.79s (± 0.69%) +0.00s (+ 0.28%) 0.79s 0.80s
Check Time 9.46s (± 0.75%) 9.58s (± 0.44%) +0.12s (+ 1.28%) 9.50s 9.62s
Emit Time 2.75s (± 0.83%) 2.78s (± 1.10%) +0.03s (+ 1.16%) 2.74s 2.83s
Total Time 14.65s (± 0.50%) 14.82s (± 0.45%) +0.16s (+ 1.12%) 14.70s 14.90s
Monaco - node (v18.10.0, x64)
Memory used 354,139k (± 0.01%) 354,595k (± 0.01%) +457k (+ 0.13%) 354,546k 354,637k
Parse Time 2.96s (± 0.64%) 2.95s (± 0.73%) -0.01s (- 0.33%) 2.92s 2.99s
Bind Time 1.04s (± 1.62%) 1.04s (± 0.92%) +0.01s (+ 0.81%) 1.03s 1.06s
Check Time 7.20s (± 0.43%) 7.20s (± 0.40%) +0.01s (+ 0.10%) 7.16s 7.23s
Emit Time 4.30s (± 1.18%) 4.29s (± 0.70%) -0.01s (- 0.34%) 4.24s 4.33s
Total Time 15.49s (± 0.37%) 15.48s (± 0.44%) -0.01s (- 0.08%) 15.40s 15.56s
TFS - node (v18.10.0, x64)
Memory used 310,191k (± 0.01%) 310,704k (± 0.00%) +513k (+ 0.17%) 310,689k 310,731k
Parse Time 2.28s (± 1.34%) 2.27s (± 1.84%) -0.00s (- 0.21%) 2.20s 2.31s
Bind Time 1.14s (± 0.78%) 1.15s (± 1.20%) +0.01s (+ 0.66%) 1.13s 1.17s
Check Time 6.83s (± 0.49%) 6.82s (± 0.23%) -0.01s (- 0.16%) 6.81s 6.85s
Emit Time 3.93s (± 0.94%) 3.95s (± 0.48%) +0.01s (+ 0.35%) 3.91s 3.96s
Total Time 14.19s (± 0.34%) 14.19s (± 0.47%) +0.00s (+ 0.03%) 14.07s 14.25s
material-ui - node (v18.10.0, x64)
Memory used 485,217k (± 0.02%) 485,748k (± 0.01%) +531k (+ 0.11%) 485,683k 485,801k
Parse Time 3.54s (± 0.21%) 3.54s (± 0.35%) +0.00s (+ 0.09%) 3.53s 3.56s
Bind Time 0.96s (± 0.74%) 0.96s (± 0.58%) +0.00s (+ 0.00%) 0.95s 0.97s
Check Time 16.91s (± 0.53%) 17.01s (± 0.60%) +0.10s (+ 0.57%) 16.83s 17.11s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.41s (± 0.39%) 21.51s (± 0.50%) +0.10s (+ 0.46%) 21.31s 21.61s
xstate - node (v18.10.0, x64)
Memory used 570,330k (± 0.02%) 571,895k (± 0.02%) +1,565k (+ 0.27%) 571,791k 572,015k
Parse Time 4.44s (± 0.74%) 4.48s (± 0.22%) +0.04s (+ 0.81%) 4.46s 4.49s
Bind Time 1.70s (± 0.59%) 1.71s (± 0.96%) +0.00s (+ 0.22%) 1.69s 1.73s
Check Time 2.60s (± 0.61%) 2.62s (± 0.50%) +0.02s (+ 0.73%) 2.60s 2.63s
Emit Time 0.08s (± 0.21%) 0.08s (± 4.92%) +0.00s (+ 1.91%) 0.08s 0.09s
Total Time 8.83s (± 0.54%) 8.88s (± 0.28%) +0.05s (+ 0.59%) 8.84s 8.91s
Angular - node (v16.17.1, x64)
Memory used 371,735k (± 0.01%) 372,251k (± 0.01%) +516k (+ 0.14%) 372,202k 372,314k
Parse Time 4.13s (± 0.68%) 4.11s (± 0.11%) -0.02s (- 0.38%) 4.11s 4.12s
Bind Time 1.26s (± 0.74%) 1.26s (± 0.57%) -0.01s (- 0.49%) 1.24s 1.27s
Check Time 9.32s (± 0.24%) 9.30s (± 0.43%) -0.01s (- 0.14%) 9.25s 9.36s
Emit Time 7.99s (± 0.52%) 8.00s (± 0.78%) +0.02s (+ 0.19%) 7.92s 8.05s
Total Time 22.70s (± 0.27%) 22.68s (± 0.42%) -0.01s (- 0.06%) 22.55s 22.76s
Compiler-Unions - node (v16.17.1, x64)
Memory used 199,991k (± 0.02%) 200,513k (± 0.05%) +523k (+ 0.26%) 200,415k 200,643k
Parse Time 1.81s (± 0.56%) 1.82s (± 0.59%) +0.00s (+ 0.18%) 1.81s 1.83s
Bind Time 0.84s (± 0.77%) 0.84s (± 0.73%) +0.00s (+ 0.40%) 0.83s 0.85s
Check Time 10.03s (± 0.43%) 10.05s (± 0.57%) +0.01s (+ 0.12%) 9.98s 10.13s
Emit Time 2.98s (± 2.59%) 2.97s (± 1.03%) -0.01s (- 0.33%) 2.94s 3.02s
Total Time 15.67s (± 0.43%) 15.67s (± 0.53%) +0.01s (+ 0.04%) 15.58s 15.79s
Monaco - node (v16.17.1, x64)
Memory used 353,427k (± 0.01%) 353,945k (± 0.01%) +518k (+ 0.15%) 353,922k 353,967k
Parse Time 3.17s (± 0.69%) 3.16s (± 0.54%) -0.01s (- 0.24%) 3.13s 3.17s
Bind Time 1.12s (± 0.95%) 1.13s (± 0.79%) +0.01s (+ 0.56%) 1.12s 1.14s
Check Time 7.87s (± 0.65%) 7.88s (± 0.58%) +0.01s (+ 0.11%) 7.84s 7.97s
Emit Time 4.50s (± 0.52%) 4.48s (± 0.37%) -0.02s (- 0.48%) 4.45s 4.50s
Total Time 16.66s (± 0.38%) 16.65s (± 0.24%) -0.01s (- 0.07%) 16.59s 16.70s
TFS - node (v16.17.1, x64)
Memory used 309,552k (± 0.00%) 310,072k (± 0.01%) +520k (+ 0.17%) 310,049k 310,101k
Parse Time 2.66s (± 1.87%) 2.47s (± 3.95%) 🟩-0.19s (- 7.11%) 2.37s 2.64s
Bind Time 1.04s (± 1.48%) 1.20s (± 6.76%) +0.17s (+15.96%) 1.05s 1.28s
Check Time 7.39s (± 0.31%) 7.40s (± 0.32%) +0.02s (+ 0.20%) 7.38s 7.44s
Emit Time 4.24s (± 0.53%) 4.23s (± 0.26%) -0.00s (- 0.11%) 4.22s 4.25s
Total Time 15.33s (± 0.18%) 15.31s (± 0.33%) -0.02s (- 0.12%) 15.26s 15.40s
material-ui - node (v16.17.1, x64)
Memory used 484,511k (± 0.01%) 485,022k (± 0.00%) +511k (+ 0.11%) 485,000k 485,032k
Parse Time 3.66s (± 0.32%) 3.67s (± 0.31%) +0.00s (+ 0.07%) 3.66s 3.68s
Bind Time 1.01s (± 0.49%) 1.01s (± 0.52%) +0.00s (+ 0.17%) 1.01s 1.02s
Check Time 17.86s (± 0.64%) 17.92s (± 0.23%) +0.06s (+ 0.32%) 17.85s 17.96s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.53s (± 0.54%) 22.60s (± 0.21%) +0.07s (+ 0.29%) 22.52s 22.65s
xstate - node (v16.17.1, x64)
Memory used 567,924k (± 0.01%) 569,467k (± 0.01%) +1,543k (+ 0.27%) 569,382k 569,550k
Parse Time 4.76s (± 0.46%) 4.61s (± 0.22%) 🟩-0.15s (- 3.14%) 4.60s 4.63s
Bind Time 1.65s (± 0.30%) 1.80s (± 0.57%) +0.16s (+ 9.41%) 1.78s 1.81s
Check Time 2.84s (± 0.49%) 2.84s (± 0.14%) +0.00s (+ 0.15%) 2.83s 2.84s
Emit Time 0.08s (± 6.51%) 0.08s (± 5.05%) 🟩-0.00s (- 3.89%) 0.08s 0.09s
Total Time 9.34s (± 0.32%) 9.34s (± 0.10%) +0.00s (+ 0.01%) 9.33s 9.36s
Angular - node (v14.15.1, x64)
Memory used 365,425k (± 0.01%) 365,997k (± 0.01%) +572k (+ 0.16%) 365,959k 366,022k
Parse Time 4.16s (± 0.23%) 4.17s (± 0.38%) +0.00s (+ 0.04%) 4.14s 4.19s
Bind Time 1.30s (± 0.55%) 1.30s (± 0.47%) +0.00s (+ 0.00%) 1.29s 1.31s
Check Time 9.64s (± 0.36%) 9.66s (± 0.36%) +0.02s (+ 0.23%) 9.60s 9.70s
Emit Time 8.19s (± 0.48%) 8.23s (± 0.71%) +0.04s (+ 0.47%) 8.18s 8.34s
Total Time 23.30s (± 0.24%) 23.37s (± 0.39%) +0.07s (+ 0.29%) 23.24s 23.51s
Compiler-Unions - node (v14.15.1, x64)
Memory used 195,750k (± 0.69%) 195,786k (± 0.01%) +36k (+ 0.02%) 195,763k 195,823k
Parse Time 1.86s (± 0.46%) 1.86s (± 0.32%) -0.00s (- 0.08%) 1.85s 1.86s
Bind Time 0.87s (± 0.60%) 0.88s (± 0.74%) +0.01s (+ 0.60%) 0.87s 0.89s
Check Time 10.14s (± 0.44%) 10.13s (± 0.39%) -0.02s (- 0.15%) 10.06s 10.17s
Emit Time 3.12s (± 1.14%) 3.15s (± 0.52%) +0.03s (+ 0.84%) 3.13s 3.17s
Total Time 15.99s (± 0.33%) 16.01s (± 0.29%) +0.02s (+ 0.10%) 15.93s 16.06s
Monaco - node (v14.15.1, x64)
Memory used 348,327k (± 0.01%) 348,863k (± 0.00%) +537k (+ 0.15%) 348,846k 348,890k
Parse Time 3.25s (± 0.83%) 3.25s (± 0.86%) -0.00s (- 0.10%) 3.22s 3.28s
Bind Time 1.11s (± 0.46%) 1.11s (± 0.72%) -0.00s (- 0.40%) 1.11s 1.13s
Check Time 8.15s (± 0.54%) 8.13s (± 0.40%) -0.01s (- 0.18%) 8.09s 8.19s
Emit Time 4.68s (± 0.53%) 4.69s (± 0.48%) +0.01s (+ 0.11%) 4.65s 4.71s
Total Time 17.19s (± 0.37%) 17.18s (± 0.16%) -0.01s (- 0.06%) 17.13s 17.20s
TFS - node (v14.15.1, x64)
Memory used 304,472k (± 0.00%) 305,041k (± 0.00%) +570k (+ 0.19%) 305,018k 305,052k
Parse Time 2.75s (± 1.53%) 2.77s (± 0.62%) +0.02s (+ 0.57%) 2.75s 2.80s
Bind Time 1.10s (± 0.17%) 1.09s (± 1.23%) -0.01s (- 0.79%) 1.08s 1.11s
Check Time 7.70s (± 0.44%) 7.73s (± 0.49%) +0.04s (+ 0.48%) 7.69s 7.78s
Emit Time 4.57s (± 0.64%) 4.60s (± 1.62%) +0.03s (+ 0.73%) 4.49s 4.68s
Total Time 16.11s (± 0.44%) 16.20s (± 0.53%) +0.08s (+ 0.51%) 16.05s 16.28s
material-ui - node (v14.15.1, x64)
Memory used 479,942k (± 0.01%) 480,543k (± 0.00%) +601k (+ 0.13%) 480,512k 480,567k
Parse Time 3.90s (± 0.70%) 3.89s (± 0.46%) -0.01s (- 0.16%) 3.88s 3.92s
Bind Time 1.05s (± 0.90%) 1.04s (± 0.47%) -0.01s (- 0.83%) 1.03s 1.05s
Check Time 18.86s (± 0.35%) 18.93s (± 0.56%) +0.07s (+ 0.36%) 18.79s 19.05s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 23.81s (± 0.34%) 23.87s (± 0.44%) +0.05s (+ 0.22%) 23.74s 24.01s
xstate - node (v14.15.1, x64)
Memory used 556,311k (± 0.00%) 558,056k (± 0.00%) +1,745k (+ 0.31%) 558,034k 558,076k
Parse Time 5.10s (± 0.94%) 5.14s (± 0.56%) +0.05s (+ 0.91%) 5.10s 5.17s
Bind Time 1.59s (± 0.21%) 1.59s (± 0.58%) -0.00s (- 0.06%) 1.57s 1.60s
Check Time 2.99s (± 0.42%) 2.99s (± 0.30%) -0.00s (- 0.17%) 2.97s 3.00s
Emit Time 0.10s (± 0.10%) 0.10s (± 0.23%) -0.00s (- 0.17%) 0.10s 0.10s
Total Time 9.78s (± 0.46%) 9.82s (± 0.27%) +0.05s (+ 0.46%) 9.78s 9.85s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52202 6
Baseline main 6

TSServer

Comparison Report - main..52202
Metric main 52202 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,534ms (± 1.08%) 2,530ms (± 1.94%) -3ms (- 0.12%) 2,470ms 2,590ms
Req 2 - geterr 5,401ms (± 2.66%) 5,346ms (± 0.94%) -55ms (- 1.02%) 5,273ms 5,416ms
Req 3 - references 369ms (± 0.90%) 374ms (± 0.95%) +6ms (+ 1.52%) 370ms 379ms
Req 4 - navto 285ms (± 3.34%) 281ms (± 1.27%) -4ms (- 1.37%) 278ms 288ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 263ms (±32.67%) 302ms (± 2.64%) +38ms (+14.57%) 286ms 309ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,785ms (± 0.95%) 2,769ms (± 0.79%) -16ms (- 0.58%) 2,726ms 2,783ms
Req 2 - geterr 3,986ms (± 0.50%) 3,975ms (± 0.81%) -11ms (- 0.27%) 3,935ms 4,024ms
Req 3 - references 363ms (± 0.90%) 363ms (± 0.47%) -0ms (- 0.08%) 360ms 365ms
Req 4 - navto 294ms (± 0.96%) 293ms (± 0.47%) -2ms (- 0.58%) 290ms 294ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 69ms (± 5.19%) 68ms (± 4.88%) -2ms (- 2.69%) 65ms 72ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,368ms (± 0.25%) 3,371ms (± 0.63%) +2ms (+ 0.07%) 3,343ms 3,398ms
Req 2 - geterr 1,531ms (± 1.39%) 1,530ms (± 1.30%) -1ms (- 0.03%) 1,505ms 1,553ms
Req 3 - references 103ms (± 2.86%) 106ms (± 1.95%) +2ms (+ 1.98%) 103ms 108ms
Req 4 - navto 359ms (± 1.28%) 358ms (± 1.17%) -1ms (- 0.29%) 353ms 363ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 426ms (± 1.80%) 429ms (± 1.03%) +3ms (+ 0.62%) 423ms 434ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,789ms (± 0.65%) 2,702ms (± 6.46%) 🟩-88ms (- 3.14%) 2,346ms 2,791ms
Req 2 - geterr 5,864ms (± 1.90%) 5,730ms (± 7.88%) -134ms (- 2.28%) 4,846ms 6,050ms
Req 3 - references 365ms (± 1.29%) 355ms (± 6.82%) -10ms (- 2.74%) 306ms 373ms
Req 4 - navto 279ms (± 0.97%) 273ms (± 6.67%) -6ms (- 2.19%) 236ms 282ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 164ms (±70.86%) 122ms (±79.81%) 🟩-42ms (-25.85%) 68ms 320ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,917ms (± 0.67%) 2,935ms (± 0.49%) +18ms (+ 0.62%) 2,920ms 2,958ms
Req 2 - geterr 4,305ms (± 0.34%) 4,273ms (± 0.46%) -32ms (- 0.74%) 4,247ms 4,305ms
Req 3 - references 377ms (± 0.58%) 378ms (± 0.81%) +1ms (+ 0.17%) 373ms 381ms
Req 4 - navto 303ms (± 0.59%) 303ms (± 0.57%) -0ms (- 0.00%) 300ms 305ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 233ms (±52.97%) 72ms (± 1.46%) 🟩-161ms (-69.14%) 71ms 73ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,755ms (± 0.30%) 3,770ms (± 0.48%) +15ms (+ 0.39%) 3,747ms 3,794ms
Req 2 - geterr 1,437ms (± 0.78%) 1,446ms (± 1.51%) +9ms (+ 0.63%) 1,413ms 1,470ms
Req 3 - references 110ms (± 2.89%) 111ms (± 1.72%) +2ms (+ 1.46%) 109ms 114ms
Req 4 - navto 347ms (± 2.26%) 344ms (± 0.48%) -4ms (- 1.01%) 341ms 346ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 470ms (± 2.94%) 474ms (± 1.79%) +3ms (+ 0.70%) 464ms 486ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,734ms (± 8.11%) 2,799ms (± 6.42%) +65ms (+ 2.37%) 2,432ms 2,881ms
Req 2 - geterr 5,812ms (± 8.59%) 5,976ms (± 6.38%) +164ms (+ 2.82%) 5,203ms 6,195ms
Req 3 - references 359ms (± 8.29%) 369ms (± 6.52%) +10ms (+ 2.73%) 320ms 381ms
Req 4 - navto 276ms (± 8.11%) 285ms (± 6.41%) +9ms (+ 3.43%) 248ms 295ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 83ms (±12.95%) 85ms (± 7.37%) +2ms (+ 2.16%) 74ms 93ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,012ms (± 0.70%) 3,018ms (± 0.72%) +6ms (+ 0.21%) 2,989ms 3,048ms
Req 2 - geterr 4,553ms (± 0.97%) 4,581ms (± 0.50%) +28ms (+ 0.61%) 4,555ms 4,609ms
Req 3 - references 404ms (± 0.93%) 400ms (± 1.19%) -4ms (- 0.92%) 392ms 405ms
Req 4 - navto 307ms (± 1.02%) 305ms (± 0.55%) -2ms (- 0.76%) 303ms 307ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 80ms (± 6.88%) 91ms (± 6.44%) +11ms (+13.51%) 80ms 96ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,864ms (± 0.33%) 3,862ms (± 0.35%) -2ms (- 0.05%) 3,843ms 3,877ms
Req 2 - geterr 1,467ms (± 1.10%) 1,459ms (± 0.66%) -9ms (- 0.60%) 1,449ms 1,475ms
Req 3 - references 125ms (± 2.08%) 128ms (± 2.91%) +2ms (+ 1.65%) 121ms 132ms
Req 4 - navto 396ms (± 1.34%) 392ms (± 1.29%) -4ms (- 1.03%) 382ms 396ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 493ms (± 1.60%) 502ms (± 1.33%) +9ms (+ 1.92%) 491ms 512ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52202 6
Baseline main 6

Startup

Comparison Report - main..52202
Metric main 52202 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 139.80ms (± 0.22%) 150.39ms (± 0.53%) +10.59ms (+ 7.57%) 147.76ms 154.66ms
tsserver-startup - node (v16.17.1, x64)
Execution time 232.31ms (± 0.26%) 244.61ms (± 0.45%) +12.31ms (+ 5.30%) 239.29ms 250.77ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 235.26ms (± 0.35%) 245.57ms (± 0.40%) +10.31ms (+ 4.38%) 240.32ms 251.69ms
typescript-startup - node (v16.17.1, x64)
Execution time 216.74ms (± 0.32%) 227.29ms (± 0.31%) +10.55ms (+ 4.87%) 222.35ms 231.42ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52202 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

Hm, disappointing. I didn't expect startup to get slower...

@jakebailey jakebailey closed this Jan 12, 2023
@jakebailey jakebailey deleted the diagnostic-literals branch March 18, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakebailey @typescript-bot