Skip to content

Cover more literal expressions in getQuickTypeOfExpression #52181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2023
Merged

Cover more literal expressions in getQuickTypeOfExpression #52181

merged 1 commit into from
Feb 2, 2023

Conversation

Andarist
Copy link
Contributor

It's just a thing that I noticed when working on different things.

@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 10, 2023
Andarist
Andarist commented Jan 10, 2023
View reviewed changes
src/compiler/checker.ts
Comment on lines -36509 to 36511
node.kind === SyntaxKind.TrueKeyword || node.kind === SyntaxKind.FalseKeyword) {
else if (isLiteralExpression(node) || isBooleanLiteral(node)) {
return checkExpression(node);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the test suite passes even if we remove this else if block entirely - leading me to believe that this is merely an optimization for those types here (as it's not an unused code ⚠️ ).

The main improvement here is to just cover every literal type - including bigints, regexps and "no substitution template literals".

Feel free to close the PR if you don't like this change.

@andrewbranch
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 1, 2023 •
edited
Loading

Heya @andrewbranch, I've started to run the perf test suite on this PR at 2c65347. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52181
Metric main 52181 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 359,827k (± 0.02%) 359,838k (± 0.02%) +12k (+ 0.00%) 359,730k 359,938k
Parse Time 3.97s (± 0.77%) 3.96s (± 0.50%) -0.01s (- 0.25%) 3.93s 3.98s
Bind Time 1.17s (± 0.44%) 1.18s (± 0.69%) +0.00s (+ 0.28%) 1.17s 1.19s
Check Time 8.63s (± 0.32%) 8.64s (± 0.27%) +0.01s (+ 0.08%) 8.61s 8.67s
Emit Time 7.60s (± 0.55%) 7.61s (± 0.60%) +0.01s (+ 0.11%) 7.57s 7.68s
Total Time 21.37s (± 0.36%) 21.38s (± 0.29%) +0.01s (+ 0.04%) 21.28s 21.47s
Compiler-Unions - node (v18.10.0, x64)
Memory used 192,551k (± 0.01%) 193,486k (± 1.17%) +935k (+ 0.49%) 192,485k 198,107k
Parse Time 1.60s (± 0.86%) 1.64s (± 1.42%) +0.04s (+ 2.39%) 1.60s 1.67s
Bind Time 0.79s (± 0.69%) 0.80s (± 0.69%) +0.00s (+ 0.00%) 0.79s 0.80s
Check Time 9.61s (± 0.57%) 9.64s (± 0.49%) +0.04s (+ 0.38%) 9.60s 9.73s
Emit Time 2.80s (± 0.64%) 2.81s (± 0.79%) +0.01s (+ 0.30%) 2.78s 2.84s
Total Time 14.80s (± 0.28%) 14.89s (± 0.29%) +0.08s (+ 0.56%) 14.84s 14.96s
Monaco - node (v18.10.0, x64)
Memory used 343,982k (± 0.01%) 344,003k (± 0.01%) +20k (+ 0.01%) 343,955k 344,041k
Parse Time 2.94s (± 1.14%) 2.95s (± 1.58%) +0.01s (+ 0.40%) 2.89s 3.02s
Bind Time 1.05s (± 1.11%) 1.04s (± 0.99%) -0.01s (- 0.48%) 1.03s 1.06s
Check Time 7.05s (± 0.75%) 7.09s (± 0.75%) +0.04s (+ 0.57%) 7.00s 7.14s
Emit Time 4.34s (± 0.67%) 4.36s (± 1.49%) +0.02s (+ 0.38%) 4.28s 4.46s
Total Time 15.37s (± 0.36%) 15.44s (± 1.00%) +0.07s (+ 0.44%) 15.21s 15.64s
TFS - node (v18.10.0, x64)
Memory used 300,402k (± 0.00%) 300,417k (± 0.01%) +15k (+ 0.01%) 300,381k 300,438k
Parse Time 2.25s (± 0.83%) 2.25s (± 1.74%) -0.00s (- 0.07%) 2.21s 2.30s
Bind Time 1.17s (± 0.54%) 1.17s (± 0.35%) -0.00s (- 0.14%) 1.16s 1.17s
Check Time 6.53s (± 0.27%) 6.55s (± 0.39%) +0.02s (+ 0.31%) 6.53s 6.59s
Emit Time 3.93s (± 1.12%) 3.94s (± 0.57%) +0.01s (+ 0.17%) 3.92s 3.98s
Total Time 13.89s (± 0.49%) 13.91s (± 0.43%) +0.03s (+ 0.19%) 13.85s 13.99s
material-ui - node (v18.10.0, x64)
Memory used 476,758k (± 0.01%) 476,739k (± 0.00%) -20k (- 0.00%) 476,715k 476,774k
Parse Time 3.52s (± 1.83%) 3.57s (± 0.72%) +0.05s (+ 1.52%) 3.53s 3.60s
Bind Time 1.00s (± 7.05%) 0.97s (± 0.65%) -0.03s (- 2.68%) 0.96s 0.98s
Check Time 17.05s (± 0.61%) 17.19s (± 0.74%) +0.14s (+ 0.79%) 17.03s 17.40s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.57s (± 0.48%) 21.73s (± 0.67%) +0.16s (+ 0.75%) 21.53s 21.96s
xstate - node (v18.10.0, x64)
Memory used 548,589k (± 0.02%) 548,620k (± 0.01%) +30k (+ 0.01%) 548,521k 548,724k
Parse Time 4.59s (± 0.32%) 4.57s (± 0.26%) -0.02s (- 0.40%) 4.56s 4.59s
Bind Time 1.71s (± 0.88%) 1.72s (± 0.77%) +0.01s (+ 0.49%) 1.71s 1.74s
Check Time 2.73s (± 0.79%) 2.74s (± 0.93%) +0.00s (+ 0.12%) 2.70s 2.77s
Emit Time 0.09s (± 5.95%) 0.08s (± 6.19%) 🟩-0.00s (- 3.85%) 0.08s 0.09s
Total Time 9.14s (± 0.36%) 9.12s (± 0.38%) -0.02s (- 0.26%) 9.07s 9.17s
Angular - node (v16.17.1, x64)
Memory used 359,224k (± 0.01%) 359,218k (± 0.01%) -6k (- 0.00%) 359,193k 359,261k
Parse Time 4.18s (± 0.36%) 4.18s (± 0.28%) +0.00s (+ 0.12%) 4.17s 4.20s
Bind Time 1.22s (± 0.33%) 1.23s (± 0.66%) +0.00s (+ 0.41%) 1.22s 1.24s
Check Time 9.40s (± 0.45%) 9.41s (± 0.28%) +0.01s (+ 0.05%) 9.38s 9.45s
Emit Time 8.07s (± 0.53%) 8.06s (± 0.59%) -0.01s (- 0.10%) 7.99s 8.12s
Total Time 22.87s (± 0.30%) 22.88s (± 0.28%) +0.01s (+ 0.03%) 22.78s 22.97s
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,247k (± 0.04%) 194,762k (± 0.70%) +516k (+ 0.27%) 194,143k 197,559k
Parse Time 1.80s (± 0.58%) 1.81s (± 0.54%) +0.00s (+ 0.18%) 1.80s 1.82s
Bind Time 0.84s (± 1.24%) 0.84s (± 0.99%) 0.00s ( 0.00%) 0.83s 0.85s
Check Time 10.34s (± 0.67%) 10.38s (± 0.63%) +0.04s (+ 0.39%) 10.31s 10.50s
Emit Time 3.04s (± 0.61%) 3.05s (± 1.44%) +0.01s (+ 0.27%) 3.00s 3.12s
Total Time 16.04s (± 0.53%) 16.08s (± 0.64%) +0.04s (+ 0.28%) 16.00s 16.28s
Monaco - node (v16.17.1, x64)
Memory used 343,248k (± 0.00%) 343,248k (± 0.00%) 0k ( 0.00%) 343,235k 343,271k
Parse Time 3.17s (± 0.61%) 3.18s (± 1.40%) +0.01s (+ 0.32%) 3.11s 3.24s
Bind Time 1.12s (± 0.56%) 1.12s (± 0.49%) -0.00s (- 0.45%) 1.11s 1.12s
Check Time 7.74s (± 0.68%) 7.69s (± 0.42%) -0.04s (- 0.58%) 7.64s 7.73s
Emit Time 4.53s (± 0.40%) 4.53s (± 0.92%) +0.01s (+ 0.11%) 4.48s 4.59s
Total Time 16.55s (± 0.38%) 16.52s (± 0.41%) -0.03s (- 0.21%) 16.44s 16.64s
TFS - node (v16.17.1, x64)
Memory used 299,776k (± 0.01%) 299,774k (± 0.01%) -2k (- 0.00%) 299,749k 299,810k
Parse Time 2.48s (± 1.97%) 2.48s (± 1.21%) +0.01s (+ 0.40%) 2.44s 2.52s
Bind Time 1.26s (± 0.32%) 1.26s (± 0.60%) -0.00s (- 0.26%) 1.25s 1.27s
Check Time 7.18s (± 0.31%) 7.19s (± 0.31%) +0.02s (+ 0.21%) 7.16s 7.22s
Emit Time 4.22s (± 0.56%) 4.21s (± 0.40%) -0.01s (- 0.24%) 4.19s 4.23s
Total Time 15.13s (± 0.46%) 15.15s (± 0.34%) +0.01s (+ 0.09%) 15.08s 15.23s
material-ui - node (v16.17.1, x64)
Memory used 476,099k (± 0.02%) 476,058k (± 0.01%) -41k (- 0.01%) 476,021k 476,152k
Parse Time 3.72s (± 0.28%) 3.73s (± 0.47%) +0.01s (+ 0.31%) 3.71s 3.76s
Bind Time 1.02s (± 0.40%) 1.02s (± 0.40%) 0.00s ( 0.00%) 1.01s 1.02s
Check Time 18.10s (± 0.41%) 18.07s (± 0.16%) -0.03s (- 0.15%) 18.04s 18.11s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.83s (± 0.32%) 22.81s (± 0.20%) -0.02s (- 0.09%) 22.77s 22.89s
xstate - node (v16.17.1, x64)
Memory used 546,284k (± 0.01%) 546,322k (± 0.02%) +37k (+ 0.01%) 546,156k 546,492k
Parse Time 4.76s (± 0.44%) 4.77s (± 0.30%) +0.01s (+ 0.21%) 4.75s 4.79s
Bind Time 1.83s (± 0.57%) 1.78s (± 5.31%) 🟩-0.06s (- 3.18%) 1.65s 1.84s
Check Time 2.96s (± 0.66%) 3.02s (± 2.57%) +0.06s (+ 2.20%) 2.97s 3.16s
Emit Time 0.09s (± 4.45%) 0.09s (± 4.45%) 0.00s ( 0.00%) 0.09s 0.10s
Total Time 9.64s (± 0.52%) 9.67s (± 0.37%) +0.02s (+ 0.21%) 9.60s 9.71s
Angular - node (v14.15.1, x64)
Memory used 352,840k (± 0.01%) 352,833k (± 0.01%) -8k (- 0.00%) 352,790k 352,870k
Parse Time 4.24s (± 0.47%) 4.25s (± 0.63%) +0.01s (+ 0.16%) 4.22s 4.29s
Bind Time 1.28s (± 0.49%) 1.29s (± 0.40%) +0.01s (+ 0.52%) 1.28s 1.29s
Check Time 9.71s (± 0.46%) 9.74s (± 0.44%) +0.02s (+ 0.22%) 9.68s 9.80s
Emit Time 8.40s (± 0.65%) 8.41s (± 0.39%) +0.02s (+ 0.18%) 8.37s 8.46s
Total Time 23.63s (± 0.35%) 23.68s (± 0.32%) +0.05s (+ 0.20%) 23.58s 23.76s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,144k (± 0.05%) 189,214k (± 0.07%) +70k (+ 0.04%) 189,063k 189,361k
Parse Time 1.85s (± 1.05%) 1.84s (± 0.95%) -0.01s (- 0.36%) 1.82s 1.87s
Bind Time 0.86s (± 0.73%) 0.86s (± 0.87%) +0.00s (+ 0.19%) 0.85s 0.87s
Check Time 10.40s (± 0.35%) 10.46s (± 0.60%) +0.06s (+ 0.61%) 10.40s 10.57s
Emit Time 3.43s (± 3.73%) 3.31s (± 5.93%) 🟩-0.11s (- 3.35%) 3.13s 3.57s
Total Time 16.54s (± 0.74%) 16.48s (± 1.14%) -0.05s (- 0.32%) 16.26s 16.72s
Monaco - node (v14.15.1, x64)
Memory used 338,030k (± 0.00%) 338,031k (± 0.00%) +1k (+ 0.00%) 338,008k 338,053k
Parse Time 3.26s (± 1.28%) 3.23s (± 1.03%) -0.03s (- 0.92%) 3.20s 3.28s
Bind Time 1.12s (± 1.22%) 1.12s (± 1.04%) +0.00s (+ 0.15%) 1.11s 1.14s
Check Time 8.05s (± 0.70%) 8.08s (± 0.52%) +0.02s (+ 0.29%) 8.05s 8.16s
Emit Time 4.78s (± 0.67%) 4.83s (± 0.88%) +0.05s (+ 1.05%) 4.76s 4.89s
Total Time 17.21s (± 0.73%) 17.25s (± 0.48%) +0.04s (+ 0.25%) 17.16s 17.38s
TFS - node (v14.15.1, x64)
Memory used 294,550k (± 0.01%) 294,540k (± 0.00%) -10k (- 0.00%) 294,518k 294,557k
Parse Time 2.75s (± 0.82%) 2.76s (± 0.85%) +0.00s (+ 0.06%) 2.72s 2.79s
Bind Time 1.10s (± 1.28%) 1.11s (± 0.93%) +0.01s (+ 0.61%) 1.09s 1.12s
Check Time 7.50s (± 0.38%) 7.47s (± 0.25%) -0.04s (- 0.51%) 7.44s 7.49s
Emit Time 4.62s (± 0.51%) 4.63s (± 0.29%) +0.01s (+ 0.32%) 4.61s 4.65s
Total Time 15.98s (± 0.33%) 15.96s (± 0.25%) -0.01s (- 0.06%) 15.91s 16.02s
material-ui - node (v14.15.1, x64)
Memory used 471,569k (± 0.00%) 471,565k (± 0.00%) -5k (- 0.00%) 471,548k 471,574k
Parse Time 3.93s (± 0.55%) 3.94s (± 0.67%) +0.02s (+ 0.42%) 3.91s 3.98s
Bind Time 1.04s (± 0.52%) 1.05s (± 0.85%) +0.01s (+ 0.48%) 1.04s 1.06s
Check Time 18.99s (± 0.28%) 19.10s (± 0.76%) +0.11s (+ 0.59%) 18.91s 19.29s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 23.96s (± 0.28%) 24.09s (± 0.69%) +0.13s (+ 0.54%) 23.87s 24.31s
xstate - node (v14.15.1, x64)
Memory used 534,473k (± 0.01%) 534,485k (± 0.01%) +11k (+ 0.00%) 534,438k 534,546k
Parse Time 5.14s (± 0.47%) 5.18s (± 0.91%) +0.04s (+ 0.78%) 5.13s 5.25s
Bind Time 1.72s (± 0.82%) 1.72s (± 0.79%) +0.00s (+ 0.19%) 1.70s 1.74s
Check Time 3.10s (± 0.86%) 3.10s (± 0.50%) +0.00s (+ 0.11%) 3.09s 3.13s
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) 0.00s ( 0.00%) 0.10s 0.10s
Total Time 10.05s (± 0.56%) 10.11s (± 0.61%) +0.05s (+ 0.51%) 10.04s 10.17s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52181 6
Baseline main 6

TSServer

Comparison Report - main..52181
Metric main 52181 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,515ms (± 1.22%) 2,533ms (± 1.26%) +19ms (+ 0.74%) 2,485ms 2,569ms
Req 2 - geterr 5,505ms (± 0.51%) 5,465ms (± 0.13%) -40ms (- 0.73%) 5,457ms 5,474ms
Req 3 - references 364ms (± 1.25%) 366ms (± 0.93%) +2ms (+ 0.50%) 361ms 370ms
Req 4 - navto 284ms (± 0.82%) 287ms (± 0.43%) +3ms (+ 1.00%) 285ms 288ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 66ms (± 1.14%) 67ms (± 3.21%) +2ms (+ 2.28%) 65ms 70ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,723ms (± 0.83%) 2,717ms (± 0.71%) -6ms (- 0.21%) 2,698ms 2,745ms
Req 2 - geterr 4,054ms (± 0.24%) 4,063ms (± 0.37%) +9ms (+ 0.22%) 4,042ms 4,081ms
Req 3 - references 368ms (± 1.46%) 369ms (± 0.47%) +1ms (+ 0.23%) 366ms 371ms
Req 4 - navto 297ms (± 0.39%) 295ms (± 1.00%) -2ms (- 0.73%) 291ms 300ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 79ms (± 7.75%) 78ms (± 8.93%) -1ms (- 0.84%) 66ms 84ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,490ms (± 0.59%) 3,486ms (± 0.23%) -4ms (- 0.12%) 3,474ms 3,495ms
Req 2 - geterr 1,414ms (± 0.85%) 1,431ms (± 1.12%) +17ms (+ 1.19%) 1,408ms 1,447ms
Req 3 - references 105ms (± 2.41%) 105ms (± 1.90%) 0ms ( 0.00%) 103ms 108ms
Req 4 - navto 355ms (± 0.56%) 356ms (± 0.43%) +1ms (+ 0.14%) 353ms 357ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 469ms (± 1.12%) 466ms (± 1.13%) -2ms (- 0.50%) 459ms 475ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,782ms (± 0.95%) 2,767ms (± 0.99%) -15ms (- 0.53%) 2,725ms 2,796ms
Req 2 - geterr 5,872ms (± 0.51%) 5,869ms (± 0.35%) -3ms (- 0.06%) 5,841ms 5,890ms
Req 3 - references 377ms (± 1.64%) 374ms (± 0.84%) -3ms (- 0.71%) 369ms 378ms
Req 4 - navto 278ms (± 0.62%) 280ms (± 0.60%) +2ms (+ 0.66%) 277ms 282ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 73ms (± 5.29%) 78ms (± 9.60%) +5ms (+ 6.82%) 71ms 88ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,926ms (± 0.41%) 2,953ms (± 0.77%) +27ms (+ 0.93%) 2,928ms 2,989ms
Req 2 - geterr 4,399ms (± 0.19%) 4,410ms (± 0.42%) +11ms (+ 0.25%) 4,379ms 4,434ms
Req 3 - references 378ms (± 0.71%) 379ms (± 0.59%) +1ms (+ 0.31%) 375ms 381ms
Req 4 - navto 288ms (± 0.42%) 287ms (± 0.78%) -2ms (- 0.58%) 283ms 289ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 71ms (± 1.70%) 72ms (± 1.24%) +1ms (+ 0.93%) 71ms 73ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,635ms (± 0.37%) 3,632ms (± 0.17%) -3ms (- 0.08%) 3,622ms 3,641ms
Req 2 - geterr 1,556ms (± 0.55%) 1,560ms (± 0.85%) +4ms (+ 0.27%) 1,551ms 1,586ms
Req 3 - references 112ms (± 0.92%) 111ms (± 1.69%) -2ms (- 1.63%) 108ms 113ms
Req 4 - navto 341ms (± 0.82%) 343ms (± 1.64%) +2ms (+ 0.49%) 337ms 349ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 478ms (± 0.78%) 480ms (± 1.03%) +2ms (+ 0.42%) 474ms 486ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,909ms (± 0.32%) 2,908ms (± 0.25%) -1ms (- 0.03%) 2,896ms 2,916ms
Req 2 - geterr 6,273ms (± 0.72%) 6,276ms (± 0.69%) +3ms (+ 0.04%) 6,214ms 6,334ms
Req 3 - references 390ms (± 0.99%) 390ms (± 0.68%) -1ms (- 0.21%) 386ms 394ms
Req 4 - navto 284ms (± 1.33%) 285ms (± 1.10%) +0ms (+ 0.06%) 282ms 289ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 85ms (± 9.58%) 84ms (± 7.26%) -1ms (- 0.59%) 73ms 88ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,080ms (± 0.57%) 3,084ms (± 0.97%) +4ms (+ 0.12%) 3,060ms 3,141ms
Req 2 - geterr 4,699ms (± 0.17%) 4,701ms (± 0.38%) +2ms (+ 0.05%) 4,677ms 4,727ms
Req 3 - references 403ms (± 0.46%) 404ms (± 0.38%) +1ms (+ 0.29%) 402ms 406ms
Req 4 - navto 293ms (± 1.05%) 296ms (± 2.54%) +3ms (+ 0.97%) 290ms 311ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 82ms (± 4.01%) 84ms (± 4.87%) +2ms (+ 2.66%) 79ms 88ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,975ms (± 0.31%) 3,971ms (± 0.20%) -5ms (- 0.11%) 3,959ms 3,980ms
Req 2 - geterr 1,523ms (± 1.69%) 1,508ms (± 0.62%) -16ms (- 1.02%) 1,490ms 1,516ms
Req 3 - references 132ms (± 3.17%) 133ms (± 2.60%) +1ms (+ 0.63%) 126ms 136ms
Req 4 - navto 374ms (± 0.44%) 374ms (± 0.43%) +0ms (+ 0.09%) 372ms 376ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 505ms (± 2.33%) 506ms (± 1.95%) +1ms (+ 0.16%) 488ms 516ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52181 6
Baseline main 6

Startup

Comparison Report - main..52181
Metric main 52181 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 142.59ms (± 0.19%) 142.24ms (± 0.22%) -0.35ms (- 0.24%) 141.47ms 147.02ms
tsserver-startup - node (v16.17.1, x64)
Execution time 226.96ms (± 0.29%) 226.53ms (± 0.24%) -0.43ms (- 0.19%) 224.98ms 232.82ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 229.06ms (± 0.27%) 231.09ms (± 0.39%) +2.03ms (+ 0.89%) 227.77ms 237.90ms
typescript-startup - node (v16.17.1, x64)
Execution time 209.40ms (± 0.16%) 212.04ms (± 0.36%) +2.63ms (+ 1.26%) 208.84ms 217.88ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52181 6
Baseline main 6

Developer Information:

Download Benchmark

andrewbranch
andrewbranch approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, though it looks like it probably doesn’t improve performance for programs that aren’t just hundreds of thousands of lines of awaiting bigint literals 😛

@andrewbranch andrewbranch merged commit 8fd1308 into microsoft:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andarist @typescript-bot @andrewbranch