Skip to content

(fix #50725, #50710) add file extensions in import statements #51702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 6, 2022
Merged

(fix #50725, #50710) add file extensions in import statements #51702

merged 7 commits into from
Dec 6, 2022

Conversation

iisaduan
Copy link
Member

Fixes #50725
Fixes #50710

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Nov 30, 2022
@iisaduan iisaduan changed the title Fix50725 (fix #50725, #50710) add file extensions in import statements Nov 30, 2022
@andrewbranch andrewbranch mentioned this pull request Dec 2, 2022
Closed
andrewbranch
andrewbranch approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest a couple simplifications, but as I was reading through the code I think I spotted some other unrelated bugs that will run up against those simplifications. I suggest we merge this and then pair on a quick follow-up.

@iisaduan iisaduan merged commit ae9c671 into microsoft:main Dec 6, 2022
@iisaduan iisaduan deleted the fix50725 branch December 6, 2022 17:28
@andrewbranch andrewbranch mentioned this pull request Dec 7, 2022
Merged
@SamB
Copy link

SamB commented Mar 2, 2023

Well, by reading the patch I learned that "*.preferences.importModuleSpecifierEnding" doesn't work with "moduleResolution": "classic" (and that the default "moduleResolution" is difficult to predict; I think the documentation for that didn't get updated when some values were added for "module" ...?) ... well, anyway, adding an explicit "moduleResolution" that wasn't "classic" made (symbol) completion stop trying to import my .js files without the .js, so I'm happy.

@andrewbranch andrewbranch mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees

@iisaduan iisaduan

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
4 participants
@iisaduan @SamB @andrewbranch @typescript-bot