Skip to content

Remove reverse mapping const enums on preserveConstEnums #51012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dorilahav
Copy link

Makes it so const enums will not reverse map when using preserveConstEnums.
Fixes #37282

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 30, 2022
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #37282. If you can get it accepted, this PR will have a better chance of being reviewed.

@dorilahav
Copy link
Author

@microsoft-github-policy-service agree

@RyanCavanaugh RyanCavanaugh marked this pull request as draft September 30, 2022 17:56
@RyanCavanaugh
Copy link
Member

Marking as draft. The linked issue is not an approved change; we will not be reviewing this.

@sandersn
Copy link
Member

I'm closing this PR because it is stale and the original issue hasn't been accepted. If the original issue is accepted, we can revisit the PR to see if any of the code is still usable.

@sandersn sandersn closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't emit const enums with reverse mapping (under preserveConstEnum)
4 participants