Support overriding the types of a set of JSON files #50095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
reviewed
Jul 30, 2022
| "File '/hello.locstring.json.ts' does not exist.", | ||
| "File '/hello.locstring.json.tsx' does not exist.", | ||
| "File '/hello.locstring.json.d.ts' exist - use it as a name resolution result.", | ||
| "======== Module name './hello.locstring.json' was successfully resolved to '/hello.locstring.json.d.ts'. ========" |
There was a problem hiding this comment.
would the same be true for .d.ts contained in node_modules? would .d.ts from node_modules "win" over the local override?
weswigham
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Right, so ambient module declarations for relative imports are.... weird, and I don't really like them, since we don't do anything like that today. I thought in the original issue the problem was with non-relative imports, but no - you can use ambient modules for those. Moreover, we now support .d.json.ts files that you can drop alongside the .json to override their type - this has to be done file-by-file, rather than a pattern; but I don't think that's a massive loss. Given that, I'm going to close this. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49703