Skip to content

Reuse type reference directive resolutions #49750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2022
Merged

Reuse type reference directive resolutions #49750

merged 2 commits into from
Nov 7, 2022

Conversation

sheetalkamat
Copy link
Member

Builds on top of #49738 to reuse type reference directive resolutions

@sheetalkamat sheetalkamat requested a review from weswigham June 30, 2022 23:41
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 30, 2022
Base automatically changed from partialModuleResolutionReuse to main November 7, 2022 19:51
@weswigham
Copy link
Member

@sheetalkamat think this needs a sync now that the other PR is merged~

@sheetalkamat
Copy link
Member Author

@weswigham yes working on it.

@sheetalkamat sheetalkamat force-pushed the typeRefDirectiveReuse branch from 21b2d0b to a9e619c Compare November 7, 2022 20:58
@sheetalkamat
Copy link
Member Author

@weswigham done. Ready to review again

weswigham
weswigham approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We at least document the parameters to this function in our API, since which types for which parameters are "modern" and "preferred" probably isn't immediately obvious anymore at this point.

@sheetalkamat sheetalkamat merged commit 48aebcd into main Nov 7, 2022
@sheetalkamat sheetalkamat deleted the typeRefDirectiveReuse branch November 7, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @weswigham @typescript-bot