Ensure resolved signature is cached before processing call errors #49598
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
|
@typescript-bot test this |
|
Heya @jakebailey, I've started to run the extended test suite on this PR at a65ebb2. You can monitor the build here. |
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at a65ebb2. You can monitor the build here. |
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at a65ebb2. You can monitor the build here. Update: The results are in! |
|
@jakebailey |
|
Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
|
RWC shows one change, and it looks to me like an extra error that shouldn't have been there in the first place (an assignment error where it complains both on the right side, then again on the left side about the same thing), so that seems good. |
Fixes #48636
Big thanks to @weswigham for sitting with me for 2 hours to debug this.
I couldn't move the caching code from
resolvedSignaturedown intoresolveCall;getResolvedSignatureconditionally setsresolvedSignaturebefore callingresolveSignature, andresolveSignaturethen calls a bunch of other functions which do other things before actually resolving the signature. If I move this caching downward where it seems like it should be, I break enough tests to crash the test host.