-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Properly re-scan >
token in type argument list determination logic
#49560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot test this |
Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at f1f6af8. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f1f6af8. You can monitor the build here. |
Heya @ahejlsberg, I've started to run the extended test suite on this PR at f1f6af8. You can monitor the build here. |
@ahejlsberg |
Should we cherry-pick this? Feels bad to have in 4.7. |
Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
Yeah, I'd be in favor of cherry-picking. |
@typescript-bot cherry-pick this to release-4.7 |
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.7 manually. |
…49560) * Properly re-scan '>' token in type argument list determination logic * Add regression test
Fixes #49551.