fix #49235 Objects that pass the spread syntax can no longer be assigned to assignable types. #49337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Jun 9, 2022
src/compiler/checker.ts
Outdated
| return type.flags & TypeFlags.Intersection | ||
| ? every((type as IntersectionType).types, isObjectTypeWithInferableIndex) | ||
| : !!( | ||
| type.symbol | ||
| && (type.symbol.flags & (SymbolFlags.ObjectLiteral | SymbolFlags.TypeLiteral | SymbolFlags.Enum | SymbolFlags.ValueModule)) !== 0 | ||
| && !(type.symbol.flags & SymbolFlags.Class) | ||
| && !typeHasCallOrConstructSignatures(type) | ||
| ) || !!( | ||
| objectFlags |
There was a problem hiding this comment.
getObjectFlags always returns a value, so you don't need to check for undefined (or 0)
src/compiler/checker.ts
Outdated
| return type.flags & TypeFlags.Intersection | ||
| ? every((type as IntersectionType).types, isObjectTypeWithInferableIndex) | ||
| : !!( | ||
| type.symbol | ||
| && (type.symbol.flags & (SymbolFlags.ObjectLiteral | SymbolFlags.TypeLiteral | SymbolFlags.Enum | SymbolFlags.ValueModule)) !== 0 | ||
| && !(type.symbol.flags & SymbolFlags.Class) | ||
| && !typeHasCallOrConstructSignatures(type) | ||
| ) || !!( | ||
| objectFlags | ||
| && objectFlags & ObjectFlags.ObjectRestType | ||
| ) || !!(getObjectFlags(type) & ObjectFlags.ReverseMapped && isObjectTypeWithInferableIndex((type as ReverseMappedType).source)); |
There was a problem hiding this comment.
Can you replace getObjectFlags(type) with objectFlags here too? getObjectFlags is likely to be inlined, so you could also call it from each place.
|
@sandersn I have made updates accordingly, thank you for the review :) |
gabritto
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49235