Add es2018.intl ref to es2020.intl #49152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es2020.intl refers to NumberFormatPartTypes declared in es2018.intl as of #46508.
I'm not sure how to test this; it repros on Definitely Typed in types/ndarray, but when I copy the same files into a compiler test it passes without a problem.
Fixes 3 test failures on DT's overnight run.
Edit: The most recent commit adds a tests to show that the lib change does what it should. But it doesn't show that the bug is fixed -- just that
Intl.NumberFormatPartTypes
is resolved in a file with/// <reference lib="esnext.bigint" />
.