Skip to content

implementation and test for SolutionBuilderAsync functionality #48920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

craigphicks
Copy link

@craigphicks craigphicks commented May 2, 2022

Date: Mon May 2 12:07:52 2022 -0700

On branch sol-build-async
Changes to be committed:
new file: src/compiler/tsbuildPublicAsync.ts
modified: src/compiler/tsconfig.json
modified: src/testRunner/tsconfig.json
new file: src/testRunner/unittests/tsbuildWatch/publicApiAsync.ts
modified: src/testRunner/unittests/tscWatch/helpers.ts
new file: tests/baselines/reference/tsbuildWatch/publicApiAsync/with-custom-transformers.js

Feature described in #48894

 Date:      Mon May 2 12:07:52 2022 -0700

 On branch sol-build-async
 Changes to be committed:
	new file:   src/compiler/tsbuildPublicAsync.ts
	modified:   src/compiler/tsconfig.json
	modified:   src/testRunner/tsconfig.json
	new file:   src/testRunner/unittests/tsbuildWatch/publicApiAsync.ts
	modified:   src/testRunner/unittests/tscWatch/helpers.ts
	new file:   tests/baselines/reference/tsbuildWatch/publicApiAsync/with-custom-transformers.js
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 2, 2022
@ghost
Copy link

ghost commented May 2, 2022

CLA assistant check
All CLA requirements met.

@craigphicks
Copy link
Author

@sheetalkamat - Hi. I know you are really busy but since your are the creator of SolutionBuilder etc, any high level guidance on this topic would be extremely valuable. Proposal is in #48894.

@craigphicks
Copy link
Author

I'll close this pull for now because src/compiler/publicAPI.ts is undergoing a lot of changes with respect to package.json type resolution. Those change will have to be incorporated in to an updated pull.

@craigphicks craigphicks closed this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants