When building projects in watch mode, only schedule projects that need build or need update to bundle #48865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
andrewbranch
reviewed
May 5, 2022
tests/baselines/reference/tscWatch/watchEnvironment/watchFile/using-dynamic-priority-polling.js
Show resolved
Hide resolved
|
@andrewbranch can you please review.. would like to get this in early for 4.8 |
| while (state.projectPendingBuild.size) { | ||
| // If already scheduled, skip | ||
| if (state.timerToBuildInvalidatedProject) return; | ||
| // Before scheduling check if the next project needs build | ||
| const info = getNextInvalidatedProjectCreateInfo(state, buildOrder, /*reportQueue*/ false); | ||
| if (!info) break; // Nothing to build any more | ||
| if (info.kind !== InvalidatedProjectKind.UpdateOutputFileStamps) { | ||
| if (info.kind !== InvalidatedProjectKind.UpdateOutputFileStamps && (changeDetected || projectsBuilt === 5)) { |
There was a problem hiding this comment.
How did you choose 5? What’s the advantage of having a delay between groups at all? (Is it so there are points where the operation can be canceled if a new change comes in?)
There was a problem hiding this comment.
I assumed that on an average the change to build 5 projects might be couple of seconds or less and that would be good time to check if there is new change...
Without adding delay, we wont be able to check if new change is detected and cancel existing chain of build
andrewbranch
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we use to build single project at 250ms and the next project build or project time stamp updates happened after another 250ms. Now only build and update bundle is scheduled with reduced time gap (100ms) and update timestamps happens right after project build
Fixes #48187