Instantiate conditional types when providing conditional types #48823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46310
The problem was that in this case there are no inference candidates AND logic is somewhat sensitive to where you put a conditional type in your declaration, see the diff that "magically" make it works:
So why the repro case doesn't work and why this workaround works? The problem is that within
getApparentTypeOfContextualType
the call toinstantiateContextualType
doesn't touch this conditional type anyhow (again, cause there are no inference candidates gathered before hand) but themapType(instantiatedType, getApparentType, /*noReductions*/ true);
callsgetBaseConstraintOfType(type)
and that is returning union like this:So the function becomes non-inferrable from that in the same way as in here:
When we use a workaround (moving conditional type further down the road):
Then it becomes:
It's a single signature, it's returned fine from
getContextualSignature
and thencontextuallyCheckFunctionExpressionOrObjectLiteralMethod
is able to infer from it usinginferFromAnnotatedParameters
+instantiateSignature
(and thus resolve this default param, even though there is no candidate for it)