fix(48540): Extract to typedef from (invalid) type with comments in JS file causes assertion failure #48545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
requested changes
Apr 4, 2022
Comment on lines
258
to
266
| switch (node.kind) { | ||
| case SyntaxKind.UnionType: | ||
| members = (node as UnionTypeNode).types; | ||
| break; | ||
|
|
||
| case SyntaxKind.TypeLiteral: | ||
| members = (node as TypeLiteralNode).members; | ||
| break; | ||
| } |
There was a problem hiding this comment.
I think this fix is too limited - we really have to remove the comments deeply from every type.
There was a problem hiding this comment.
I make changes to support removing comments from node's descendants, I am not sure which other types need to be removed or is there a better way to do it?
rbuckton
previously requested changes
Apr 5, 2022
| @@ -229,6 +229,8 @@ namespace ts.refactor { | |||
| function doTypedefChange(changes: textChanges.ChangeTracker, file: SourceFile, name: string, info: ExtractInfo) { | |||
| const { firstStatement, selection, typeParameters } = info; | |||
|
|
|||
| removeCommentsFromTypeNode(selection); | |||
There was a problem hiding this comment.
Would setting EmitFlags.NoComments | EmitFlags.NoNestedComments work instead?
There was a problem hiding this comment.
that is definitely better 👍
DanielRosenwasser
approved these changes
Apr 5, 2022
DanielRosenwasser
dismissed
rbuckton’s stale review
Feedback should be addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48540