-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Remove calls of getNodeId
in compiler
outside of the checker
#46595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot perf test this |
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at e83d144. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test this faster |
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 044de3e. You can monitor the build here. Update: The results are in! |
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 044de3e. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test faster |
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 6f76b62. You can monitor the build here. |
@typescript-bot perf test faster |
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 5479adf. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test faster |
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at f9d2db3. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
getNodeId
in compiler
outside of the checker
Huh. @typescript-bot perf test this again to see whether that was a fluke. |
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at f9d2db3. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test faster |
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at cc38369. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test faster |
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at d42b2b7. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
eeaf78c
to
e23710a
Compare
@typescript-bot perf test faster |
Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at e23710a. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test this |
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at b7d31bc. You can monitor the build here. Update: The results are in! |
@DanielRosenwasser Here they are:Comparison Report - main..46595
System
Hosts
Scenarios
Developer Information: |
@DanielRosenwasser do you think this is likely to apply to Corsa as well? Do you remember if it was worthwhile at the time that you opened it? If neither are true, I'd like to close this PR. It's pretty old now. |
No description provided.