Avoid hard-wired build-tree paths #46414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
elibarzilay
force-pushed
the
find-up-dir
branch
from
d665958 to
78eac65
Compare
sandersn
approved these changes
Oct 18, 2021
Instead, search for stuff up the directory tree, with the main functionality being to look for `Gulpfile.js` and assume the resulting directory is the root. (Unfortunatley, this is implemented twice, one in `scripts` and another in `src`. It's not possible to use a single implementation for both since that would require assuming a directory structure which this is intended to avoid.) Also, in `scripts/build/projects.js`, abstracdt common exec functionality into a local helper, and use full paths based on the above search instead of assuming relative paths assuming CWD being in the project root.
elibarzilay
force-pushed
the
find-up-dir
branch
from
78eac65 to
c751428
Compare
elibarzilay
added a commit
to elibarzilay/TypeScript
that referenced
this pull request
Oct 26, 2021
Missed a bunch of stuff in microsoft#46414 (556098e).
elibarzilay
added a commit
to elibarzilay/TypeScript
that referenced
this pull request
Oct 28, 2021
Missed a bunch of stuff in microsoft#46414 (556098e).
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
Missed a bunch of stuff in microsoft#46414 (556098e).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, search for stuff up the directory tree, with the main
functionality being to look for
Gulpfile.jsand assume the resultingdirectory is the root.
(Unfortunatley, this is implemented twice, one in
scriptsand anotherin
src. It's not possible to use a single implementation for bothsince that would require assuming a directory structure which this is
intended to avoid.)
Also, in
scripts/build/projects.js, abstracdt common execfunctionality into a local helper, and use full paths based on the above
search instead of assuming relative paths assuming CWD being in the
project root.
Fixes #