Avoid bogus circularity error on context sensitive constructor property assignments #44601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
weswigham
force-pushed
the
constructor-property-assignments
branch
from
e5594e6 to
39d4a59
Compare
orta
approved these changes
Jun 15, 2021
src/compiler/checker.ts
Outdated
| } | ||
| return undefined; | ||
|
|
||
| function tryGetPrivateIdentifierPropertyOfType(type: Type, id: PrivateIdentifier) { |
There was a problem hiding this comment.
Why is this nested (it doesn't capture e) ?
There was a problem hiding this comment.
Just because it wasn't used outside of this function. :)
sandersn
requested changes
Jun 15, 2021
sandersn
reviewed
Jun 15, 2021
sandersn
requested changes
Jun 15, 2021
|
@sandersn done, there's now a JS test, and the code's been shuffled a bit to cover the JS case as well. |
sandersn
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44581