Tsserver tests can be baselined #44326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensures inferred and auto import projects have name per project service
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Can i get review on this so i can baseline #41004 on top of main after merging this. |
amcasey
approved these changes
Jun 2, 2021
| hasLevel: returnTrue, | ||
| loggingEnabled: returnTrue, | ||
| info: s => logger.logs.push( | ||
| s.replace(/Elapsed::?\s*\d+(?:\.\d+)?ms/g, "Elapsed:: *ms") |
There was a problem hiding this comment.
Is there some way we can detect that a baseline change includes something that looks like a duration and direct the author to this code? It seems like adding new log statements could be confusing otherwise (accept baselines locally, fail in CI, re-invent sanitization?).
There was a problem hiding this comment.
cant think of anything.. we do this in multiple places but in most cases i have realized it as part of just running tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensures inferred and auto import projects have name per project service so they are same across any type of runs
This is the PR I had started as part of #41004 and is partially done but nothing wrong with merging this without converting many more tests to baselines. That can be done as and when needed.