Don’t offer import statement completions at from position
#44125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
commented
May 17, 2021
| @@ -183,6 +185,20 @@ namespace ts.Completions { | |||
| return { isGlobalCompletion: false, isMemberCompletion: false, isNewIdentifierLocation: false, entries }; | |||
| } | |||
|
|
|||
| function specificKeywordCompletionInfo(keywords: readonly SyntaxKind[]): CompletionInfo { | |||
There was a problem hiding this comment.
Making a way to return specific keywords is extra credit beyond just fixing the obvious regression; the behavior in 4.2 was not great:
andrewbranch
commented
May 17, 2021
src/services/completions.ts
Outdated
| @@ -183,6 +185,20 @@ namespace ts.Completions { | |||
| return { isGlobalCompletion: false, isMemberCompletion: false, isNewIdentifierLocation: false, entries }; | |||
| } | |||
|
|
|||
| function specificKeywordCompletionInfo(keywords: readonly SyntaxKind[]): CompletionInfo { | |||
| return { | |||
| isGlobalCompletion: true, | |||
There was a problem hiding this comment.
I tried making this false but the snippets for for loops and stuff still showed up 🤔
There was a problem hiding this comment.
Should it be false then?
@mjbvz any idea why that might be happening?
There was a problem hiding this comment.
Set to false now despite seeing no difference locally
sheetalkamat
approved these changes
May 17, 2021
DanielRosenwasser
requested changes
May 17, 2021
|
@typescript-bot cherry-pick this to release-4.3 |
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
|
Hey @andrewbranch, I've opened #44136 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 17, 2021
DanielRosenwasser
approved these changes
May 18, 2021
andrewbranch
added a commit
that referenced
this pull request
May 18, 2021
Component commits: 34b80a5 Don’t offer import statement completions at `from` position afa4d05 Set isGlobalCompletion to false, use indexOf lookup Co-authored-by: Andrew Branch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Hoping to get this fix into for 4.3. The current state is pretty disruptive if your muscle memory expects a completion for
frombut you get an import completion instead.Fixes this:
By making it this: