-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Fixing JSX/TSX closing tag/attribute/expression formatting #4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
67878c9
adding tests for JSX attributes/closing bracket
saschanaz b8cbfcb
Merge https://github.com/Microsoft/TypeScript into formatTsxAttr
saschanaz 2677b3f
fixing autoformat not working with empty JsxText
saschanaz eae30fd
adding JSX closing tag/attribute/expression test
saschanaz 060828c
partially move getIndentationToken into new function
saschanaz 56fc7ec
revert 060828c
saschanaz 92e3b3b
remove isIndentPreventedChildNode
saschanaz c49c68d
Manual merge
saschanaz 74ef1b2
Merge https://github.com/Microsoft/TypeScript into formatTsxAttr
saschanaz 8bf79a2
Resolving conflicts with #4646
saschanaz e387f69
merge conflicts
saschanaz 593503f
move blocker to nodeWillIndentChild
saschanaz 9e3ee5d
remove whitespace
saschanaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text can not be zero-length, is there an example that would trigger this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhegazy I've found that this code blocks autoformatting:
<span>
won't be indented here because by some reason a zero-length JsxText node right before JsxElement node incorrectly sets indentation value to zero. An additionalrangeContainsStartEnd
check prevents this bug.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a parser bug then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe related to #4332?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4596 didn't fix this zero-length problem. CC: @vladima