Skip to content

fix(43939): Quick fix shouldn't be available for converting getters to async await #43944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

fix(43939): Quick fix shouldn't be available for converting getters to async await #43944

merged 1 commit into from
May 6, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #43939

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 4, 2021
@DanielRosenwasser
Copy link
Member

Doesn't this also allow setters? I would just limit it to arrow functions, function expressions, declarations, and method declarations.

@a-tarasyuk
Copy link
Contributor Author

@DanielRosenwasser oke

DanielRosenwasser
DanielRosenwasser approved these changes May 6, 2021
View reviewed changes
@DanielRosenwasser DanielRosenwasser merged commit e0d7703 into microsoft:master May 6, 2021
@DanielRosenwasser
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quick fix shouldn't be available for converting getters to async await
3 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot