Unwrap substitutions on conditional check types before comparing them #43888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43123
The outer conditional was creating a substitution on
[0]
, making it look like[0] & [0, any?]
at the inner conditional, which 1. didn't unwrap right (since we determine syntactically that we should be able to unwrap the tuple types made), and 2. produces a subtype of what the user actually wrote for the check type, which can alter results unexpectedly. By unwrapping substitutions at check type positions, we avoid this issue.