Resolve the decorator type as type and check if the symbol has value. #4386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would make sure we are referencing correct symbol to check if it has value Fixes #4239
| let rootSymbol = resolveName(root, root.text, SymbolFlags.Value, /*nameNotFoundMessage*/ undefined, /*nameArg*/ undefined); | ||
| if (rootSymbol && rootSymbol.flags & SymbolFlags.Alias && !isInTypeQuery(node) && !isConstEnumOrConstEnumOnlyModule(resolveAlias(rootSymbol))) { | ||
| markAliasSymbolAsReferenced(rootSymbol); | ||
| var meaning = root.parent.kind === SyntaxKind.TypeReference ? SymbolFlags.Type : SymbolFlags.Namespace; |
There was a problem hiding this comment.
not sure i understand this line.
There was a problem hiding this comment.
If it is M.Q then resolving M has to be like namespace. While if it is T , T need sto be resolved as type.
|
Please add more tests |
|
👍 but please add some more tests for the namespace/dotted name case. this area does not have enough coverage. |
…ource file This fixes issue of not being able to emit qualified expression correctly
…e resolved This could be true if expression cannot be resolved resulting in error
|
👍 |
sheetalkamat
added a commit
that referenced
this pull request
Aug 24, 2015
Resolve the decorator type as type and check if the symbol has value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would make sure we are referencing correct symbol to check if it has value
Fixes #4239