Skip to content

Only catalog types when tracing #43304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2021
Merged

Only catalog types when tracing #43304

merged 1 commit into from
Mar 19, 2021

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Mar 19, 2021

I suspect it's currently unconditional because we thought checking would be slower, but it might just be an oversight. Might as well measure.

@amcasey
Copy link
Member Author

amcasey commented Mar 19, 2021

@typescript-bot perf test this

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 19, 2021
@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 19, 2021 •
edited
Loading

Heya @amcasey, I've started to run the perf test suite on this PR at 9fd2b48. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@amcasey
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43304

Metric master 43304 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 348,665k (± 0.01%) 344,080k (± 0.02%) -4,585k (- 1.32%) 343,922k 344,221k
Parse Time 1.91s (± 0.70%) 1.92s (± 0.49%) +0.01s (+ 0.47%) 1.91s 1.94s
Bind Time 0.84s (± 1.33%) 0.83s (± 0.63%) -0.01s (- 0.60%) 0.82s 0.84s
Check Time 5.05s (± 0.75%) 5.06s (± 0.42%) +0.01s (+ 0.18%) 5.02s 5.12s
Emit Time 5.89s (± 0.23%) 5.91s (± 0.36%) +0.03s (+ 0.46%) 5.87s 5.97s
Total Time 13.69s (± 0.38%) 13.72s (± 0.33%) +0.04s (+ 0.26%) 13.65s 13.87s
Compiler-Unions - node (v10.16.3, x64)
Memory used 204,769k (± 0.12%) 204,030k (± 0.11%) -739k (- 0.36%) 203,145k 204,197k
Parse Time 0.78s (± 0.48%) 0.78s (± 0.94%) +0.00s (+ 0.39%) 0.77s 0.80s
Bind Time 0.53s (± 0.65%) 0.52s (± 0.69%) -0.00s (- 0.57%) 0.52s 0.53s
Check Time 7.45s (± 0.47%) 7.44s (± 0.43%) -0.01s (- 0.15%) 7.38s 7.51s
Emit Time 2.58s (± 0.83%) 2.58s (± 0.71%) -0.00s (- 0.12%) 2.54s 2.63s
Total Time 11.33s (± 0.29%) 11.32s (± 0.36%) -0.01s (- 0.09%) 11.25s 11.43s
Monaco - node (v10.16.3, x64)
Memory used 356,663k (± 0.02%) 342,369k (± 0.04%) 🟩-14,294k (- 4.01%) 342,088k 342,698k
Parse Time 1.56s (± 0.74%) 1.55s (± 0.48%) -0.01s (- 0.83%) 1.54s 1.57s
Bind Time 0.74s (± 0.70%) 0.73s (± 0.46%) -0.01s (- 0.81%) 0.73s 0.74s
Check Time 5.22s (± 0.57%) 5.18s (± 0.41%) -0.04s (- 0.80%) 5.13s 5.24s
Emit Time 3.13s (± 0.76%) 3.11s (± 0.45%) -0.02s (- 0.64%) 3.08s 3.14s
Total Time 10.66s (± 0.49%) 10.58s (± 0.25%) -0.08s (- 0.76%) 10.52s 10.64s
TFS - node (v10.16.3, x64)
Memory used 308,968k (± 0.01%) 304,158k (± 0.03%) -4,810k (- 1.56%) 304,006k 304,511k
Parse Time 1.21s (± 0.46%) 1.21s (± 0.63%) -0.00s (- 0.17%) 1.19s 1.22s
Bind Time 0.70s (± 0.68%) 0.70s (± 1.19%) -0.00s (- 0.14%) 0.67s 0.71s
Check Time 4.67s (± 0.50%) 4.66s (± 0.51%) -0.01s (- 0.17%) 4.62s 4.72s
Emit Time 3.26s (± 0.90%) 3.25s (± 1.30%) -0.01s (- 0.18%) 3.17s 3.37s
Total Time 9.83s (± 0.28%) 9.82s (± 0.59%) -0.02s (- 0.18%) 9.72s 10.01s
material-ui - node (v10.16.3, x64)
Memory used 502,351k (± 0.01%) 465,143k (± 0.01%) 🟩-37,208k (- 7.41%) 464,993k 465,248k
Parse Time 1.99s (± 0.63%) 1.98s (± 0.37%) -0.01s (- 0.65%) 1.96s 2.00s
Bind Time 0.65s (± 1.52%) 0.66s (± 1.50%) +0.01s (+ 1.54%) 0.64s 0.68s
Check Time 14.28s (± 0.55%) 14.21s (± 0.42%) -0.07s (- 0.52%) 14.10s 14.35s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.92s (± 0.49%) 16.84s (± 0.35%) -0.07s (- 0.44%) 16.73s 16.98s
Angular - node (v12.1.0, x64)
Memory used 326,246k (± 0.01%) 321,622k (± 0.08%) -4,624k (- 1.42%) 320,677k 321,894k
Parse Time 1.89s (± 0.46%) 1.90s (± 0.62%) +0.01s (+ 0.48%) 1.87s 1.92s
Bind Time 0.81s (± 0.82%) 0.81s (± 1.07%) -0.00s (- 0.25%) 0.79s 0.83s
Check Time 4.95s (± 0.62%) 4.96s (± 0.78%) +0.01s (+ 0.18%) 4.89s 5.09s
Emit Time 5.97s (± 0.71%) 5.98s (± 0.61%) +0.01s (+ 0.23%) 5.90s 6.08s
Total Time 13.62s (± 0.36%) 13.65s (± 0.46%) +0.03s (+ 0.22%) 13.54s 13.84s
Compiler-Unions - node (v12.1.0, x64)
Memory used 191,499k (± 0.08%) 190,653k (± 0.12%) -847k (- 0.44%) 189,733k 190,840k
Parse Time 0.77s (± 1.07%) 0.77s (± 0.96%) +0.00s (+ 0.39%) 0.76s 0.79s
Bind Time 0.52s (± 1.06%) 0.52s (± 1.24%) 0.00s ( 0.00%) 0.51s 0.53s
Check Time 6.97s (± 0.63%) 6.96s (± 0.59%) -0.02s (- 0.26%) 6.88s 7.08s
Emit Time 2.54s (± 1.05%) 2.57s (± 0.72%) +0.03s (+ 1.06%) 2.54s 2.60s
Total Time 10.81s (± 0.46%) 10.82s (± 0.48%) +0.02s (+ 0.16%) 10.72s 10.97s
Monaco - node (v12.1.0, x64)
Memory used 339,107k (± 0.02%) 324,611k (± 0.02%) 🟩-14,496k (- 4.27%) 324,459k 324,722k
Parse Time 1.54s (± 0.47%) 1.53s (± 0.81%) -0.01s (- 0.65%) 1.49s 1.55s
Bind Time 0.72s (± 1.03%) 0.72s (± 0.93%) -0.01s (- 0.83%) 0.71s 0.74s
Check Time 5.05s (± 0.55%) 5.03s (± 0.48%) -0.02s (- 0.38%) 4.98s 5.08s
Emit Time 3.11s (± 0.38%) 3.12s (± 0.85%) +0.02s (+ 0.51%) 3.05s 3.18s
Total Time 10.42s (± 0.38%) 10.40s (± 0.43%) -0.02s (- 0.14%) 10.30s 10.52s
TFS - node (v12.1.0, x64)
Memory used 293,214k (± 0.02%) 288,352k (± 0.02%) -4,863k (- 1.66%) 288,277k 288,508k
Parse Time 1.21s (± 0.62%) 1.20s (± 0.73%) -0.01s (- 0.82%) 1.19s 1.22s
Bind Time 0.69s (± 0.99%) 0.69s (± 1.31%) +0.00s (+ 0.73%) 0.68s 0.72s
Check Time 4.60s (± 0.53%) 4.59s (± 0.54%) -0.00s (- 0.02%) 4.53s 4.66s
Emit Time 3.15s (± 0.98%) 3.15s (± 0.73%) -0.01s (- 0.19%) 3.10s 3.20s
Total Time 9.64s (± 0.54%) 9.64s (± 0.41%) -0.01s (- 0.05%) 9.58s 9.78s
material-ui - node (v12.1.0, x64)
Memory used 480,324k (± 0.01%) 443,295k (± 0.01%) 🟩-37,029k (- 7.71%) 443,162k 443,411k
Parse Time 1.99s (± 0.48%) 1.99s (± 0.44%) +0.00s (+ 0.10%) 1.97s 2.00s
Bind Time 0.64s (± 0.70%) 0.63s (± 0.57%) -0.00s (- 0.63%) 0.63s 0.64s
Check Time 12.89s (± 0.60%) 12.78s (± 0.40%) -0.11s (- 0.85%) 12.65s 12.91s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.51s (± 0.54%) 15.40s (± 0.30%) -0.11s (- 0.73%) 15.28s 15.51s
Angular - node (v14.15.1, x64)
Memory used 324,974k (± 0.01%) 320,507k (± 0.01%) -4,467k (- 1.37%) 320,454k 320,556k
Parse Time 1.90s (± 0.56%) 1.90s (± 0.60%) +0.01s (+ 0.26%) 1.88s 1.93s
Bind Time 0.85s (± 0.61%) 0.85s (± 0.66%) -0.00s (- 0.35%) 0.84s 0.86s
Check Time 4.94s (± 0.43%) 4.92s (± 0.31%) -0.02s (- 0.40%) 4.89s 4.95s
Emit Time 6.25s (± 0.36%) 6.27s (± 0.37%) +0.02s (+ 0.30%) 6.20s 6.32s
Total Time 13.95s (± 0.26%) 13.94s (± 0.28%) -0.00s (- 0.01%) 13.82s 14.00s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,090k (± 0.02%) 190,396k (± 0.01%) -694k (- 0.36%) 190,326k 190,446k
Parse Time 0.80s (± 0.60%) 0.80s (± 0.62%) -0.00s (- 0.13%) 0.79s 0.81s
Bind Time 0.55s (± 0.54%) 0.55s (± 0.00%) -0.00s (- 0.36%) 0.55s 0.55s
Check Time 7.02s (± 0.34%) 7.01s (± 0.49%) -0.01s (- 0.17%) 6.96s 7.12s
Emit Time 2.54s (± 0.89%) 2.54s (± 0.78%) +0.01s (+ 0.24%) 2.50s 2.61s
Total Time 10.90s (± 0.30%) 10.89s (± 0.37%) -0.01s (- 0.08%) 10.83s 11.01s
Monaco - node (v14.15.1, x64)
Memory used 338,081k (± 0.00%) 323,609k (± 0.01%) 🟩-14,472k (- 4.28%) 323,580k 323,665k
Parse Time 1.55s (± 0.48%) 1.55s (± 0.61%) +0.00s (+ 0.19%) 1.54s 1.58s
Bind Time 0.75s (± 0.64%) 0.74s (± 0.50%) -0.00s (- 0.27%) 0.74s 0.75s
Check Time 4.95s (± 0.41%) 4.94s (± 0.36%) -0.01s (- 0.28%) 4.88s 4.96s
Emit Time 3.14s (± 0.69%) 3.16s (± 0.43%) +0.02s (+ 0.51%) 3.13s 3.18s
Total Time 10.39s (± 0.32%) 10.39s (± 0.20%) -0.00s (- 0.00%) 10.33s 10.43s
TFS - node (v14.15.1, x64)
Memory used 292,314k (± 0.01%) 287,478k (± 0.01%) -4,835k (- 1.65%) 287,442k 287,545k
Parse Time 1.26s (± 1.67%) 1.26s (± 1.77%) 0.00s ( 0.00%) 1.21s 1.33s
Bind Time 0.71s (± 0.83%) 0.71s (± 0.66%) -0.00s (- 0.56%) 0.70s 0.72s
Check Time 4.59s (± 0.48%) 4.57s (± 0.46%) -0.02s (- 0.46%) 4.54s 4.63s
Emit Time 3.24s (± 0.66%) 3.23s (± 0.53%) -0.01s (- 0.37%) 3.20s 3.27s
Total Time 9.80s (± 0.46%) 9.77s (± 0.42%) -0.04s (- 0.39%) 9.71s 9.89s
material-ui - node (v14.15.1, x64)
Memory used 478,375k (± 0.08%) 441,648k (± 0.00%) 🟩-36,727k (- 7.68%) 441,623k 441,662k
Parse Time 2.06s (± 0.56%) 2.06s (± 0.49%) -0.00s (- 0.05%) 2.03s 2.08s
Bind Time 0.69s (± 0.98%) 0.70s (± 0.96%) +0.00s (+ 0.43%) 0.68s 0.71s
Check Time 13.04s (± 1.11%) 12.97s (± 0.76%) -0.07s (- 0.54%) 12.84s 13.24s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.80s (± 0.91%) 15.73s (± 0.63%) -0.07s (- 0.44%) 15.60s 16.00s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-198-generic
Architecturex64
Available Memory16 GB
Available Memory4 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43304 10
Baseline master 10

Developer Information:

Download Benchmark

@amcasey amcasey marked this pull request as ready for review March 19, 2021 01:09
@amcasey
Copy link
Member Author

amcasey commented Mar 19, 2021

Perf improvement is substantial, so I guess it was just a bug.

@amcasey amcasey merged commit b925c16 into microsoft:master Mar 19, 2021
@amcasey amcasey deleted the TypeCatFlag branch March 19, 2021 16:59
@amcasey amcasey mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

Assignees

@amcasey amcasey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amcasey @typescript-bot @andrewbranch