Skip to content

Use yarn resolutions to inject nightly TS version across whole workspace in fabric test #42961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Feb 25, 2021

At least locally, this looks like it halves the size of the resulting docker image (I guess adding the dep locally in every package triggers a lot of undesirable dependency tree expansion), which should be more than enough to make it fit in the test runner's available disk space again.

Fixes #42875

@weswigham
Copy link
Member Author

@typescript-bot user test this

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 25, 2021
@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 25, 2021

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at f6a57f2. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 25, 2021
@weswigham weswigham merged commit 576bfbd into microsoft:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Community Test Suite Issues
2 participants