Skip to content

fix(42133): undefined[] converted to any[] in js #42662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2021
Merged

fix(42133): undefined[] converted to any[] in js #42662

merged 1 commit into from
Feb 12, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #42133

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 5, 2021
sandersn
sandersn approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice distinction between strict-null-checks on and off.

@DanielRosenwasser
Copy link
Member

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 3d54454. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 3d54454. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 3d54454. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 3d54454. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 3d54454. You can monitor the build here.

@sandersn
Copy link
Member

sandersn commented Feb 6, 2021

Since this is a 4.3 bug, let's hold this until after 4.2's RC period is over.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 6, 2021 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/95153/artifacts?artifactName=tgz&fileId=2C0A47B4D7DEBC1A492884834721775AFD32776BACDF93616BA9548C99D9056D02&fileName=/typescript-4.2.0-insiders.20210206.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..42662

Metric master 42662 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 345,596k (± 0.01%) 345,647k (± 0.02%) +51k (+ 0.01%) 345,490k 345,792k
Parse Time 1.93s (± 0.76%) 1.93s (± 0.65%) 0.00s ( 0.00%) 1.90s 1.95s
Bind Time 0.83s (± 1.16%) 0.83s (± 0.72%) -0.00s (- 0.36%) 0.82s 0.84s
Check Time 4.96s (± 0.64%) 4.98s (± 0.43%) +0.02s (+ 0.36%) 4.94s 5.03s
Emit Time 5.27s (± 0.81%) 5.29s (± 0.48%) +0.03s (+ 0.47%) 5.24s 5.36s
Total Time 12.98s (± 0.63%) 13.02s (± 0.37%) +0.04s (+ 0.30%) 12.92s 13.11s
Compiler-Unions - node (v10.16.3, x64)
Memory used 214,377k (± 0.08%) 214,432k (± 0.07%) +56k (+ 0.03%) 213,917k 214,694k
Parse Time 0.78s (± 0.61%) 0.78s (± 0.60%) +0.00s (+ 0.39%) 0.77s 0.79s
Bind Time 0.50s (± 1.45%) 0.50s (± 1.45%) 0.00s ( 0.00%) 0.49s 0.52s
Check Time 10.65s (± 0.55%) 10.68s (± 0.76%) +0.03s (+ 0.26%) 10.54s 10.89s
Emit Time 2.34s (± 1.94%) 2.37s (± 1.28%) +0.03s (+ 1.45%) 2.30s 2.46s
Total Time 14.27s (± 0.63%) 14.33s (± 0.58%) +0.06s (+ 0.42%) 14.17s 14.48s
Monaco - node (v10.16.3, x64)
Memory used 355,241k (± 0.03%) 355,269k (± 0.03%) +28k (+ 0.01%) 355,056k 355,482k
Parse Time 1.55s (± 0.50%) 1.56s (± 0.80%) +0.01s (+ 0.32%) 1.52s 1.58s
Bind Time 0.73s (± 1.04%) 0.72s (± 0.94%) -0.00s (- 0.14%) 0.71s 0.74s
Check Time 5.12s (± 0.66%) 5.12s (± 0.32%) +0.00s (+ 0.02%) 5.09s 5.16s
Emit Time 2.81s (± 1.08%) 2.80s (± 1.06%) -0.02s (- 0.60%) 2.74s 2.87s
Total Time 10.21s (± 0.44%) 10.19s (± 0.50%) -0.01s (- 0.14%) 10.09s 10.31s
TFS - node (v10.16.3, x64)
Memory used 308,147k (± 0.02%) 308,134k (± 0.04%) -13k (- 0.00%) 307,891k 308,472k
Parse Time 1.21s (± 0.55%) 1.21s (± 0.28%) -0.00s (- 0.25%) 1.20s 1.21s
Bind Time 0.68s (± 0.65%) 0.68s (± 0.69%) -0.00s (- 0.29%) 0.67s 0.69s
Check Time 4.60s (± 0.50%) 4.60s (± 0.67%) +0.00s (+ 0.09%) 4.52s 4.66s
Emit Time 2.96s (± 0.87%) 2.91s (± 1.09%) -0.05s (- 1.66%) 2.82s 2.98s
Total Time 9.45s (± 0.41%) 9.40s (± 0.55%) -0.05s (- 0.55%) 9.28s 9.52s
material-ui - node (v10.16.3, x64)
Memory used 495,587k (± 0.01%) 495,594k (± 0.01%) +7k (+ 0.00%) 495,412k 495,718k
Parse Time 1.98s (± 0.82%) 1.99s (± 0.48%) +0.01s (+ 0.35%) 1.96s 2.01s
Bind Time 0.66s (± 0.76%) 0.66s (± 0.91%) 0.00s ( 0.00%) 0.64s 0.67s
Check Time 14.04s (± 0.81%) 13.95s (± 0.49%) -0.09s (- 0.63%) 13.83s 14.11s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.68s (± 0.75%) 16.60s (± 0.45%) -0.08s (- 0.48%) 16.47s 16.76s
Angular - node (v12.1.0, x64)
Memory used 323,221k (± 0.01%) 323,180k (± 0.10%) -41k (- 0.01%) 321,870k 323,541k
Parse Time 1.91s (± 0.43%) 1.90s (± 0.69%) -0.01s (- 0.58%) 1.88s 1.93s
Bind Time 0.80s (± 0.93%) 0.80s (± 0.97%) -0.00s (- 0.13%) 0.78s 0.82s
Check Time 4.85s (± 0.53%) 4.89s (± 0.60%) +0.04s (+ 0.87%) 4.83s 4.97s
Emit Time 5.47s (± 1.46%) 5.46s (± 0.99%) -0.01s (- 0.26%) 5.38s 5.58s
Total Time 13.03s (± 0.54%) 13.05s (± 0.54%) +0.02s (+ 0.15%) 12.94s 13.24s
Compiler-Unions - node (v12.1.0, x64)
Memory used 199,817k (± 0.09%) 199,922k (± 0.04%) +106k (+ 0.05%) 199,775k 200,058k
Parse Time 0.77s (± 0.91%) 0.77s (± 0.58%) -0.00s (- 0.39%) 0.76s 0.78s
Bind Time 0.50s (± 0.80%) 0.50s (± 0.60%) -0.00s (- 0.60%) 0.49s 0.50s
Check Time 9.72s (± 0.92%) 9.81s (± 1.08%) +0.09s (+ 0.93%) 9.61s 10.01s
Emit Time 2.35s (± 1.50%) 2.36s (± 2.26%) +0.01s (+ 0.64%) 2.30s 2.50s
Total Time 13.34s (± 0.69%) 13.44s (± 1.00%) +0.10s (+ 0.76%) 13.19s 13.79s
Monaco - node (v12.1.0, x64)
Memory used 337,612k (± 0.03%) 337,539k (± 0.02%) -73k (- 0.02%) 337,354k 337,689k
Parse Time 1.53s (± 0.78%) 1.53s (± 0.69%) -0.00s (- 0.20%) 1.50s 1.55s
Bind Time 0.71s (± 0.85%) 0.70s (± 0.83%) -0.00s (- 0.28%) 0.69s 0.72s
Check Time 4.93s (± 0.80%) 4.92s (± 0.48%) -0.02s (- 0.39%) 4.88s 4.97s
Emit Time 2.87s (± 0.98%) 2.85s (± 0.58%) -0.02s (- 0.80%) 2.81s 2.88s
Total Time 10.05s (± 0.58%) 10.00s (± 0.37%) -0.05s (- 0.50%) 9.91s 10.10s
TFS - node (v12.1.0, x64)
Memory used 292,323k (± 0.02%) 292,395k (± 0.02%) +72k (+ 0.02%) 292,274k 292,564k
Parse Time 1.23s (± 0.56%) 1.23s (± 0.65%) +0.00s (+ 0.24%) 1.21s 1.25s
Bind Time 0.66s (± 0.68%) 0.65s (± 0.91%) -0.00s (- 0.61%) 0.64s 0.67s
Check Time 4.51s (± 0.56%) 4.53s (± 0.54%) +0.01s (+ 0.24%) 4.47s 4.57s
Emit Time 2.96s (± 1.94%) 2.95s (± 0.49%) -0.01s (- 0.37%) 2.93s 3.00s
Total Time 9.36s (± 0.80%) 9.36s (± 0.41%) +0.00s (+ 0.03%) 9.28s 9.43s
material-ui - node (v12.1.0, x64)
Memory used 472,781k (± 0.01%) 472,702k (± 0.05%) -79k (- 0.02%) 471,749k 473,021k
Parse Time 2.00s (± 0.82%) 2.00s (± 0.55%) -0.00s (- 0.05%) 1.98s 2.03s
Bind Time 0.64s (± 0.69%) 0.65s (± 0.77%) +0.00s (+ 0.47%) 0.64s 0.66s
Check Time 12.54s (± 0.61%) 12.64s (± 0.82%) +0.10s (+ 0.81%) 12.42s 12.87s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.19s (± 0.52%) 15.29s (± 0.69%) +0.10s (+ 0.68%) 15.08s 15.53s
Angular - node (v14.15.1, x64)
Memory used 321,864k (± 0.01%) 321,857k (± 0.01%) -7k (- 0.00%) 321,805k 321,895k
Parse Time 1.91s (± 0.49%) 1.91s (± 0.61%) +0.00s (+ 0.16%) 1.89s 1.95s
Bind Time 0.85s (± 0.53%) 0.85s (± 0.61%) +0.00s (+ 0.12%) 0.84s 0.86s
Check Time 4.85s (± 0.39%) 4.86s (± 0.69%) +0.01s (+ 0.12%) 4.80s 4.95s
Emit Time 5.47s (± 0.20%) 5.48s (± 0.63%) +0.01s (+ 0.18%) 5.42s 5.58s
Total Time 13.08s (± 0.15%) 13.10s (± 0.47%) +0.02s (+ 0.15%) 12.98s 13.29s
Compiler-Unions - node (v14.15.1, x64)
Memory used 200,440k (± 0.56%) 200,523k (± 0.48%) +83k (+ 0.04%) 199,133k 202,900k
Parse Time 0.80s (± 0.60%) 0.80s (± 0.60%) 0.00s ( 0.00%) 0.79s 0.81s
Bind Time 0.53s (± 0.76%) 0.53s (± 0.64%) +0.00s (+ 0.76%) 0.53s 0.54s
Check Time 9.68s (± 0.78%) 9.69s (± 0.53%) +0.00s (+ 0.03%) 9.60s 9.81s
Emit Time 2.36s (± 1.24%) 2.35s (± 1.16%) -0.01s (- 0.30%) 2.30s 2.43s
Total Time 13.36s (± 0.64%) 13.37s (± 0.48%) +0.00s (+ 0.03%) 13.24s 13.58s
Monaco - node (v14.15.1, x64)
Memory used 336,824k (± 0.00%) 336,828k (± 0.01%) +4k (+ 0.00%) 336,767k 336,902k
Parse Time 1.57s (± 0.57%) 1.57s (± 0.54%) +0.00s (+ 0.19%) 1.55s 1.59s
Bind Time 0.73s (± 1.06%) 0.73s (± 0.64%) -0.00s (- 0.14%) 0.72s 0.74s
Check Time 4.85s (± 0.47%) 4.87s (± 0.61%) +0.01s (+ 0.25%) 4.82s 4.94s
Emit Time 2.91s (± 0.68%) 2.90s (± 0.66%) -0.00s (- 0.07%) 2.87s 2.95s
Total Time 10.06s (± 0.34%) 10.07s (± 0.50%) +0.01s (+ 0.08%) 9.98s 10.19s
TFS - node (v14.15.1, x64)
Memory used 291,545k (± 0.01%) 291,517k (± 0.00%) -28k (- 0.01%) 291,477k 291,551k
Parse Time 1.25s (± 1.03%) 1.25s (± 1.22%) -0.01s (- 0.56%) 1.22s 1.29s
Bind Time 0.69s (± 0.86%) 0.69s (± 0.58%) -0.00s (- 0.43%) 0.68s 0.70s
Check Time 4.49s (± 0.36%) 4.50s (± 0.63%) +0.00s (+ 0.09%) 4.44s 4.58s
Emit Time 3.04s (± 0.94%) 3.04s (± 0.51%) +0.00s (+ 0.16%) 3.00s 3.08s
Total Time 9.48s (± 0.30%) 9.48s (± 0.37%) +0.00s (+ 0.02%) 9.38s 9.57s
material-ui - node (v14.15.1, x64)
Memory used 471,451k (± 0.06%) 471,552k (± 0.00%) +100k (+ 0.02%) 471,510k 471,585k
Parse Time 2.06s (± 0.46%) 2.05s (± 0.50%) -0.00s (- 0.24%) 2.02s 2.07s
Bind Time 0.70s (± 0.67%) 0.70s (± 0.57%) +0.00s (+ 0.14%) 0.69s 0.71s
Check Time 12.67s (± 1.39%) 12.65s (± 0.74%) -0.02s (- 0.17%) 12.44s 12.84s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.42s (± 1.15%) 15.40s (± 0.57%) -0.02s (- 0.14%) 15.22s 15.56s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-198-generic
Architecturex64
Available Memory16 GB
Available Memory8 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 42662 10
Baseline master 10

@typescript-bot typescript-bot mentioned this pull request Feb 6, 2021
Open
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@DanielRosenwasser DanielRosenwasser merged commit 4750369 into microsoft:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees

@sandersn sandersn

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined[] converted to any[] in js
4 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot @sandersn