Fix import fix on react or react dev #41950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? |
|
@xiaoxiangmoe No. |
|
I'm sorry to be that guy, but this PR has been approved almost two months ago. Is there any plan to include it in the next TypeScript release? This bug makes it very hard when working with the new jsx factory trasform, since auto-import code actions basically just stop working and you end up with a lot of spurious (and unused) imports from 'react'. |
|
Thank you @andrewbranch for the merge! 🙏 |
|
Sorry @gabro, I wanted to give others a chance to review, and it just slipped through the cracks. This will be released in 4.3 proper, or in the nightly starting tomorrow. |
|
No worries, thanks and keep up with the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41920