Skip to content

emit export declarations for system modules as a part of 'execute' me… #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2015

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Aug 6, 2015

…thod. fixes #4162. New output is aligned with what Babel will emit in the similar case

@vladima
Copy link
Contributor Author

vladima commented Aug 7, 2015

pinging @mhegazy

write(";");
}
}
}

function emitExportSpecifierInSystemModule(specifier: ExportSpecifier): void {
Debug.assert(compilerOptions.module === ModuleKind.System);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheetalkamat this looks related to your other change.. can u take a look.

@sheetalkamat
Copy link
Member

Lgtm. Once you checkin I will rebase my changes of your changes

vladima added a commit that referenced this pull request Aug 10, 2015
emit export declarations for system modules as a part of 'execute' me…
@vladima vladima merged commit 586abac into master Aug 10, 2015
@vladima vladima deleted the exportDeclarationsInSystem branch August 10, 2015 20:59
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables are not exported properlly when using ES6 Modules with default export and targetting SystemJS.
4 participants