Skip to content

Fix import tracker for dynamic import #41473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 2, 2020
Merged

Fix import tracker for dynamic import #41473

merged 8 commits into from
Dec 2, 2020

Conversation

Jack-Works
Copy link
Contributor

Fixes #41472

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 10, 2020
@Jack-Works Jack-Works force-pushed the fix/import-tracker-for-dynamic-import branch from d4ee91a to 8a55a58 Compare November 10, 2020 11:05
@Jack-Works
Copy link
Contributor Author

@weswigham would you like to take a look?

@Jack-Works
Copy link
Contributor Author

@Jack-Works Jack-Works force-pushed the fix/import-tracker-for-dynamic-import branch from 8a55a58 to 6a6ede1 Compare November 12, 2020 10:31
sandersn
sandersn requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions for now. I'll take a real look after Thanksgiving.

@sandersn sandersn self-assigned this Nov 25, 2020
@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 25, 2020
sandersn
sandersn requested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just one formatting request since a long 1-line if is hard to read (and I thought the linter forbade them entirely?).

@sandersn sandersn merged commit 0b6c925 into microsoft:master Dec 2, 2020
@Jack-Works Jack-Works deleted the fix/import-tracker-for-dynamic-import branch December 3, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access through dynamic import doesn't contribute to "reference"
3 participants
@Jack-Works @sandersn @typescript-bot