Skip to content

Make 'getIndentString' just use a loop. #41221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2020
Merged

Make 'getIndentString' just use a loop. #41221

merged 3 commits into from
Oct 26, 2020

Conversation

DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Oct 23, 2020 •
edited
Loading

CC @JasonGore

Fixes #41223

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 23, 2020
@DanielRosenwasser
Copy link
Member Author

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 23, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 1211264. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 23, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 1211264. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 23, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 1211264. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 23, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 1211264. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 23, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 1211264. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/87555/artifacts?artifactName=tgz&fileId=A962778E8B223D8B2C795394B2E32BACA62C32891DE2150F21B8AF74F6EBA5ED02&fileName=/typescript-4.1.0-insiders.20201023.tgz"
    }
}

and then running npm install.

@typescript-bot typescript-bot mentioned this pull request Oct 24, 2020
Open
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@DanielRosenwasser
Copy link
Member Author

Seems to fix the following repro:

/**
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                * This is a comment with dumb indentation for some auto-generated thing.
 */
export class SomeAutoGeneratedThing {}

@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 24, 2020
@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41221

Metric master 41221 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 350,595k (± 0.03%) 350,670k (± 0.01%) +75k (+ 0.02%) 350,571k 350,783k
Parse Time 2.01s (± 0.30%) 2.03s (± 0.64%) +0.01s (+ 0.74%) 2.00s 2.06s
Bind Time 0.83s (± 0.60%) 0.82s (± 0.72%) -0.00s (- 0.24%) 0.81s 0.84s
Check Time 5.42s (± 0.65%) 5.41s (± 0.32%) -0.00s (- 0.06%) 5.38s 5.47s
Emit Time 5.26s (± 0.77%) 5.28s (± 0.65%) +0.02s (+ 0.44%) 5.20s 5.37s
Total Time 13.51s (± 0.37%) 13.55s (± 0.31%) +0.03s (+ 0.25%) 13.47s 13.66s
Monaco - node (v10.16.3, x64)
Memory used 354,555k (± 0.02%) 354,628k (± 0.03%) +72k (+ 0.02%) 354,391k 354,886k
Parse Time 1.57s (± 0.63%) 1.57s (± 0.62%) +0.00s (+ 0.06%) 1.55s 1.59s
Bind Time 0.71s (± 0.81%) 0.71s (± 0.52%) +0.00s (+ 0.28%) 0.71s 0.72s
Check Time 5.52s (± 0.58%) 5.53s (± 0.52%) +0.01s (+ 0.09%) 5.46s 5.58s
Emit Time 2.76s (± 1.06%) 2.79s (± 0.97%) +0.02s (+ 0.87%) 2.75s 2.86s
Total Time 10.57s (± 0.46%) 10.60s (± 0.31%) +0.03s (+ 0.31%) 10.53s 10.66s
TFS - node (v10.16.3, x64)
Memory used 307,843k (± 0.02%) 307,840k (± 0.02%) -3k (- 0.00%) 307,695k 307,969k
Parse Time 1.22s (± 0.57%) 1.22s (± 0.61%) +0.00s (+ 0.33%) 1.21s 1.24s
Bind Time 0.67s (± 1.11%) 0.67s (± 0.92%) -0.00s (- 0.15%) 0.65s 0.68s
Check Time 5.04s (± 0.66%) 5.04s (± 0.52%) -0.00s (- 0.04%) 4.99s 5.10s
Emit Time 2.86s (± 1.08%) 2.88s (± 1.37%) +0.02s (+ 0.67%) 2.79s 2.96s
Total Time 9.78s (± 0.48%) 9.80s (± 0.45%) +0.02s (+ 0.24%) 9.68s 9.88s
material-ui - node (v10.16.3, x64)
Memory used 489,228k (± 0.01%) 489,273k (± 0.01%) +46k (+ 0.01%) 489,159k 489,408k
Parse Time 2.01s (± 0.51%) 2.02s (± 0.62%) +0.01s (+ 0.50%) 2.00s 2.05s
Bind Time 0.65s (± 0.73%) 0.65s (± 1.05%) -0.00s (- 0.15%) 0.63s 0.66s
Check Time 13.87s (± 0.69%) 13.84s (± 0.55%) -0.03s (- 0.24%) 13.75s 14.11s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.54s (± 0.57%) 16.50s (± 0.45%) -0.03s (- 0.19%) 16.39s 16.77s
Angular - node (v12.1.0, x64)
Memory used 327,748k (± 0.02%) 327,827k (± 0.03%) +78k (+ 0.02%) 327,636k 328,052k
Parse Time 2.01s (± 0.82%) 2.01s (± 0.57%) -0.00s (- 0.10%) 1.98s 2.04s
Bind Time 0.81s (± 0.45%) 0.81s (± 0.96%) +0.00s (+ 0.37%) 0.79s 0.82s
Check Time 5.34s (± 0.35%) 5.34s (± 0.45%) +0.00s (+ 0.07%) 5.30s 5.41s
Emit Time 5.43s (± 0.64%) 5.42s (± 0.64%) -0.01s (- 0.13%) 5.37s 5.54s
Total Time 13.58s (± 0.41%) 13.58s (± 0.39%) -0.00s (- 0.02%) 13.50s 13.75s
Monaco - node (v12.1.0, x64)
Memory used 336,693k (± 0.04%) 336,743k (± 0.02%) +50k (+ 0.01%) 336,598k 336,845k
Parse Time 1.54s (± 0.85%) 1.54s (± 0.65%) +0.00s (+ 0.13%) 1.52s 1.56s
Bind Time 0.69s (± 0.96%) 0.69s (± 0.96%) 0.00s ( 0.00%) 0.68s 0.71s
Check Time 5.38s (± 0.46%) 5.39s (± 0.60%) +0.02s (+ 0.30%) 5.33s 5.47s
Emit Time 2.83s (± 1.63%) 2.84s (± 0.87%) +0.00s (+ 0.07%) 2.80s 2.90s
Total Time 10.45s (± 0.56%) 10.46s (± 0.39%) +0.02s (+ 0.14%) 10.36s 10.57s
TFS - node (v12.1.0, x64)
Memory used 292,074k (± 0.01%) 292,069k (± 0.02%) -5k (- 0.00%) 291,945k 292,208k
Parse Time 1.24s (± 0.68%) 1.24s (± 0.91%) +0.00s (+ 0.16%) 1.22s 1.26s
Bind Time 0.64s (± 0.73%) 0.65s (± 1.06%) +0.01s (+ 0.78%) 0.64s 0.67s
Check Time 4.97s (± 0.39%) 4.99s (± 0.39%) +0.03s (+ 0.52%) 4.94s 5.04s
Emit Time 2.93s (± 0.79%) 2.94s (± 1.18%) +0.00s (+ 0.14%) 2.89s 3.06s
Total Time 9.78s (± 0.43%) 9.81s (± 0.34%) +0.03s (+ 0.33%) 9.76s 9.91s
material-ui - node (v12.1.0, x64)
Memory used 467,254k (± 0.05%) 467,154k (± 0.06%) -99k (- 0.02%) 466,334k 467,436k
Parse Time 2.02s (± 0.37%) 2.03s (± 0.59%) +0.01s (+ 0.25%) 2.01s 2.07s
Bind Time 0.64s (± 0.78%) 0.64s (± 0.78%) 0.00s ( 0.00%) 0.62s 0.64s
Check Time 12.43s (± 0.85%) 12.45s (± 1.02%) +0.02s (+ 0.15%) 12.24s 12.69s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.09s (± 0.67%) 15.11s (± 0.87%) +0.02s (+ 0.13%) 14.90s 15.36s
Angular - node (v8.9.0, x64)
Memory used 347,350k (± 0.02%) 347,269k (± 0.03%) -80k (- 0.02%) 347,041k 347,480k
Parse Time 2.57s (± 0.29%) 2.57s (± 0.24%) -0.00s (- 0.08%) 2.56s 2.59s
Bind Time 0.87s (± 0.97%) 0.87s (± 0.87%) +0.00s (+ 0.34%) 0.86s 0.89s
Check Time 5.97s (± 0.46%) 5.98s (± 0.57%) +0.01s (+ 0.10%) 5.88s 6.05s
Emit Time 6.24s (± 1.46%) 6.17s (± 1.34%) -0.07s (- 1.19%) 6.03s 6.34s
Total Time 15.66s (± 0.64%) 15.60s (± 0.62%) -0.06s (- 0.40%) 15.41s 15.82s
Monaco - node (v8.9.0, x64)
Memory used 355,828k (± 0.02%) 355,790k (± 0.02%) -38k (- 0.01%) 355,630k 355,909k
Parse Time 1.90s (± 0.84%) 1.89s (± 0.43%) -0.01s (- 0.37%) 1.87s 1.91s
Bind Time 0.90s (± 0.41%) 0.90s (± 0.49%) +0.01s (+ 0.78%) 0.89s 0.91s
Check Time 6.15s (± 1.58%) 6.08s (± 0.55%) -0.06s (- 1.03%) 6.03s 6.19s
Emit Time 3.23s (± 3.89%) 3.32s (± 0.39%) +0.09s (+ 2.82%) 3.28s 3.34s
Total Time 12.16s (± 0.53%) 12.19s (± 0.29%) +0.03s (+ 0.25%) 12.13s 12.31s
TFS - node (v8.9.0, x64)
Memory used 309,458k (± 0.01%) 309,459k (± 0.01%) +1k (+ 0.00%) 309,341k 309,551k
Parse Time 1.56s (± 0.50%) 1.55s (± 0.53%) -0.01s (- 0.32%) 1.54s 1.57s
Bind Time 0.68s (± 0.55%) 0.68s (± 0.44%) +0.00s (+ 0.44%) 0.67s 0.68s
Check Time 5.73s (± 0.68%) 5.77s (± 0.57%) +0.04s (+ 0.72%) 5.71s 5.87s
Emit Time 2.96s (± 0.69%) 2.99s (± 1.11%) +0.03s (+ 0.94%) 2.94s 3.11s
Total Time 10.93s (± 0.48%) 11.00s (± 0.55%) +0.07s (+ 0.61%) 10.89s 11.15s
material-ui - node (v8.9.0, x64)
Memory used 493,589k (± 0.01%) 493,564k (± 0.01%) -25k (- 0.01%) 493,477k 493,696k
Parse Time 2.42s (± 0.48%) 2.42s (± 0.37%) +0.00s (+ 0.12%) 2.41s 2.45s
Bind Time 0.81s (± 0.61%) 0.80s (± 0.62%) -0.00s (- 0.12%) 0.80s 0.82s
Check Time 18.17s (± 1.06%) 18.18s (± 0.80%) +0.01s (+ 0.03%) 17.96s 18.53s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.40s (± 0.91%) 21.40s (± 0.71%) +0.01s (+ 0.04%) 21.18s 21.80s
Angular - node (v8.9.0, x86)
Memory used 199,209k (± 0.02%) 199,231k (± 0.02%) +21k (+ 0.01%) 199,118k 199,323k
Parse Time 2.49s (± 0.97%) 2.49s (± 0.66%) +0.00s (+ 0.04%) 2.47s 2.53s
Bind Time 1.01s (± 0.82%) 1.02s (± 1.00%) +0.01s (+ 0.69%) 1.00s 1.05s
Check Time 5.45s (± 0.50%) 5.48s (± 0.53%) +0.03s (+ 0.46%) 5.41s 5.54s
Emit Time 6.02s (± 0.75%) 5.99s (± 1.18%) -0.03s (- 0.43%) 5.79s 6.18s
Total Time 14.97s (± 0.24%) 14.98s (± 0.60%) +0.01s (+ 0.07%) 14.70s 15.18s
Monaco - node (v8.9.0, x86)
Memory used 201,599k (± 0.03%) 201,615k (± 0.01%) +16k (+ 0.01%) 201,564k 201,691k
Parse Time 1.94s (± 0.84%) 1.94s (± 0.94%) -0.01s (- 0.31%) 1.91s 1.97s
Bind Time 0.71s (± 0.78%) 0.71s (± 0.91%) 0.00s ( 0.00%) 0.70s 0.72s
Check Time 6.19s (± 0.72%) 6.18s (± 0.34%) -0.01s (- 0.18%) 6.14s 6.23s
Emit Time 2.71s (± 0.62%) 2.71s (± 0.72%) -0.00s (- 0.18%) 2.68s 2.77s
Total Time 11.56s (± 0.49%) 11.54s (± 0.37%) -0.02s (- 0.16%) 11.44s 11.63s
TFS - node (v8.9.0, x86)
Memory used 176,933k (± 0.04%) 176,968k (± 0.03%) +34k (+ 0.02%) 176,847k 177,055k
Parse Time 1.61s (± 1.15%) 1.60s (± 0.95%) -0.01s (- 0.68%) 1.57s 1.65s
Bind Time 0.64s (± 1.62%) 0.64s (± 0.47%) -0.00s (- 0.62%) 0.63s 0.64s
Check Time 5.28s (± 0.79%) 5.32s (± 0.54%) +0.04s (+ 0.76%) 5.25s 5.38s
Emit Time 2.82s (± 1.27%) 2.83s (± 1.06%) +0.02s (+ 0.57%) 2.74s 2.88s
Total Time 10.35s (± 0.44%) 10.39s (± 0.50%) +0.04s (+ 0.41%) 10.22s 10.49s
material-ui - node (v8.9.0, x86)
Memory used 277,942k (± 0.02%) 277,938k (± 0.02%) -4k (- 0.00%) 277,853k 278,063k
Parse Time 2.49s (± 0.55%) 2.48s (± 0.48%) -0.01s (- 0.44%) 2.45s 2.50s
Bind Time 0.72s (± 6.00%) 0.71s (± 4.74%) -0.01s (- 1.66%) 0.67s 0.84s
Check Time 16.88s (± 0.59%) 16.84s (± 0.39%) -0.04s (- 0.26%) 16.68s 16.95s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.09s (± 0.40%) 20.03s (± 0.45%) -0.07s (- 0.33%) 19.82s 20.23s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory2 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 41221 10
Baseline master 10

@RyanCavanaugh
Copy link
Member

I was going to post Milton + "I was told there would be tail call optimizations" but then it wasn't a tail call 😑

@DanielRosenwasser DanielRosenwasser merged commit 3517af8 into master Oct 26, 2020
@DanielRosenwasser DanielRosenwasser deleted the nonRecursiveGetIndentString branch October 26, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees

@DanielRosenwasser DanielRosenwasser

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack overflow on getIndentString with unreasonable auto-generated code
4 participants
@DanielRosenwasser @typescript-bot @RyanCavanaugh @sheetalkamat