Fixes renaming not affecting JSX closing tags (#4093) #4096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //// var x = <[|MyC/**/lass|] name='hello'></[|MyClass|]>; | ||
|
|
||
| goTo.marker(); | ||
| debugger; |
There was a problem hiding this comment.
I thought I removed this 😢
| @@ -30,6 +30,7 @@ tests/cases/conformance/jsx/jsxInvalidEsprimaTestSuite.tsx(11,12): error TS2304: | |||
| tests/cases/conformance/jsx/jsxInvalidEsprimaTestSuite.tsx(11,16): error TS1109: Expression expected. | |||
| tests/cases/conformance/jsx/jsxInvalidEsprimaTestSuite.tsx(12,2): error TS2304: Cannot find name 'a'. | |||
| tests/cases/conformance/jsx/jsxInvalidEsprimaTestSuite.tsx(12,5): error TS1003: Identifier expected. | |||
| tests/cases/conformance/jsx/jsxInvalidEsprimaTestSuite.tsx(12,10): error TS2304: Cannot find name 'a'. | |||
There was a problem hiding this comment.
it is unfortunate that we report the same error twice.
|
👍 |
RyanCavanaugh
added a commit
that referenced
this pull request
Aug 6, 2015
Fixes renaming not affecting JSX closing tags (#4093)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4093
We weren't wiring up the closing tags to their corresponding symbols.
This does have a side effect of causing "name not found" errors on closing tags that will always match the opening tag names. We could probably fix this if it's problematic, but would require plumbing through another boolean fairly deep into the core identifier resolution functions.