Skip to content

fix(40901): Variable arguments generated from JS although not applicable #40912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

fix(40901): Variable arguments generated from JS although not applicable #40912

merged 1 commit into from
Nov 2, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #40901

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Oct 2, 2020
RyanCavanaugh
RyanCavanaugh reviewed Oct 2, 2020
View reviewed changes
@m-mohr
Copy link

m-mohr commented Oct 5, 2020 •
edited
Loading

Please also check whether the additional code example in #40901 (comment) is covered by this PR.

@m-mohr m-mohr mentioned this pull request Oct 5, 2020
Closed
@sandersn sandersn requested a review from weswigham October 9, 2020 15:21
weswigham
weswigham approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the resolved symbol identity check makes sense.

@a-tarasyuk
Copy link
Contributor Author

@weswigham thanks.

@sandersn sandersn merged commit f646ec8 into microsoft:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@RyanCavanaugh RyanCavanaugh

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable arguments generated from JS although not applicable
6 participants
@a-tarasyuk @m-mohr @weswigham @RyanCavanaugh @sandersn @typescript-bot