Fix recursive types in @typedef #40861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this code path was broken and untested. Fortunately the fix is simple.
typescript-bot
added
Author: Team
For Milestone Bug
sandersn
changed the title
weswigham
approved these changes
Oct 1, 2020
|
Oops, forgot to update baselines now that type aliases created by typedefs are properly deferred. I'll do that. |
|
Why does this work for: /** @typedef {Json[]} JsonArray */
/** @typedef {{ readonly [key: string]: Json }} JsonRecord */
/** @typedef {boolean | number | string | null | JsonRecord | JsonArray | readonly []} Json */But not if /** @typedef {Object<string, Json>} JsonRecord */Then it errors with: (thank you a lot for this PR, it is already tremendously useful) |
|
@kungfooman can you open a fresh bug for that? |
@sandersn There is this one already, I think it's the same issue: #46369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this code path was broken and untested. Fortunately the fix is simple -- the code that looks for the alias' host needs to skip the JSDoc type expression node as it walks up the tree.
Fixes #39372
Fixes #40234