-
Notifications
You must be signed in to change notification settings - Fork 12.9k
fix(40322): bad completions for string literal type as indexed access type object #40424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DanielRosenwasser here is the PR for #40322 |
DanielRosenwasser
requested changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use spaces after
if
s - You shouldn't need a type assertion to
any
anywhere. - Just use an early bail-out to return
undefined
when you're in the wrong node.
DanielRosenwasser
requested changes
Sep 8, 2020
tests/cases/fourslash/completionListsStringLiteralTypeAsIndexedAccessTypeObject.ts
Outdated
Show resolved
Hide resolved
DanielRosenwasser
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40322
let x: "/*foo*/"["bar"];
Added validation to prevent completion on a string literal when it is the object type.
The cursor at the marker foo will not have autocompletion.
Backlog
milestone (required)master
branchgulp runtests
locally